CKEditor 5 support

+1 for CKeditor5 support

Conducting an investigation and with the update of the embed module I tested taking the output for embedding a view from Ckeditor4 and simply pasted it into the source for a ckeditor5 page.

To my surprise the embed and rendering worked!

I noted in ckeditor4 that the placement of the view embed didn't render in editor mode anymore.
And of course the button and dialog is missing from ckeditor5, since the plugin api has totally changed.

Official Documentation
https://ckeditor.com/docs/ckeditor5/latest/framework/guides/plugins/crea...

Ckeditor5 Dev Tools
https://www.drupal.org/project/ckeditor5_dev →

Article Overview on components
https://tech.axelerant.com/create-and-integrate-ckeditor-5-plugin-with-d...

The Challenge is writing a new integration plugin into the current module to use the previous display and lookup methods to embed the templated embed object into the editor.

The input plugin and template parser appear to be working in Drupal 9.5.5 and ckeditor5!

I pushed some initial changes to the fork. This depends on an entity embed issue landing that adds much of the necessary logic: ✨ Drupal 10 & CKEditor 5 readiness Fixed . Fortunately, many consider landing that a high priority and it's likely to get in soon. If anyone wants to work on this prior to that landing, they should have entity embed on that issue branch.

The fork here is far from complete, but it's already making itself available as a CKEditor 5 plugin that can open the embed views dialog. That's further along than I expected without writing any CKEditor 5 plugin code - this was purely leveraging the plugin provided by entity embed. Unfortunately, submitting the form doesn't successfully add the view, so I assume some CKEditor5 JS will need to be added. Worst case, this can wind up being a copypaste of the entity_embed plugin with small changes to get it working with the views embed. The logic will largely be the same, but preview endpoints and perhaps attributes used will need changing, but most of the logic needed is basically there.

There's probably some cleaning up needed but the MR now has a working CKEditor 5 plugin. Here's a short video of it in action https://youtu.be/4FDWNzidAXI

Remember that this requires the entity embed code provided here ✨ Drupal 10 & CKEditor 5 readiness Fixed . At the time I'm typing this, it has not yet been merged / released, but this should be happening soon.

Also, this won't likely work with the CKEditor 5 version in Drupal 9 - but the Drupal 10 CKEditor 5 is more current and should be fine.

I'm setting this to "Needs Review" to get eyes on it, but it probably needs a round or two of refinement before it's fully ready. The parts that require CKEditor 5 knowledge are all set.

Patch works good on CKEditor 5. However, it overwrites Entity Embed.
When Entity Embed (EE) and Views Entity Embed are enabled (VEE), VEE overwrites EE.
Both are not working together

Is that why I'm getting this error:

Drupal\Component\Plugin\Exception\InvalidDeriverException: Plugin (views_entity_embed_drupalentity) deriver "Drupal\entity_embed\Plugin\CKEditor5Plugin\DrupalEntityDeriver" does not exist. in Drupal\Component\Plugin\Discovery\DerivativeDiscoveryDecorator->getDeriverClass() (line 218 of core/lib/Drupal/Component/Plugin/Discovery/DerivativeDiscoveryDecorator.php).

?

@megan_m: no, that suggests that you are running a version of Entity Embed that does not yet support CKEditor 5. Try updating to the dev release.

I applied this MR 7 using this patch
https://git.drupalcode.org/project/views_entity_embed/-/merge_requests/7...

and afterwords my 2 embed buttons for embedding blocks and nodes did not work anymore. Each button wants to embed views instead of blocks or nodes:

This patch has negative effects on the Entity Embed module! Embeding blocks and nodes do not work anymore.

But I would need a working solution.
Can you help?

Thank you very much.

I have attempted to implement Merge Request (MR) #7 to upgrade my existing Drupal 9.5.11 site with CKEditor 5. However, the functionality is not working as expected. Despite adding View Embed toolbar to Full HTML, the text editor is operating only in plain text mode, but the existing data remains unchanged.see screen shot (ckditor5plaintext)

After testing with Drupal 10, I replicated the same configuration on my site using view entity embed. Now, the text editor is functioning properly with the changes introduced in Merge Request (MR) #7.

for enabling the only view entity embed toolbar both the filter is required "Display embedded entities" & Display embedded views.

I have implemented a patch to address the issues in Drupal 9.5 and CKEditor 5. Upon conducting research, I discovered a similar problem documented on https://www.drupal.org/project/entity_embed/issues/3396133 🐛 Ckeditor 5 Interface not loading on text formats using entity embed Active . I adopted the same approach outlined there to resolve the issues, and after testing, I can confirm that the patch effectively resolves the problem.

I have conducted thorough testing on Drupal 10.1.5, and there no JavaScript errors. Additionally, CKEditor 5 is functioning as expected without any console issues.

I kindly request your review of the changes.

Is the patch the same as the MR or different?

This patch differs from the previously mentioned MR. After thoroughly testing the Merge Request (MR) for CKEditor 5 in Drupal 9.5, I have observed some console issues as i have mentioned in #19. To address these concerns, I have introduced an additional patch. Please let me know if i can move these changes to the MR.

Yes. Please add to the MR so I better review what is different.

Sure, i have pushed my changes in this MR . please review.
Thanks

That last commit is impossible to review because it looks like everything changed. Can you explain what is different?

I made modifications to the toolbar.js file for the CKEditor5 plugin. Subsequently, I generated the updated build JS file using the build command.

For info, latest version of merge request 7 has worked for us.
Config: PHP 8.3.3, Drupal 10.2.4, embed 8.x-1.7, entity_embed 8.x-1.5, views_entity_embed 2.0.2

Merge request #7 works for me and views embed button works correctly but other embed buttons stoped working. For example, if I add new embed button that embeds webform, block or media, then this buttons works as views embed buttons and show View Embed modal form. If I disable "Display embedded views" filter, then they works as expected.

Now it works on my side.

I applied MR !7 got below error:

error: patch failed: src/Plugin/EmbedType/EmbedViews.php:43
error: src/Plugin/EmbedType/EmbedViews.php: patch does not apply

Try to use this patch link: https://git.drupalcode.org/project/views_entity_embed/-/merge_requests/7...

Thanks, #31 patch solved this other issue 🐛 The icon does not appear or work in Ckeditor Closed: duplicate (button wasn't showing), plus entity_embed kept working, but the embedded view is NOT shown, either while editing the content, neither when viewing it (after saving).

The CKEditor source looks wrong (I put the core's Recent content block, without overriding its title):
<drupal-views data-embed-button="test" data-view-name="content_recent" data-view-display="default" data-view-arguments="{&quot;override_title&quot;:0,&quot;title&quot;:&quot;&quot;,&quot;no_contextual_filters&quot;:&quot;&quot;}">&nbsp;</drupal-views>

I'm testing with a fresh Drupal 10.3.1 site.

Funny thing: I tried enabling insert_view_adv module and the same node immediately showed the View (both while editing and viewing the node) I had inserted with this module 😅
I guess the wanted sintax is the same.. and maybe it's worth to merge the two modules?!

The difference I see is that insert_view_adv adds the form to enable the views and their display as a long list directly in the text formats configs, while views_entity_embed builds on top of the embed buttons provided by embed module, imho slightly better cause it enables multiple buttons with different settings.
Even the dialog in a single step seems slightly preferable..

I tested on a fresh site with MR !7 and didn't have any issues.

Steps Taken:

1. Install fresh Drupal 10.3.1 site
2. Composer require Views Entity Embed module
3. Apply MR !7
4. Enable Views Entity Embed
5. Add Views button to text format
6. Enable Display embedded views and Display embedded entities for text format
7. Create node with embedded View

I wasn't able to reproduce the issue described in #32. Can you test again and see if you notice the same issue?