Created on 15 November 2023, over 1 year ago
Updated 12 December 2023, over 1 year ago

Problem/Motivation

Current scripts have simple comments inside.
Custom events should be described globally.

Proposed resolution

Add core style javascript documentation:
https://www.drupal.org/docs/develop/standards/javascript-coding-standard... ā†’

āœØ Feature request
Status

Fixed

Version

1.0

Component

Code

Created by

šŸ‡·šŸ‡øSerbia finnsky

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @finnsky
  • Pipeline finished with Failed
    over 1 year ago
    Total: 1270s
    #60055
  • First commit to issue fork.
  • Merge request !147Resolve #3401807 "Document scripts" ā†’ (Merged) created by Meeni_Dhobale
  • Status changed to Needs review over 1 year ago
  • šŸ‡®šŸ‡³India Meeni_Dhobale

    I raised the MR by adding some comments and tags where needed. I also followed the javascript coding standards ā†’ as well.

    while checking for the linting errors I found one.

    modules/contrib/navigation/js/toolbar-popover.js
      102:15  error  'close' was used before it was defined  no-use-before-define
    
    āœ– 1 problem (1 error, 0 warnings)

    the same error shown by the delayedClose() as well, So I moved it upwards before the close() and open() functions, but inside he delayedClose() the close() is called. So here circular deadlock occurs.
    Is there any solution to solve this.

  • Status changed to RTBC over 1 year ago
  • šŸ‡·šŸ‡øSerbia finnsky

    I think we can avoid that formatting change here.
    Looks good to me. Thank you

  • Status changed to Fixed over 1 year ago
  • šŸ‡ŖšŸ‡øSpain ckrina Barcelona

    Thanks both!!

  • Pipeline finished with Skipped
    over 1 year ago
    #64671
  • Pipeline finished with Failed
    over 1 year ago
    Total: 1199s
    #64668
  • Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Success
    about 1 year ago
    Total: 33s
    #113050
  • Pipeline finished with Failed
    about 1 year ago
    Total: 677s
    #118276
  • Pipeline finished with Failed
    about 1 year ago
    Total: 882s
    #118332
  • Pipeline finished with Failed
    about 1 year ago
    Total: 1080s
    #118358
  • Pipeline finished with Success
    about 1 year ago
    Total: 1028s
    #118466
  • Pipeline finished with Success
    about 1 year ago
    Total: 197s
    #118775
  • Pipeline finished with Skipped
    about 1 year ago
    #119055
  • Pipeline finished with Success
    about 1 year ago
    Total: 167s
    #119451
Production build 0.71.5 2024