- Issue created by @finnsky
- First commit to issue fork.
- Status changed to Needs review
over 1 year ago 10:36am 11 December 2023 - š®š³India Meeni_Dhobale
I raised the MR by adding some comments and tags where needed. I also followed the javascript coding standards ā as well.
while checking for the linting errors I found one.
modules/contrib/navigation/js/toolbar-popover.js 102:15 error 'close' was used before it was defined no-use-before-define ā 1 problem (1 error, 0 warnings)
the same error shown by the delayedClose() as well, So I moved it upwards before the close() and open() functions, but inside he delayedClose() the close() is called. So here circular deadlock occurs.
Is there any solution to solve this. - Status changed to RTBC
over 1 year ago 7:36pm 11 December 2023 - š·šøSerbia finnsky
I think we can avoid that formatting change here.
Looks good to me. Thank you -
ckrina ā
committed b5290e70 on 1.x authored by
Meeni_Dhobale ā
Resolve #3401807 "Document scripts"
-
ckrina ā
committed b5290e70 on 1.x authored by
Meeni_Dhobale ā
- Status changed to Fixed
over 1 year ago 10:09am 12 December 2023 Automatically closed - issue fixed for 2 weeks with no activity.