In workspace-form the text of the modal content is not visible completely below 768px screen.

Hi, working on the issue.

swatidhurandhar → made their first commit to this issue’s fork.

I have created a MR where I have set the max-height of UI dialog content for workspace module.

@swatidhurandhar I have tested the shared patch MR !6019 mergeable I was able to reproduce this issue but was unable to apply the shared patch. Sharing the error here which I was getting while applying the patch.

@Sandeep_k It is warning not errors, the patch is adding the code.

Hi @swatidhurandhar

I tested your Merge request! 6019 and it fixed the issue but there are some warnings you need to check. I think your editor using tab space.

core/6019.patch.txt:36: tab in indent.
		.ui-dialog {
core/6019.patch.txt:37: tab in indent.
			.ui-dialog-content {
core/6019.patch.txt:38: tab in indent.
				max-height: 5rem !important;
core/6019.patch.txt:39: tab in indent.
			}
core/6019.patch.txt:40: tab in indent.
		}
Checking patch core/modules/workspaces/css/workspaces.off-canvas.css...
Checking patch core/modules/workspaces/css/workspaces.off-canvas.pcss.css...
Checking patch core/modules/workspaces/css/workspaces.off-canvas.pcss.css...
Checking patch core/modules/workspaces/css/workspaces.off-canvas.pcss.css...
Applied patch core/modules/workspaces/css/workspaces.off-canvas.css cleanly.
Applied patch core/modules/workspaces/css/workspaces.off-canvas.pcss.css cleanly.
Applied patch core/modules/workspaces/css/workspaces.off-canvas.pcss.css cleanly.
Applied patch core/modules/workspaces/css/workspaces.off-canvas.pcss.css cleanly.
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.

Thanks @swatidhurandhar, I have checked & the code is updated.
Testing Steps-

• Enable the workspace module.
• Download & apply the patch.
• Switch the screen below 768px
• Click on workspace on the right side & change the workspace.
• Reverify the modal content text.

Testing Results
Error is fixed successfully after applying the patch, We can remove the space to fix these warnings as well. Sharing after results. RTBC ++

Added code inside the media query as above 767px screen the modal content is working fine so I added media query below 767px
Thanks

Hi,
I verified and tested MR!6019 on Drupal version- 11.0-dev.
The patch was applied successfully.

Testing Steps:

1. Set up Drupal 11.
2. Enable the workspace module.
3. Switch the screen below 768px
4. Click on workspace on the right side.
5. See the modal content text, which gets cropped
6. Download the patch and Apply.
7. Reverify the modal content text for the screen below the 768px.

Testing Results:
Now the modal content text is not cropped and it's fully visible
screenshots added for reference

Moving to RTBC++

Gauravvvv → made their first commit to this issue’s fork.

Instead of hardcoding a value, we can simply unset the max-height added by JavaScript to resolve the height issue.

I have updated the MR.

Verified the Issue after the update in the MR . Issue is fixed

Testing Steps:
1. Enable the workspace module.
2. Switch the screen below 768px
3. Click on workspace on the right side.
4. See the modal content text, which gets cropped
5. Download the patch and Apply.
6. Reverify the modal content text for the screen below the 768px.

Testing Results:
The modal content text is not cropped and it's fully visible on or below 768px
screenshots added for reference

Moving to RTBC++

I'm triaging RTBC issues → . I read the IS and the comments. I didn't find any unanswered questions or other work to do.

@shweta__sharma, thanks for reporting this problem.

Since this change the UI it should have the latest before and after screenshots linked to in the Issue Summary. That way reviewers and committers can easily find them. The proposed resolution is to remove max-height: 0px; but that line is not removed in the MR. For this short issue I don't think those points are enough to warrant sending this back to needs work. However, other committers may choose to do so.

It really is good practice in Drupal to help reviewers and committers to have the Issue Summary up to date. A complete issue summary is inviting.

Sure @quietone

Updated IS template.

Thanks

I'd very much rather not having to use !important.

Can we avoid this? making the rule more specific could work.

We're overriding the value of max-height added by JavaScript using !important.

works for me, thanks for the context

Can we add a comment explaining that in the CSS? It'll help future us find out why !important was used.

Mithun S → made their first commit to this issue’s fork.

Restoring status, RTBC as a comment has been added to CSS code.

nod_ → closed merge request !6019

Committed 00329c2 and pushed to 11.x. Thanks!

Automatically closed - issue fixed for 2 weeks with no activity.