- Issue created by @ckrina
- 🇪🇸Spain ckrina Barcelona
Adding the active trail styles regression from 🐛 Active trail is not showing anymore Active . That issue is only to add back the styles, this one is to change the functionality itself.
Also, I think we should add tests too for this. But I'm happy with the tests happening in a followup where the discussion about how tests should be included can happen if needed.
- First commit to issue fork.
- Status changed to Needs review
about 1 year ago 8:46am 7 December 2023 - 🇮🇳India Meeni_Dhobale
I modified JavaScript where previously we checked that our menu link is the same as our URL. Now it checks whether the URL contains our menu link or not. This is solving our problem.
- Status changed to RTBC
about 1 year ago 8:57am 7 December 2023 - 🇷🇸Serbia finnsky
Thank you!
Looks great on all subpages.Catched one not related bug. We need to resolve it in follow up issue:
- Status changed to Fixed
about 1 year ago 11:41am 7 December 2023 - 🇪🇸Spain ckrina Barcelona
Nice! Thanks you!
@finnsky Good catch! Would you create an issue for that when you have some time?
Automatically closed - issue fixed for 2 weeks with no activity.