Fix the errors/warnings reported by PHP_CodeSniffer

Created on 11 May 2023, about 1 year ago
Updated 14 December 2023, 6 months ago

Problem/Motivation

There are following errors and warnings which are reported by PHP code sniffer within the module :

FILE: ...signment\web\modules\contrib\pantheon_advanced_page_cache\config\install\pantheon_advanced_page_cache.settings.yml
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] Expected 1 newline at end of file; 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...mpp\htdocs\backendassignment\web\modules\contrib\pantheon_advanced_page_cache\pantheon_advanced_page_cache.install
------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 9 | WARNING | [ ] Line exceeds 80 characters; contains 143 characters
 9 | ERROR   | [x] Doc comment short description must end with a full stop
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\pantheon_advanced_page_cache\README.md
--------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 11 WARNINGS AFFECTING 11 LINES
--------------------------------------------------------------------------------------------------
  9 | WARNING | Line exceeds 80 characters; contains 337 characters
 11 | WARNING | Line exceeds 80 characters; contains 150 characters
 17 | WARNING | Line exceeds 80 characters; contains 237 characters
 19 | WARNING | Line exceeds 80 characters; contains 266 characters
 23 | WARNING | Line exceeds 80 characters; contains 85 characters
 25 | WARNING | Line exceeds 80 characters; contains 102 characters
 29 | WARNING | Line exceeds 80 characters; contains 91 characters
 31 | WARNING | Line exceeds 80 characters; contains 122 characters
 34 | WARNING | Line exceeds 80 characters; contains 151 characters
 40 | WARNING | Line exceeds 80 characters; contains 173 characters
 41 | WARNING | Line exceeds 80 characters; contains 90 characters
--------------------------------------------------------------------------------------------------


FILE: C:\xampp\htdocs\backendassignment\web\modules\contrib\pantheon_advanced_page_cache\src\CacheTagsInvalidator.php
---------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
---------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
---------------------------------------------------------------------------------------------------------------------


FILE: ...endassignment\web\modules\contrib\pantheon_advanced_page_cache\src\EventSubscriber\CacheableResponseSubscriber.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
 43 | WARNING | [ ] \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...tdocs\backendassignment\web\modules\contrib\pantheon_advanced_page_cache\tests\behat\helper_classes\AgeTracker.php
------------------------------------------------------------------------------------------------------------------------
FOUND 55 ERRORS AND 6 WARNINGS AFFECTING 47 LINES
------------------------------------------------------------------------------------------------------------------------
  1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  7 | ERROR   | [x] Missing class doc comment
  8 | ERROR   | [x] Opening brace should be on the same line as the declaration
 11 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 11 | ERROR   | [x] Missing function doc comment
 11 | ERROR   | [x] Expected 1 blank line before function; 2 found
 12 | ERROR   | [x] Opening brace should be on the same line as the declaration
 13 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 16 | WARNING | [x] A comma should follow the last multiline array item. Found: 'x-timer'
 18 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 18 | ERROR   | [x] Expected 1 blank line after function; 0 found
 19 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 19 | ERROR   | [x] Missing function doc comment
 20 | ERROR   | [x] Opening brace should be on the same line as the declaration
 21 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 22 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 23 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 24 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 25 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 26 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 28 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 28 | ERROR   | [x] Missing function doc comment
 29 | ERROR   | [x] Opening brace should be on the same line as the declaration
 30 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 31 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 36 | WARNING | [x] A comma should follow the last multiline array item. Found: 'x-timer'
 39 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 40 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 40 | ERROR   | [x] Expected 1 blank line after function; 2 found
 43 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 43 | ERROR   | [x] Missing function doc comment
 44 | ERROR   | [x] Opening brace should be on the same line as the declaration
 45 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 46 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 48 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 48 | ERROR   | [x] Missing function doc comment
 49 | ERROR   | [x] Opening brace should be on the same line as the declaration
 50 | WARNING | [ ] Line exceeds 80 characters; contains 103 characters
 50 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 9
 51 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 9
 52 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 9
 53 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 9
 54 | WARNING | [ ] Line exceeds 80 characters; contains 113 characters
 54 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 9
 55 | WARNING | [ ] Line exceeds 80 characters; contains 83 characters
 55 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 9
 56 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 9
 57 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 9
 58 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 60 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 60 | ERROR   | [x] Missing function doc comment
 61 | ERROR   | [x] Opening brace should be on the same line as the declaration
 62 | WARNING | [ ] Line exceeds 80 characters; contains 102 characters
 62 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 63 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 64 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 65 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 66 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 67 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 68 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 68 | ERROR   | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 57 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...assignment\web\modules\contrib\pantheon_advanced_page_cache\tests\behat\helper_classes\Contexts\FeatureContext.php
------------------------------------------------------------------------------------------------------------------------
FOUND 167 ERRORS AND 4 WARNINGS AFFECTING 136 LINES
------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  13 | WARNING | [x] '@todo, this class should be abstracted into it's own Behat Extension that can be used to test
     |         |     WordPress, D7 & D8.' should match the format '@todo Fix problem X here.'
  16 | ERROR   | [x] Opening brace should be on the same line as the declaration
  18 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  19 | ERROR   | [x] Expected 5 space(s) before asterisk; 4 found
  20 | ERROR   | [x] Expected 5 space(s) before asterisk; 4 found
  20 | ERROR   | [ ] Doc comment short description must be on a single line, further text should be a separate
     |         |     paragraph
  21 | ERROR   | [x] Expected 5 space(s) before asterisk; 4 found
  22 | ERROR   | [x] Expected 5 space(s) before asterisk; 4 found
  23 | ERROR   | [x] Expected 5 space(s) before asterisk; 4 found
  24 | ERROR   | [x] Expected 5 space(s) before asterisk; 4 found
  25 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  26 | ERROR   | [x] Opening brace should be on the same line as the declaration
  27 | ERROR   | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing
     |         |     parentheses
  28 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  30 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  30 | ERROR   | [x] The open comment tag must be the only content on the line
  30 | ERROR   | [ ] Missing short description in doc comment
  30 | ERROR   | [x] Expected "\Drupal\DrupalExtension\Context\MinkContext" but found
     |         |     "\Drupal\DrupalExtension\Context\MinkContext " for @var tag in member variable comment
  31 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  33 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  33 | ERROR   | [x] The open comment tag must be the only content on the line
  33 | ERROR   | [ ] Missing short description in doc comment
  33 | ERROR   | [x] Expected "\PantheonSystems\CDNBehatHelpers\AgeTracker" but found
     |         |     "\PantheonSystems\CDNBehatHelpers\AgeTracker; " for @var tag in member variable comment
  34 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  36 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  36 | ERROR   | [x] The open comment tag must be the only content on the line
  36 | ERROR   | [ ] Missing short description in doc comment
  36 | ERROR   | [x] Expected "\Drupal\DrupalExtension\Context\DrupalContext" but found
     |         |     "\Drupal\DrupalExtension\Context\DrupalContext " for @var tag in member variable comment
  37 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  37 | ERROR   | [ ] Class property $DrupalContext should use lowerCamel naming without underscores
  39 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  39 | ERROR   | [x] The open comment tag must be the only content on the line
  39 | ERROR   | [ ] Missing short description in doc comment
  40 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  41 | ERROR   | [x] Opening brace should be on the same line as the declaration
  42 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  43 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  44 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  45 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  47 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  47 | ERROR   | [ ] Missing short description in doc comment
  50 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  50 | ERROR   | [ ] Public method name "FeatureContext::whenIGenerateSomeNodes" is not in lowerCamel format
  51 | ERROR   | [x] Opening brace should be on the same line as the declaration
  52 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  53 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  54 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  55 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  56 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  57 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  59 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  59 | ERROR   | [ ] Missing short description in doc comment
  62 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  62 | ERROR   | [ ] Public method name "FeatureContext::whenIGenerateANode" is not in lowerCamel format
  63 | ERROR   | [x] Opening brace should be on the same line as the declaration
  64 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  65 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  66 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  67 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  68 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  69 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  70 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  71 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  72 | WARNING | [x] '@todo, remove this sleep if possible. Added because this faster node generation results in'
     |         |     should match the format '@todo Fix problem X here.'
  72 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  73 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  74 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  75 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  76 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  77 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  78 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  79 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  81 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  81 | ERROR   | [ ] Missing short description in doc comment
  84 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  85 | ERROR   | [x] Opening brace should be on the same line as the declaration
  86 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  87 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  88 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  89 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  90 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  90 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  91 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  91 | ERROR   | [x] Expected newline after closing brace
  92 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  93 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  94 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  95 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  96 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  96 | ERROR   | [x] Expected newline after closing brace
  97 | ERROR   | [x] Line indented incorrectly; expected 8 spaces, found 16
  97 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  98 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  99 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 100 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 102 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 102 | ERROR   | [ ] Missing short description in doc comment
 105 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 106 | ERROR   | [x] Opening brace should be on the same line as the declaration
 107 | WARNING | [ ] Unused variable $age.
 107 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 108 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 109 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 110 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 111 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 112 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 114 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 114 | ERROR   | [ ] Missing short description in doc comment
 117 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 118 | ERROR   | [x] Opening brace should be on the same line as the declaration
 119 | WARNING | [ ] Unused variable $age.
 119 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 120 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 121 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 122 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 123 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 124 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 126 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 126 | ERROR   | [x] Missing function doc comment
 127 | ERROR   | [x] Opening brace should be on the same line as the declaration
 128 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 129 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 130 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 131 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 132 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 134 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 134 | ERROR   | [x] Missing function doc comment
 135 | ERROR   | [x] Opening brace should be on the same line as the declaration
 136 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 137 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 138 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 139 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 140 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 142 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 142 | ERROR   | [ ] Missing short description in doc comment
 145 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 145 | ERROR   | [ ] Public method name "FeatureContext::thereAreArticleNodesWithAHugeNumberOfTaxonomyTermsEach" is not
     |         |     in lowerCamel format
 146 | ERROR   | [x] Opening brace should be on the same line as the declaration
 147 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 148 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 149 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 150 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 151 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 152 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 154 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 154 | ERROR   | [ ] Missing short description in doc comment
 157 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 157 | ERROR   | [ ] Public method name "FeatureContext::whenIGenerateAnArticleWithLotsOfTerms" is not in lowerCamel
     |         |     format
 158 | ERROR   | [x] Opening brace should be on the same line as the declaration
 159 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 160 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 161 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 162 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 163 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 164 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 165 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 167 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 170 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 171 | ERROR   | [x] Opening brace should be on the same line as the declaration
 172 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 173 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 174 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 174 | ERROR   | [x] Short array syntax must be used to define arrays
 175 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 176 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 177 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
 178 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 179 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 180 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 180 | ERROR   | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 152 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...endassignment\web\modules\contrib\pantheon_advanced_page_cache\tests\behat\helper_classes\tests\AgeTrackerTest.php
------------------------------------------------------------------------------------------------------------------------
FOUND 83 ERRORS AND 4 WARNINGS AFFECTING 67 LINES
------------------------------------------------------------------------------------------------------------------------
   1 | ERROR   | [x] The PHP open tag must be followed by exactly one blank line
   1 | ERROR   | [x] End of line character is invalid; expected "\n" but found "\r\n"
  13 | ERROR   | [x] Opening brace should be on the same line as the declaration
  14 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  14 | ERROR   | [ ] Parameter $headers_set is not described in comment
  15 | ERROR   | [x] Doc comment short description must end with a full stop
  18 | ERROR   | [x] Parameter comment must end with a full stop
  19 | ERROR   | [ ] Doc comment for parameter $headers does not match actual variable name $headers_set
  20 | ERROR   | [x] Parameter comment must end with a full stop
  25 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  25 | ERROR   | [x] Expected 1 blank line before function; 0 found
  26 | ERROR   | [x] Opening brace should be on the same line as the declaration
  27 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  27 | ERROR   | [ ] Variable "AgeTracker" starts with a capital letter, but only $lowerCamelCase or $snake_case is
     |         |     allowed
  28 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  29 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  29 | ERROR   | [ ] Variable "AgeTracker" starts with a capital letter, but only $lowerCamelCase or $snake_case is
     |         |     allowed
  30 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  31 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  31 | ERROR   | [ ] Variable "AgeTracker" starts with a capital letter, but only $lowerCamelCase or $snake_case is
     |         |     allowed
  32 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  33 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  35 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  41 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  42 | ERROR   | [x] Opening brace should be on the same line as the declaration
  43 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  43 | ERROR   | [x] Short array syntax must be used to define arrays
  44 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  45 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  46 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  48 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  49 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  50 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  53 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  54 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  56 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  56 | ERROR   | [x] Missing function doc comment
  57 | ERROR   | [x] Opening brace should be on the same line as the declaration
  58 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  58 | ERROR   | [x] Short array syntax must be used to define arrays
  59 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  60 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  61 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  62 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  62 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "FALSE" but found "false"
  64 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  65 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  66 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  67 | ERROR   | [x] Array indentation error, expected 10 spaces but found 12
  67 | ERROR   | [x] TRUE, FALSE and NULL must be uppercase; expected "TRUE" but found "true"
  70 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  71 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  73 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  73 | ERROR   | [ ] Parameter $headers_set is not described in comment
  73 | ERROR   | [ ] Parameter $expected_cache_clear is not described in comment
  74 | ERROR   | [x] Doc comment short description must end with a full stop
  77 | ERROR   | [x] Parameter comment must end with a full stop
  78 | ERROR   | [ ] Doc comment for parameter $headers does not match actual variable name $expected_cache_clear
  79 | ERROR   | [x] Parameter comment must end with a full stop
  85 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  86 | ERROR   | [x] Opening brace should be on the same line as the declaration
  87 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  87 | ERROR   | [ ] Variable "AgeTracker" starts with a capital letter, but only $lowerCamelCase or $snake_case is
     |         |     allowed
  89 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  90 | ERROR   | [x] Line indented incorrectly; expected 6 spaces, found 12
  90 | ERROR   | [ ] Variable "AgeTracker" starts with a capital letter, but only $lowerCamelCase or $snake_case is
     |         |     allowed
  91 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  92 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  92 | ERROR   | [ ] Variable "AgeTracker" starts with a capital letter, but only $lowerCamelCase or $snake_case is
     |         |     allowed
  93 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
  93 | ERROR   | [ ] Variable "AgeTracker" starts with a capital letter, but only $lowerCamelCase or $snake_case is
     |         |     allowed
  94 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  96 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
  96 | ERROR   | [x] Missing function doc comment
  97 | ERROR   | [x] Opening brace should be on the same line as the declaration
  98 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 102 | WARNING | [x] A comma should follow the last multiline array item. Found: 'S1502402462.916272,VS0,VE1'
 107 | WARNING | [x] A comma should follow the last multiline array item. Found: 'S1502402469.916272,VS0,VE1'
 110 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 112 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 112 | ERROR   | [x] Missing function doc comment
 113 | ERROR   | [x] Opening brace should be on the same line as the declaration
 114 | ERROR   | [x] Line indented incorrectly; expected 4 spaces, found 8
 118 | WARNING | [x] A comma should follow the last multiline array item. Found: 'S1502402462.916272,VS0,VE1'
 123 | WARNING | [x] A comma should follow the last multiline array item. Found: 'S1502402469.916272,VS0,VE1'
 126 | ERROR   | [x] Line indented incorrectly; expected 2 spaces, found 4
 126 | ERROR   | [x] Expected 1 blank line after function; 0 found
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 75 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------


FILE: ...ced_page_cache\tests\modules\pantheon_advanced_page_cache_test\src\EventSubscriber\CacheableResponseSubscriber.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] End of line character is invalid; expected "\n" but found "\r\n"
------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------------

Time: 1.5 secs; Memory: 6MB

Steps to reproduce

1) Install and enable this module or Clone it from issue fork.

2) Run following command :

./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/pantheon_advanced_page_cache

Proposed resolution

Above error/warnings need to be fixed as per the coding standard.

📌 Task
Status

Needs review

Version

2.1

Component

Code

Created by

🇮🇳India sidharth_soman Bangalore

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

Production build 0.69.0 2024