- Issue created by @d-xpert
- First commit to issue fork.
- ๐ฎ๐ณIndia Neha-Verma
Neha-Verma โ changed the visibility of the branch 3424238-Fix-phpcs to hidden.
- ๐ฎ๐ณIndia Neha-Verma
Fixed most of the phpcs error reported by Gitlab CI.
Issues remaining:
FILE: ...es/custom/packthub_ebook_integration-3424238/src/Plugin/ProductsAssets.php -------------------------------------------------------------------------------- FOUND 2 ERRORS AFFECTING 2 LINES -------------------------------------------------------------------------------- 77 | ERROR | [x] Space found after square bracket; expected "[CURLOPT_URL" but | | found "[ | | CURLOPT_URL" | | (Squiz.Arrays.ArrayBracketSpacing.SpaceAfterBracket) 86 | ERROR | [x] Space found before square bracket; expected ",]" but found ", | | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: .../modules/custom/packthub_ebook_integration-3424238/src/Plugin/Products.php -------------------------------------------------------------------------------- FOUND 3 ERRORS AFFECTING 3 LINES -------------------------------------------------------------------------------- 158 | ERROR | [x] Space found after square bracket; expected "[CURLOPT_URL" | | but found "[ | | CURLOPT_URL" | | (Squiz.Arrays.ArrayBracketSpacing.SpaceAfterBracket) 167 | ERROR | [x] Space found before square bracket; expected ",]" but found | | ", | | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket) 271 | ERROR | [ ] Public method name "Products::setProductID" is not in | | lowerCamel format | | (Drupal.NamingConventions.ValidFunctionName.ScopeNotCamelCaps) -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ustom/packthub_ebook_integration-3424238/src/Form/EbookContentTypeForm.php -------------------------------------------------------------------------------- FOUND 6 ERRORS AFFECTING 6 LINES -------------------------------------------------------------------------------- 61 | ERROR | [x] Space found after square bracket; expected "['#type'" but | | found "[ | | '#type'" | | (Squiz.Arrays.ArrayBracketSpacing.SpaceAfterBracket) 71 | ERROR | [x] Space found before square bracket; expected ",]" but found ", | | ]" | | (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket) 72 | ERROR | [x] Space found before square bracket; expected ",]" but found ", | | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket) 77 | ERROR | [x] Space found before square bracket; expected ",]" but found ", | | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket) 85 | ERROR | [x] Space found after square bracket; expected "['#type'" but | | found "[ | | '#type'" | | (Squiz.Arrays.ArrayBracketSpacing.SpaceAfterBracket) 88 | ERROR | [x] Space found before square bracket; expected ",]" but found ", | | ]" (Squiz.Arrays.ArrayBracketSpacing.SpaceBeforeBracket)
- ๐ฎ๐ณIndia Jasjeet Kaur Brar
Jasjeet Kaur Brar โ made their first commit to this issueโs fork.
- ๐ฎ๐ณIndia Raveen Kumar
All the Phpcs error reported by Gitlab CI are fixed!!
- Status changed to RTBC
10 months ago 12:10pm 5 March 2024 - Status changed to Fixed
10 months ago 1:55pm 15 March 2024