🇮🇳India @Jasjeet Kaur Brar

@mortona2k, I have installed the module with version 2.0 And the module was installed successfully as you can see in my attached screenshot link here: https://prnt.sc/9sLuVEV8B163
** I am using Drupal Version 10.2. I have installed module using composer . Can you please let me know if it is a version specific issue with Drupal ? And Thank You.

Jasjeet Kaur Brar → changed the visibility of the branch 3432125-add-.gitlab-ci.yml to hidden.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

phpcs has green tick across board

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@Kristen Pol, Finally phpcs has green tick across board. Please review. And Thank you.

@apatel, still has warning for phpcs

@Kristen Pol, +1 , phpstan has now green tick across board.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@Ravi, Can you please review now.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Can u provide more details?

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@nicxvan , Please review now. And Thank You!!

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

I have added a generic description for the module. Please review and test now. Thank You!!!

And Infact the hook_help page is empty as well...
please have a look.. https://prnt.sc/ZM3EACvHVYhQ

Please Review....

Thanks! Aman, It was almost there, I made some changes, that i just pushed. Most important change is forgotten Drupal\Core\Routing\RouteMatchInterface inclusion, without it php error is thrown and help page is broken.

Please review the MR! now.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Please review now.

The patch has applied smoothly. But when i visit help page, The help page is making the website down.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@sunil , Yes, it is required to modify the package name to Other if it doesn't fall in any category. The Module has straightForward fix.
Marking this ticket as RTBC!
Can be merged. Thank you.

If it's fine you can mark this ticket as RTBC

Please Review

Pls Review.

Jasjeet Kaur Brar → changed the visibility of the branch 3428018-addressing_help_text to hidden.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → changed the visibility of the branch 3427952-cancel-dates-in to hidden.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@Yes, if module doesn't fall into any specific category, you can designate it as 'Package: Other.
The patch has straighForward fix. Can be imported.
Thank yuhh!! Marking ticket to RTBC!

@Ravi, Please review. And Thank Yuh!!

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

I am getting issue with importing the patch.

I have reviewed the patch and changes as per patch removes all the cs errors.
CAn be merged. Thank Yuh!!

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

phpcs has green tick across board.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@jnicola, yes there was a typo in response message and your's patch seems to be fixing the issue. The patch can be imported.
Created a MR! as per your patch for maintainer's ease.Marking ticket as RTBC!
Thank You.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Please Review.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Green Tick for phpcs and phpstan across board

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@Aman, Patch is fine but the phpunit tests are failing...

Thanks @ Greg I was looking at the issue for t() string translations. That i guess you have mentioned somewhere in another ticket. But mistakenly i have created an branch there (in the wrong ticket). And when i came here, i see that one is resolved. (t())

Green Tick for phpcs across board

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → changed the visibility of the branch 3427299-t()_should_be_avoided to hidden.

just a test

Jasjeet Kaur Brar → changed the visibility of the branch t_calls_should_be_avoided to hidden.

Jasjeet Kaur Brar → created an issue.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@akhil, MR as some merge conflicts.

I have applied the patch and confirms that the patch has been applied successfully. Created an MR! for maintainers ease.
Can be merged. Thank You.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@sershch, Yes it is working as desired. Thank You....

Hiee @Andrii, composer.json file is as per the Drupal's recommended sections.

For PHPCS, there is a separate ticket, will be addressing cs issues in that ticket.
thank You

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Hiiee @Andrii, Your composer.json file looks good, but there are a couple of optional additions you might consider.
"require": {
"drupal/core": "^9"
}
Drupal 8/9 modules generally follow PSR-4 autoloading standards. You can configure autoload settings in your composer.json file. For example:

"autoload": {
"psr-4": {
"Drupal\\taxonomy_protect\\": "src/"
}
}

But still good to go

Hiiee Andrii, These issues are already been taken care of in another ticket by me which was added by you for GitLab CI.
Can you please confirm from that ticket? And Thanks.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

I am using Drupal 10.2 and php8.1 and it is working as desired.

@Tanuja I think its a version-specific issue. I am not able to reproduce it. Please see - https://prnt.sc/FLjCXKAl0Cj4

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.