\Drupal calls should be avoided in classes, use dependency injection instead

Issue created by @chaitanyadessai
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.2 & pgsql-14.1
last update 10 months ago
6 pass, 2 fail
Comment 10 months ago →
🇮🇳India chaitanyadessai Goa
Please review.
Status changed to Needs review 10 months ago7:40am 6 March 2024
First commit to issue fork.
Merge request !11#3425956 - Remove Drupal direct global functions calls. → (Open) created by rishabjasrotia
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
6 pass, 2 fail
Pipeline finished with Failed
10 months ago
Total: 149s
#112541
Comment 10 months ago →
System Message
The last submitted patch, 2: 3425956-2.patch, failed testing. View results →
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 10 months ago
7 pass
Status changed to Needs review 10 months ago9:20am 6 March 2024
Comment 10 months ago →
rishabjasrotia
Hello @chaitanyadessai,
Thank you for the patch.

We should use the Drupal RouteObjectInterface as per Drupal 10 instead of \Symfony\Cmf\Component\Routing\RouteObjectInterface.
I have updated the code.
Pipeline finished with Success
10 months ago
Total: 211s
#112619
Open in Jenkins → Open on Drupal.org →
Core: 10.2.1 + Environment: PHP 8.2 & pgsql-14.1
last update 10 months ago
Patch Failed to Apply
Comment 10 months ago →
rishabjasrotia
Comment 9 months ago →
🇮🇳India Jasjeet Kaur Brar
Jasjeet Kaur Brar → made their first commit to this issue’s fork.
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
7 pass
Open in Jenkins → Open on Drupal.org →
Core: 10.2.x + Environment: PHP 8.2 & MySQL 8
last update 9 months ago
7 pass
Comment 9 months ago →
🇮🇳India Jasjeet Kaur Brar
Green Tick for phpcs across board
Comment 9 months ago →
rishabjasrotia
Thank you @jasjeet-kaur-brar

\Drupal calls should be avoided in classes, use dependency injection instead

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!11\Drupal calls should be avoided in classes, use dependency injection instead
Open

Comments & Activities

\Drupal calls should be avoided in classes, use dependency injection instead

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!11\Drupal calls should be avoided in classes, use dependency injection insteadOpen

Comments & Activities

!11\Drupal calls should be avoided in classes, use dependency injection instead
Open