Implement hook_help()

Created MR for the issue.
Please review.
Thanks

After applying the MR6, getting these error:

error: patch failed: modules/rest_views_geo/rest_views_geo.info.yml:5
error: modules/rest_views_geo/rest_views_geo.info.yml: patch does not apply
error: patch failed: modules/rest_views_revisions/rest_views_revisions.info.yml:5
error: modules/rest_views_revisions/rest_views_revisions.info.yml: patch does not apply
error: patch failed: modules/rest_views_search_api/rest_views_search_api.info.yml:5
error: modules/rest_views_search_api/rest_views_search_api.info.yml: patch does not apply
error: patch failed: rest_views.info.yml:1
error: rest_views.info.yml: patch does not apply
error: patch failed: modules/rest_views_geo/rest_views_geo.info.yml:1
error: modules/rest_views_geo/rest_views_geo.info.yml: patch does not apply
error: patch failed: modules/rest_views_revisions/rest_views_revisions.info.yml:1
error: modules/rest_views_revisions/rest_views_revisions.info.yml: patch does not apply
error: patch failed: modules/rest_views_search_api/rest_views_search_api.info.yml:1
error: modules/rest_views_search_api/rest_views_search_api.info.yml: patch does not apply
6.patch:1064: new blank line at EOF.
+

I am no longer supporting the 2.x branch, I'll update the merge request with 3.0.x and take a look.

This MR seems to be just copying the hook_help from eck_bundle_permissions

Please update it to be specific to rest_views including the help text.

updated the hook_help with help text.
please review.

Thanks, do you have any examples of other modules doing their help text like this?

I think it's clever, but I'm not sure this is the standard way Drupal contrib provides help text.

The only module I see that does something similar is this one: https://www.drupal.org/project/module_instructions → but it uses check_markup for security and renders a markup field. Also critically that module outputs html in it's own hook help.

Let me ask for another review before I ask for any changes, but if there are other modules doing this please provide those examples.

After looking at this further, while I appreciate the elegance of not maintaining content in two places, I think it's more secure to just follow the convention and write hook help manually with some html. I don't think we need the full readme, just some pointers that you think would help a new user.

Jasjeet Kaur Brar → made their first commit to this issue’s fork.

@nicxvan , Please review now. And Thank You!!

Thank you for your effort to contribute to Drupal. These types of changes may fall under the credit abuse policy: https://www.drupal.org/drupalorg/docs/marketplace/abuse-of-the-contribut... →
If I merge this change I will not be be providing credit for this issue. Creating issues en masse is discouraged for low-effort changes that do not provide a bugfix, add a feature or otherwise provide value to the project the change is proposed to.

For guidelines on etiquette for Drupal contributions:
https://www.youtube.com/watch?v=lu7ND0JT-8A
https://docs.google.com/presentation/d/1jvU0-9Fd4p1Bla67x9rGALyE7anmzjhQ...
https://www.youtube.com/watch?v=0K0uIgKaVNQ
https://www.drupal.org/docs/develop/issues/issue-procedures-and-etiquett... →
https://www.drupal.org/drupalorg/docs/marketplace/abuse-of-the-contribut... →

This issue may have been reported to the site moderation queue for review.

If this is your first time seeing this feel free to comment, I would be happy to provide more resources for your contributions to be meaningful and receive credit.

After further consideration I believe I should provide credit for a few users on this ticket as their contribution came after a direct comment by me about the patch.

In general these types of tickets are a fine line whether module maintainers find them helpful.
Since I requested changes I will provide credit to the users that responded to my requests.

Automatically closed - issue fixed for 2 weeks with no activity.