- Issue created by @Kristen Pol
- First commit to issue fork.
- Assigned to apatel0325
- Issue was unassigned.
- 🇮🇳India Jasjeet Kaur Brar
@Kristen Pol, Finally phpcs has green tick across board. Please review. And Thank you.
- Status changed to Needs review
3 months ago 12:46pm 18 March 2024 - Status changed to Needs work
1 day ago 11:58am 27 June 2024 - 🇮🇳India dev16.addweb
Hello,
I have tested the MR !10 and I found some errors and warnings after applying the patch.
FILE: /home/addweb/patches/consultation-3423317/src/Plugin/WebformHandler/ConsultationNotify.php --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- 54 | ERROR | The $_POST super global must not be accessed directly; inject the request_stack service and use $stack->getCurrentRequest()->request->get('form_id') instead --------------------------------------------------------------------------------------------------------------------------------------------------------------------------- FILE: /home/addweb/patches/consultation-3423317/src/Plugin/views/filter/ConsultationState.php --------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------- 21 | WARNING | Unused variable $operators. --------------------------------------------------------------------------------------------- FILE: /home/addweb/patches/consultation-3423317/src/ConsultationNodeHelper.php ------------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------------ 134 | WARNING | Unused variable $end. ------------------------------------------------------------------------------ FILE: /home/addweb/patches/consultation-3423317/src/ConsultationUninstallValidator.php --------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE --------------------------------------------------------------------------------------------- 28 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead --------------------------------------------------------------------------------------------- FILE: /home/addweb/patches/consultation-3423317/consultation.module ------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES ------------------------------------------------------------------------------------- 17 | WARNING | Global constants should not be used, move it to a class or interface 21 | WARNING | Global constants should not be used, move it to a class or interface 25 | WARNING | Global constants should not be used, move it to a class or interface 28 | WARNING | Global constants should not be used, move it to a class or interface ------------------------------------------------------------------------------------- Time: 426ms; Memory: 12MB