- Issue created by @Greg Boggs
- ๐ฎ๐ณIndia Jasjeet Kaur Brar
Jasjeet Kaur Brar โ made their first commit to this issueโs fork.
- last update
8 months ago 6 pass - last update
8 months ago 6 pass - last update
8 months ago 6 pass - last update
8 months ago 6 pass -
Greg Boggs โ
committed 4d19269c on 2.x authored by
Jasjeet Kaur Brar โ
Issue #3421456: Fix tests
-
Greg Boggs โ
committed 4d19269c on 2.x authored by
Jasjeet Kaur Brar โ
- Status changed to Fixed
8 months ago 6:35am 13 March 2024 - ๐ฎ๐ณIndia Jasjeet Kaur Brar
Green Tick for phpcs and phpstan across board
Automatically closed - issue fixed for 2 weeks with no activity.
- leymannx Berlin
This was an unfortunate MR. While Stan and CS might have been green, Unit became red. This MR introduced the bug mentioned in ๐ Broken findMatchingRedirect() call Fixed and ๐ "Paths to be excluded while generating segments" option says regex is supported, but it is not Needs work . Also not the best move switching from
static
toself
here, blindly listening to a Stan warning, while you see this pattern nowhere else across any core or contrib code.The fix now happens in ๐ Broken findMatchingRedirect() call Fixed .
- leymannx Berlin
Here we can see clearly what happens if we blindly apply coding standard fixes for credits without understanding the code.