Hey #9
I dont think $temporary_scheme will always be NULL, thats why declaring $temporary_scheme_name with NULL value suits incase this $temporary_scheme is NULL in that way its ensures that $temporary_scheme_name always have expected value. but if $temporary_scheme is not NULL which mean here $temporary_scheme_name = key($stream_wrapper_manager->getWrappers($temporary_scheme->getType()));
we will have right value.
In short am just trying to safeguard this line $temporary_scheme_name = key($stream_wrapper_manager->getWrappers($temporary_scheme->getType())); in such away that only if $temporary_scheme is not NULL then line can be executed. at same time making sure that $temporary_scheme_name has other expected value NULL if line didnt execute.
Sorry for later reply. Thanks
I have created this patch please review it, I have simple checked if $temporary_scheme is empty if yes am keeping this $temporary_scheme_name as null since on line $temporary_scheme_name = key($stream_wrapper_manager->getWrappers($temporary_scheme->getType())); key returns null if key was not found.
Fixed in default main branch
chancenyasulu → made their first commit to this issue’s fork.
Updates will be in next release
reviewing
am closing this issue as it is already solved within other issues
Thanks you Neha-Verma for your review am closing it now.
Thanks D-XPERT
Made changes and pushed
chancenyasulu → created an issue.
made changes related to this issue
chancenyasulu → created an issue.
Made changes solving this issue
chancenyasulu → created an issue.
GitLab CI is set up properly which has made alot of error and warning flags on the project which we are required to cross check and rise there proper issues to be fixed
Thank you
Readme doc added.
I have reviewed the fixed you have made @raveen unfortunately issue still remains I will suggest to avoid people from accessing /admin/config/packt/content-type-form form if we dont have token for Packthub set for module to use in that case lets redirect to /admin/config/packt/api-key for them to set the the API token which is required.
Made required changes for this issue
All new changes will be available in new release.
Removed route
Reviewed and completed fix.
am closing this issues we can focus on issue https://www.drupal.org/project/active_campaign_api_integration/issues/34... 🐛 Enforce tokens "key" and "url" availability to module Needs review solving it will solve our problem in this issue
I have reviewed and merged all of this issue thanks you all
chancenyasulu → created an issue.
Thank you all.
merged raveen pr
Hey Xpert it will good to include packthub link https://api.packt.com/api-docs#section/Overview for those who wants to get API token for packthub
in README.
Hello Abdulaziz, I have look and tested the code from
composer require 'drupal/email_tfa:2.0.x-dev@dev'
and
composer require 'drupal/email_tfa:^2.0@alpha'
But both side gives me problem when i have enabled the module and configure it accordingly
Clearing cache and then logout to login again unfortunately i cant login site just keeps on loading Note: this happens only when STMP module
https://www.drupal.org/project/smtp →
is not configured properly
Please enforce this requirement in email TFA module
Other Errors found:
this video screen-capture (3).mp4 (15.16 MB) shows for composer require 'drupal/email_tfa:^2.0@alpha'
and
this video screen-capture (4).mp4 (9.58 MB) shows for composer require 'drupal/email_tfa:2.0.x-dev@dev'
You will notice that in both we have these errors please check images.
Good News:
With properly configuration of stmp module email TFA works great now. check Screenshot from 2024-02-02 16-15-55.png (201.93 KB)
Thank you.
ok will do
chancenyasulu → created an issue.
chancenyasulu → created an issue.
latest version has been released with all pending issues solved.
All issues solved in latest version
automation testing works fine.
private ?\Symfony\Component\HttpFoundation\Request $request;
/**
* @var \Drupal\Core\Extension\ModuleHandlerInterface
*/
private ModuleHandlerInterface $moduleHandler;
Module needs these property in web/modules/contrib/email_tfa/src/EventSubscriber/EmailTfaSubscriber.php
I applied the patch #7 but am still getting this issues.
chancenyasulu → created an issue.
chancenyasulu → created an issue.
chancenyasulu → created an issue.
Ok
Hey this one is fixed also please close it thank you.
Hey its fixed please close this one
chancenyasulu → created an issue.
chancenyasulu → created an issue. See original summary → .
Oh ya that`s great now
Please check the attached images
After running auto fix
./vendor/bin/phpcbf --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,ym web/modules/contrib/critique_and_review/
PHPCBF RESULT SUMMARY
----------------------------------------------------------------------------------------------------------------------------------
FILE FIXED REMAINING
----------------------------------------------------------------------------------------------------------------------------------
/opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/src/Form/TemplateCritiqueAndReviewForm.php 130 11
/opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/src/Form/CritiqueAndReviewSettingsForm.php 100 1
/opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/src/Plugin/Block/CritiqueAndReviewBlock.php 28 1
/opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/RADME.md 1 4
/opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/critique_and_review.module 101 21
/opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/critique_and_review.install 17 1
----------------------------------------------------------------------------------------------------------------------------------
A TOTAL OF 377 ERRORS WERE FIXED IN 6 FILES
----------------------------------------------------------------------------------------------------------------------------------
Time: 291ms; Memory: 12MB
Remaining errors
FILE: /opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/src/Form/TemplateCritiqueAndReviewForm.php
---------------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AND 3 WARNINGS AFFECTING 10 LINES
---------------------------------------------------------------------------------------------------------------------
14 | ERROR | Missing member variable doc comment
15 | ERROR | Missing member variable doc comment
16 | ERROR | Missing member variable doc comment
17 | ERROR | Missing member variable doc comment
45 | WARNING | Line exceeds 80 characters; contains 90 characters
49 | WARNING | Line exceeds 80 characters; contains 84 characters
59 | WARNING | Line exceeds 80 characters; contains 85 characters
112 | ERROR | Doc comment is empty
115 | ERROR | Public method name "TemplateCritiqueAndReviewForm::print_form_item" is not in lowerCamel format
252 | ERROR | Doc comment short description must end with a full stop
252 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
---------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/src/Form/CritiqueAndReviewSettingsForm.php
------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
17 | ERROR | Public method name "CritiqueAndReviewSettingsForm::getFormID" is not in lowerCamel format
------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/src/Plugin/Block/CritiqueAndReviewBlock.php
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
35 | ERROR | The array declaration extends to column 121 (the limit is 120). The array content should be split up over multiple lines
---------------------------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/RADME.md
--------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
--------------------------------------------------------------------------------
5 | WARNING | Line exceeds 80 characters; contains 99 characters
15 | WARNING | Line exceeds 80 characters; contains 81 characters
30 | WARNING | Line exceeds 80 characters; contains 84 characters
31 | WARNING | Line exceeds 80 characters; contains 86 characters
--------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/critique_and_review.module
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 16 ERRORS AND 5 WARNINGS AFFECTING 15 LINES
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
14 | WARNING | Format should be "* Implements hook_foo().", "* Implements hook_foo_BAR_ID_bar() for xyz_bar().",, "* Implements hook_foo_BAR_ID_bar() for xyz-bar.html.twig.", "* Implements
| | hook_foo_BAR_ID_bar() for xyz-bar.tpl.php.", or "* Implements hook_foo_BAR_ID_bar() for block templates."
18 | WARNING | Line exceeds 80 characters; contains 88 characters
65 | WARNING | Line exceeds 80 characters; contains 100 characters
73 | ERROR | Doc comment is empty
76 | ERROR | Invalid function name, expected get_reviews but found getReviews
76 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "getReviews" but expected "critique_and_review_getReviews"
83 | ERROR | Missing parameter comment
85 | ERROR | Description for the @return value is missing
87 | ERROR | Invalid function name, expected current_user_is_node_creator but found currentUserIsNodeCreator
87 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "currentUserIsNodeCreator" but expected "critique_and_review_currentUserIsNodeCreator"
102 | ERROR | Invalid function name, expected get_reviwers_for_node but found getReviwersForNode
102 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "getReviwersForNode" but expected "critique_and_review_getReviwersForNode"
112 | ERROR | Doc comment is empty
115 | ERROR | Invalid function name, expected get_user_reviews but found getUserReviews
115 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "getUserReviews" but expected "critique_and_review_getUserReviews"
126 | ERROR | Doc comment is empty
129 | ERROR | Invalid function name, expected getuser_name but found getuserName
129 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "getuserName" but expected "critique_and_review_getuserName"
146 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
146 | WARNING | Avoid backslash escaping in translatable strings when possible, use "" quotes instead
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /opt/lampp/htdocs/develop/web/modules/contrib/critique_and_review/critique_and_review.install
---------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------
8 | ERROR | Doc comment is empty
---------------------------------------------------------------------------------------------------
Time: 90ms; Memory: 10MB
Command used: ./vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,ym web/modules/contrib/critique_and_review/
Great work hook implemented fine.
chancenyasulu → created an issue.
Hey i have used same command ./vendor/bin/phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,ym web/modules/contrib/active_campaign_api_integration/ but am only getting
FILE: /opt/lampp/htdocs/develop/web/modules/contrib/active_campaign_api_integration/README.md
---------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------
37 | WARNING | Line exceeds 80 characters; contains 99 characters
39 | WARNING | Line exceeds 80 characters; contains 97 characters
---------------------------------------------------------------------------------------------
Time: 243ms; Memory: 12MB
These warnings aren't significant and can be disregarded. They appear because when you install a module in the 'contrib' directory, certain attributes are always present. While conducting a PHPCS check, it's advisable to ignore these warnings in the '.info.yml' file, unless they signify a different issue.
description is added and help hook implemented great work.
Hey @vivekp27 I have reviewed this mr rest are fine except in this file web/modules/contrib/views_sort_length/src/Plugin/views/sort/Length.php on method public function query()
inheritdoc is inheriting not standardized comment block which is still give errors so you can override this by following this
/**
* This is a description with capital T and period at an end.
*
* {@inheritdoc }
*/
Thank you.
Ok i will do.
Ok review it now