Fix the issues reported by phpcs

Created an MR to fix the issues reported by phpcs.

Please review.
Thank You.

The patch is resolving all the above-mentioned issues. Moving to RTBC.

This was clearly not tested, nor reviewed. Removing issue credits as well. Also make sure to use the correct branch.

Branch was actually correct, sorry for that 🙃

Hi, I patched (#8) the 2.0.x-dev version of this module (on a D9 site) and ran the following phpcs command on it..

phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/status_dashboard

I got the following output back..

FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/status_dashboard.module
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 47 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_dashboard_email_reminder_notification_cron" but expected
    |       | "status_dashboard__dashboard_email_reminder_notification_cron"
 82 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_dashboard_module_send_notification_mail" but expected
    |       | "status_dashboard__dashboard_module_send_notification_mail"
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------


FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/status_dashboard.install
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
 144 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------------------------------------------


FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/src/ClientSiteInterface.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
 61 | ERROR | Missing parameter type
----------------------------------------------------------------------------------------------------------


FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/README.md
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------
 61 | WARNING | Line exceeds 80 characters; contains 83 characters
 67 | WARNING | Line exceeds 80 characters; contains 92 characters
----------------------------------------------------------------------------------------


FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/PATCHES.txt
------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------
 1 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
 5 | ERROR   | [x] Expected 1 newline at end of file; 3 found
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------

Time: 156ms; Memory: 10MB

The last patch changes just two files, while the report shows errors/warnings for eight files.
Also, since there is already a MR, it should be better to keep using that MR, instead of submitting patches or creating new MRs.

Hi again, back to review the latest version of MR!6.

I ran ..

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/status_dashboard

and got nothing back.

+1 for RTBTC from me.

None of the remarks on the merge request are solved. This MR will break the module...

Removing credits once again.

For the mixed datatype i'm not sure what type status_errors variable is. Please review the MR.

There are still private functions being made public.

I think I corrected what needed to be corrected.

Hi @apaderno,

Applied latest MR !16 version successfully, however it resulted to some issues.

status_dashboard git:(2.0.x) curl https://git.drupalcode.org/project/status_dashboard/-/merge_requests/6.diff | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  8558    0  8558    0     0  12264      0 --:--:-- --:--:-- --:--:-- 12367
patching file README.md
patching file src/ClientSiteInterface.php
patching file src/Collector.php
patching file src/Entity/ClientSite.php
patching file src/Form/DashboardForm.php
patching file status_dashboard.install
patching file status_dashboard.module
➜  status_dashboard git:(2.0.x) ✗ cd ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig status_dashboard

FILE: ...al-orgissue/web/modules/contrib/status_dashboard/src/Form/SettingsForm.php
--------------------------------------------------------------------------------
FOUND 4 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 31 | ERROR | [x] The first parameter of a multi-line function declaration must
    |       |     be on the line after the opening bracket
 32 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 30
 32 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
 32 | ERROR | [x] The closing parenthesis of a multi-line function declaration
    |       |     must be on a new line
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 604ms; Memory: 12MB

Kindly check

Thanks,
Jake

silvi.addweb → made their first commit to this issue’s fork.

Hi, I have fixed mention issue from #22. Please review

Added to new release, thank you.

Fix issue credits.

Actually nothing was merged or pushed, and the new release is identical to the last one.

Automatically closed - issue fixed for 2 weeks with no activity.