When going through this tutorial (using Rules module Version: 8.x-3.0-alpha8) I had unexpected test results. Looks like the text being tested for .. "There is no Reaction Rule yet." should be "There are no enabled reaction rules.".
thanks cameron! Works for me.
Hi, ok I have had a go at fixing this. My first MR so not 100% sure what I am doing. Followed guidance here → . Apologies if I made any errors.
Annoying that tests fail..
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
Array (
- 0 => 'test editorial_reviewer 1'
- 1 => 'test editorial_reviewer 2'
+ 0 => 'test editorial_reviewer 1 -'
+ 1 => 'test editorial_reviewer 2 -'
)
might try to look into why that is, and find a way to test before making a MR.
schillerm → made their first commit to this issue’s fork.
Hi, I have reviewed the latest version of this. Ran a case sensitive search in the module folder for "dopup" got 106 results. Looks like the module name is capitalized everywhere it should be. Hope that helps. +1 for RTBC
Hi again, back to review the latest version of MR!6.
I ran ..
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/status_dashboard
and got nothing back.
+1 for RTBTC from me.
Hi, I tested #4 patch against v1.1 (using same steps to reproduce error) and it works as described. Country names are now sorting correctly.
+1 for RTBC.
Hi, I tried to apply patch #4 to version 2.0.x-dev and got the error, "Could not apply patch!".
Took a look at the patch and saw that it seems to be trying to remove/update the line..
"drupal/core": "^8.9 || ^9 || ^10"
in the file /composer.json.
In version 2.0.x-dev this line does not have the ^8.9 || bit in it.
I guess this is why the patch does not apply? or am I patching against the wrong version?
Hi,
I have also tested !MR90 and it works fine (number of tags and groups showing).
RTBC + 1 from me.
thanks
Hi, I tested this patch on v 4.0.0 (D9 site) and it works as described. +1 for RTBC
Hi again, ok I was able to get this working by doing the following extra steps ..
* ran composer require 'drupal/git_info:^2.0' (install latest version with all dependencies)
* delete the git_info module folder (created by previous command)
Then run normal issue commands to clone the git_info module (git clone https://git.drupalcode.org/project/git_info.git) and checkout the MR branch. After that install git_info module (in GUI) and run tests.
Please let me know if you think I could have done this in a better way.
Testing : The Info block places on the page, with no errors as admin. The block is hidden when viewing the page as unauthenticated user.
Hi, I installed !MR9 on my local (D9 site) and got this error when trying to place the Info block.
Error: Class "eiriksm\GitInfo\GitInfo" not found in include() (line 14 of /app/web/modules/contrib/git_info/src/GitInfo.php)
Hi, I also got no phpsc errors back after applying patch #3. +1 for RTBC from me as well.
Hi, I ran phpcs against patch #4 and got back just dependency injection warnings ..
###############################################
👻️ ~/Documents/Sites/D9.5.0 phpcs --standard=Drupal,DrupalPractice --ignore=PATCHES.txt --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/tac_lite
FILE: /home/user/Documents/Sites/D9.5.0/web/modules/contrib/tac_lite/src/Form/SchemeForm.php
--------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------
98 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
--------------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D9.5.0/web/modules/contrib/tac_lite/src/Form/ConfigForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------
33 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
89 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
109 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D9.5.0/web/modules/contrib/tac_lite/src/Form/UserAccessForm.php
---------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 5 WARNINGS AFFECTING 5 LINES
---------------------------------------------------------------------------------------------------------------
40 | WARNING | Vocabulary::loadMultiple calls should be avoided in classes, use dependency injection instead
41 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
63 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
98 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
103 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
---------------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D9.5.0/web/modules/contrib/tac_lite/src/Cache/TacLiteGrantsCacheContext.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
78 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------
Time: 140ms; Memory: 10MB
######################################
If we ignore dependency injection warnings then this gets +1 for RTBC from me.
Hi, I also tried to reproduce the error and was unable to.
I created a custom link using the UI and there were no errors. Using version 3.4.2.
Hi cedewey, I tried applying the patch to 8.x-1.x-dev (D9 site) and I got the "Could not apply patch" error.
Hi Sahana, I reviewed MR !7 and the module name now shows as capitalized. +1 for RTBC
Hi, tested this and I have a capital letter! +1 for RTBC
Hi, I just tested MR !3 and it is working for me. + 1 for RTBC
Hi, I just reviewed MR !9 and spotted something in the README.md file ..
should that be emails and not s ?
Hi tyler, I tested out MR !28 and it fixes the problem. Default dates now showing.
Tested on D9.5.0 site (php 8.1).
+1 for RTBC from me.
Hello, I also tested the #2 patch on 4.0.0 and it works. I was able to output a json file, +1 for RTBC
Hi folks, I have tested MR !8 on a D9.5.0 site (PHP 8.1).
I ran ..
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig web/modules/contrib/multiple_selects
I got no phpcs errors back.
+1 for RTBC from me.
Hi Alina, I tested your patch and it worked.
I installed google_tag 2.0.x-dev and upgrade-status 4.0 modules on a Drupal 9.5.0 site.
Ran upgrade-status saw the default error as described.
Applied patch #2, cleared the cache, reran upgrade-status and error had gone.
+1 for RTBC.
Hi, I applied #3 patch to 1.x-dev version on a D10 site.
All PHPCS errors are gone except on the PATCHES.txt file.. see below..
#######################################
🐸 ~/Documents/Sites/D10 phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/s3fs_cors
FILE: /home/user/Documents/Sites/D10/web/modules/contrib/s3fs_cors/PATCHES.txt
------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------
1 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
5 | ERROR | [x] Expected 1 newline at end of file; 3 found
------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------
Time: 107ms; Memory: 10MB
###################################
RTBC +1 from me!
Hi there, I just checked out MR !1 and ran phpcs on it. I got this back ..
########################################
🐸 ~/Documents/Sites/D10 phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/themes/contrib/decorx/
FILE: /home/user/Documents/Sites/D10/web/themes/contrib/decorx/theme-settings.php
------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------
60 | WARNING | Translatable strings must not begin or end with white spaces, use placeholders with t() for variables
60 | ERROR | Concatenating translatable strings is not allowed, use placeholders instead and only one string literal
------------------------------------------------------------------------------------------------------------------------
Time: 65ms; Memory: 12MB
########################################
Hope that helps.
Hi, I also applied the patch to version 1.0.x-dev on a Drupal 10 site.
All PHPCS errors are resolved. RTBC +1 from me.
Hi, tested this #2 patch on local D9.5.11 site. The 'back to site' link works as expected. +1 for RTBC.
Hi there, I tried to test this on a D10 site but got the "Could not apply patch!" error.
Hi there, I tested the module (v 1.0.1) on a D10 site (v 10.1.4).
Was able to see the phpcs errors. Applied #2 patch and rerun phpcs
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/history_memory_calculator
got the following back..
FILE: /home/user/Documents/Sites/D10/web/modules/contrib/history_memory_calculator/src/Plugin/Block/CalculatorBlock.php
-----------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
-----------------------------------------------------------------------------------------------------------------------------
7 | WARNING | [x] Unused use statement
-----------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D10/web/modules/contrib/history_memory_calculator/history_memory_calculator.info.yml
---------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 3 WARNINGS AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------
1 | WARNING | Remove "project" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "datestamp" from the info file, it will be added by drupal.org packaging automatically
1 | WARNING | Remove "version" from the info file, it will be added by drupal.org packaging automatically
---------------------------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D10/web/modules/contrib/history_memory_calculator/PATCHES.txt
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
----------------------------------------------------------------------------------------------------
1 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
5 | ERROR | [x] Expected 1 newline at end of file; 3 found
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
Time: 64ms; Memory: 12MB
hope that helps..
Hi there, tested MR!8 on a D10 site (v 10.1.4).
The help link /admin/help/better_formats works and looks good, could maybe add bullet points to the list of features.
+1 for RTBC
Hi there, I tested field clone 8.x-1.x-dev on a D10 site (v 10.1.4) locally.
Tested adding and editing entity types Content and Content Block.
Works as expected, no errors seen.
+1 for RTBC
Hi, reviewed and tested a patched version of the 8.x-1.x-dev module on a local D9 site.
I ran phpcs --standard=Drupal --ignore=PATCHES.txt --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/content_editing_message
No errors or warnings returned, so moving to RTBC.
Hi, reviewed this on D9 site, all good, px gone.
Hi, I patched (#8) the 2.0.x-dev version of this module (on a D9 site) and ran the following phpcs command on it..
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/status_dashboard
I got the following output back..
FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/status_dashboard.module
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
47 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_dashboard_email_reminder_notification_cron" but expected
| | "status_dashboard__dashboard_email_reminder_notification_cron"
82 | ERROR | All functions defined in a module file must be prefixed with the module's name, found "_dashboard_module_send_notification_mail" but expected
| | "status_dashboard__dashboard_module_send_notification_mail"
---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/status_dashboard.install
-------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------
144 | ERROR | Doc comment short description must be on a single line, further text should be a separate paragraph
-------------------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/src/ClientSiteInterface.php
----------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------------
61 | ERROR | Missing parameter type
----------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/README.md
----------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES
----------------------------------------------------------------------------------------
61 | WARNING | Line exceeds 80 characters; contains 83 characters
67 | WARNING | Line exceeds 80 characters; contains 92 characters
----------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D9/web/modules/contrib/status_dashboard/PATCHES.txt
------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
------------------------------------------------------------------------------------------
1 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
5 | ERROR | [x] Expected 1 newline at end of file; 3 found
------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------
Time: 156ms; Memory: 10MBAlso checked this.. seems fine
Hi I agree with Akhil,
I just checked, ImageFieldTest.php in 8.x-2.9 and 8.x-2.x-dev has the following ..
foreach ($test_files as $test_file) {
if ($test_file->filename === 'image-test.jpg') {
$file_just_right = $file_system->realpath($test_file->uri);
}
elseif ($test_file->filename === 'image-2.jpg') {
$file_too_big = $file_system->realpath($test_file->uri);
}
}Hi, in reviewing this I ran the following phpsc command on MR!4..
phpcs --standard=Drupal --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml web/modules/contrib/prelinker
and got the following output..
FILE: /home/user/Documents/Sites/D10/web/modules/contrib/prelinker/prelinker.install
------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
------------------------------------------------------------------------------------------
3 | ERROR | Missing short description in doc comment
14 | ERROR | Missing short description in doc comment
------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D10/web/modules/contrib/prelinker/src/Form/PrelinkerSettings.php
-------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------
30 | ERROR | Private method name "PrelinkerSettings::_t" is not in lowerCamel format
31 | WARNING | Only string literals should be passed to t() where possible
-------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D10/web/modules/contrib/prelinker/src/Controller/PreloadListBuilder.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
48 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------
FILE: /home/user/Documents/Sites/D10/web/modules/contrib/prelinker/src/Controller/PreconnectListBuilder.php
-------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------
46 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
-------------------------------------------------------------------------------------------------------------------------------------
I also tested the module and it still works fine.
Hi, reviewed this MR and all looks good. +1 for RBTC.
Hi there, I like the Scheduler-logo-1.png logo. File size, file format and dimensions are all ok.
Hi, reviewed and tested MR!4. Ran a search for "blacklist" and "black" in the module, nothing found. Marking as RTBC.
Hi, reviewed and tested.. looks good to me!
Hi, reviewed and tested this MR and all seems fine. Checked new README.md against README.md template as recommended here → . Everything looks good.
Hi, reviewed the MR and noticed that the numbering was wrong in README.txt. So I fixed that and pushed the change up .
schillerm → made their first commit to this issue’s fork.
Hi, I have reviewed and tested the patch on D10 site using module version 8.x-1.x-dev. It looks great, the new description is much better.
Hi, I have reviewed the PR, it seems good to me. I am getting minor phpcs errors on the number of spaces before the new lines of code. There are many phpcs errors so perhaps that is another issue in itself.
Hi, I went in to review MR!1 and noticed more unused imports in the module ..so removed them and pushed up the changes. Not sure if the /tests folder matters but decided to include unused imports found in there. Hope that's ok..
schillerm → made their first commit to this issue’s fork.
Hi, reviewed and tested MR !3 on a D10 site (with module version 8.x-1.0), works fine.
Hi, made changes to update the READ.ME file so it hopefully meets the Drupal recommended template. First time doing a drupal contrib using git, following advice here → . Hope I am doing things the right way.
schillerm → made their first commit to this issue’s fork.
hi, reviewed applied and tested patch #9 (on D9 site with module version 1.0.x-dev). No PHPCS issues found.
Hi, reviewed and tested latest #5 patch (on D9 site with 1.0.x-dev module version), all PHPCS issues fixed.
Hi, tested patch #3 (module version 2.0.x-dev on D10 site) using phpcs and all previous issues are resolved.