Fix the issues reported by phpcs

Hi, Provided patch get applied but there are some remaining issue too.

used command:- ./vendor/bin/phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,info,txt,md,css,js,yml web/modules/custom/sdb
Remaining issue's are

FILE: /Users/ashutoshahirwal/Sites/lando/contribution/web/modules/custom/sdb/src/Plugin/Block/SimpleDateBlock.php
---------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
---------------------------------------------------------------------------------------------------------------------------------
8 | ERROR | [x] Use statements should be sorted alphabetically. The first wrong one is Drupal\Component\Datetime\DateTimePlus.
26 | ERROR | [x] Use null coalesce operator instead of ternary operator.
45 | ERROR | [x] Use null coalesce operator instead of ternary operator.
---------------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-----------------------------------------------------------

Providing Updated patch.

Hi,

I have reviewed patch #3, looks good to me. It applied cleanly:

Checking patch simple_date_block.info.yml...
Checking patch src/Plugin/Block/SimpleDateBlock.php...
Applied patch simple_date_block.info.yml cleanly.
Applied patch src/Plugin/Block/SimpleDateBlock.php cleanly.

And fixed all the phpcs issues as reported above.

So, for me, it is RTBC.

Thanks!

Hi, I also got no phpsc errors back after applying patch #3. +1 for RTBC from me as well.

Hi @everyone,

Also applied patch from comment #3, confirmed no issues remaining.

 sdb git:(1.0.x) curl https://www.drupal.org/files/issues/2023-10-17/phpcs-issue-fixes.patch | patch -p1
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  2885  100  2885    0     0   6507      0 --:--:-- --:--:-- --:--:--  6647
patching file simple_date_block.info.yml
patching file src/Plugin/Block/SimpleDateBlock.php
➜  sdb git:(1.0.x) ✗ ..
➜  contrib git:(main) ✗ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig sdb
➜  contrib git:(main) ✗

Will now move this to RTBC

Thanks,
Jake

Let's create a merge request, now that patches are no longer tested.