- Issue created by @dieterholvoet
- Merge request !3Issue #3387149: Title search should exclude the current node → (Closed) created by dieterholvoet
- Status changed to Needs review
about 1 year ago 9:26pm 13 September 2023 - Status changed to Needs work
about 1 year ago 11:04pm 8 October 2023 - 🇳🇴Norway matsbla
It looks good, but I think the patch need to be rerolled!
- Status changed to Needs review
about 1 year ago 7:31am 9 October 2023 - 🇬🇧United Kingdom schillerm
Hi, I just tested MR !3 and it is working for me. + 1 for RTBC
- Status changed to RTBC
about 1 year ago 4:40pm 9 October 2023 - Status changed to Needs work
about 1 year ago 5:19am 10 October 2023 - 🇳🇴Norway matsbla
I tested this, but I got a funny result. I tried to first create one node with title "Test node 1", then another node "Test node 2". After I try to edit the node "Test node 2", and then the current node ( "Test node 2") is still displayed in the list. However the count is correct (not counting current node), but the current node is still displayed in the list.
- 🇧🇪Belgium dieterholvoet Brussels
I can't seem to reproduce that issue. Did you test this using the last
dev-4.0.x
version with the latest state of the MR applied as patch? - First commit to issue fork.
- Status changed to Needs review
about 1 year ago 8:38am 23 October 2023 - 🇮🇳India mitthukumawat
@@DieterHolvoet
This issue fixes for all conditions now. Before last commit, when the option Contains any word from the title checked in search types config, the condition for ignoring current node not added.
After this, I tested all cases and it is working fine.
RTBC +1 - 🇧🇪Belgium dieterholvoet Brussels
I refactored the code a little bit and fixed an issue where no results were returned when adding a new node (
$entity->id()
would giveNULL
). - Status changed to Needs work
7 months ago 4:33pm 1 May 2024 - 🇳🇴Norway matsbla
I tested this manually, and I still see current node in results when adding the exact same title:
https://git.drupalcode.org/project/anti_duplicates/-/merge_requests/3.diff - 🇧🇪Belgium dieterholvoet Brussels
Are you sure it's the same node? I just tested using the latest
dev-4.0.x
and only the MR here applied as patch, the current node doesn't appear in the results. - 8d036170 committed on 4.0.x
Issue #3387149 by DieterHolvoet, mitthukumawat, matsbla, schillerm:...
- 8d036170 committed on 4.0.x
- Status changed to Fixed
7 months ago 1:03pm 4 May 2024 Automatically closed - issue fixed for 2 weeks with no activity.