🇳🇴Norway @matsbla

One follow-up issue 🐛 Remove layout regions from formatter list Active

matsbla → created an issue.

This fix the error, however sub field group are not created.

Perfect, thank you!

Oh, could you perhaps try open an issue and provide clear descriptions of what happens and perhaps step to reproduce?

For the updated patch I tested it, but when applying it the layout col-element now becomes draggable again.

Perfect, thank you!

Thank you for the report and patch!

When testing it seems like I'm not able to create any other field group types (When I click on "Save and continue" nothing happens). Perhaps we need to make sure the field is only mandatory for the layout field groups..

Thanks for the effort, it works better, but still if you would manage to drag a group inside the layout groups they will now still not be movable anymore. Perhaps we also need to check if it is a layout col-element.

Thank you for the feedback, can confirm the issue. Am attaching a screenshot as reference.

matsbla → created an issue.

Thanks for the link - is that the only change needed to upgrade?

But it would be good if you can make sure these patches are generated for all projects, it makes it very easy to quickly upgrade the modules :)

This module also didn't get any patch for D11 upgrades, is it possible to make the boot provide the patch?
https://www.drupal.org/project/field_group_layout →

matsbla → created an issue.

Please upgrade to 2.0.0-alpha1, this should be fixed now.

This should be fixed now in 2.0.0-alpha1

Please upgrade to 2.0.0-alpha1, this should be fixed now.

Please upgrade to 2.0.0-alpha1, this should be fixed now.

Please upgrade to 2.0.0-alpha1, this should be fixed now.

This looks like a great improvement!

Submodule not upgraded

  if ($node->getType() === 'person') {

    $label .= sprintf(' (%s)', $node->get('field_last_name')->value);

This seems like part of hard-coded custom code, perhaps should be removed from the patch?

Oh yes you are right, thanks!

I tested this now, and I get these errors:

Error: Call to a member function getType() on null in Drupal\anti_duplicates\Form\AntiDuplicatesFormAlter::duplicatesSearch() (line 35 of /var/lib/tugboat/stm/web/modules/contrib/anti_duplicates/src/Form/AntiDuplicatesFormAlter.php)

Warning: Undefined variable $currentNode in Drupal\anti_duplicates\Form\AntiDuplicatesFormAlter::duplicatesSearch() (line 35 of /var/lib/tugboat/stm/web/modules/contrib/anti_duplicates/src/Form/AntiDuplicatesFormAlter.php)

The problems is when the user only want to change the title, make changes without unfocusing the title field, and then doesn't understand why the submit button is disabled. This solution will solve one UI challenges by introducing a new one.

Instead of disabeling the button, could we make sure that if title is still unfocused, that we run the anti-duplicate check when user click submit, before we process the submit button action?

The error mentioned in #10 is still there. In addition when you click update the whole website encountered an unexpected error:

Error: Attempt to assign property "label" on null in field_group_field_overview_submit() (line 478 of modules/contrib/field_group/includes/field_ui.inc).

I will look over again, but please reroll the MR as 🐛 Title search should exclude the current node Fixed has been fixed now

Okay I tested and looked over again now, thanks!

Both MR 4 or MR 6 does not fix the error adressed in this issue.

Warning: Undefined property: stdClass::$group_name in Drupal\field_group_layout\Plugin\field_group\FieldGroupFormatter\LayoutFormatter->settingsForm() (line 73 of modules/contrib/field_group_layout/src/Plugin/field_group/FieldGroupFormatter/LayoutFormatter.php).

Warning: Undefined array key "" in Drupal\field_group_layout\Plugin\field_group\FieldGroupFormatter\LayoutFormatter->settingsForm() (line 73 of modules/contrib/field_group_layout/src/Plugin/field_group/FieldGroupFormatter/LayoutFormatter.php).

Yes, that is the one I tested:
https://git.drupalcode.org/project/field_group_layout/-/merge_requests/5.diff

And it gives the new errors.

This simply use the module description inside the help page, which is really not useful. To implement a help page it should be more detailed description about how to actually use the module.

I tested the patch, but the group layout is not changed, and I get some new errors:

Warning: Attempt to read property "format_type" on null in field_group_field_ui_display_form_alter() (line 350 of /var/lib/tugboat/stm/web/modules/contrib/field_group/includes/field_ui.inc)

Warning: Undefined variable $new_group1 in Drupal\field_group_layout\Plugin\field_group\FieldGroupFormatter\LayoutFormatter->settingsSummary() (line 153 of /var/lib/tugboat/stm/web/modules/contrib/field_group_layout/src/Plugin/field_group/FieldGroupFormatter/LayoutFormatter.php)

I tested this patch, but I still received the same error:
https://git.drupalcode.org/project/field_group_layout/-/merge_requests/4.diff

This simply use the module description inside the help page, which is really not useful. To implement a help page it should be more detailed description about how to actually use the module.

Great, thanks!

I've started to make an implementation of the view modes, but didn't finish it yet.

I think we could have a hook, but in that case it should not be just to change the label, but to take complete control of the output (label + link)

I tested #8 manually, tried to restrict to 3 results, but I still see more than 3 results.

> duplicates are checked during typing in the title field.

I tested now and it seems like it is only checked when the title field is unfocused - am I missing something?

> disabling the submit button when focusing the title field

Am not sure if this is the best solution. What happens if the user only want to change the title, make changes without unfocusing the title field, and then doesn't understand why the submit button is disabled?

I tested this manually, and I still see current node in results when adding the exact same title:
https://git.drupalcode.org/project/anti_duplicates/-/merge_requests/3.diff

I tested this, and when writing a title I now get this error in the log:

Error: Call to a member function addCommand() on null in Drupal\anti_duplicates\Form\AntiDuplicatesFormAlter::duplicatesSearch() (line 76 of /var/lib/tugboat/stm/web/modules/contrib/anti_duplicates/src/Form/AntiDuplicatesFormAlter.php)

I have the same problem!

This looks pretty good, but could make it not possible to drag elements into same level as the columns?

Sorry, I forgot, I added it now, will be more careful to add it moving forward!

I guess it would, as that can be done using css, right? But if we have a patch to implement the feature we could spend a little time testing on it to see if different scenarios could be covered.

I tested this, but I got a funny result. I tried to first create one node with title "Test node 1", then another node "Test node 2". After I try to edit the node "Test node 2", and then the current node ( "Test node 2") is still displayed in the list. However the count is correct (not counting current node), but the current node is still displayed in the list.

Hi! Sorry you had to wait a little on some of the issues! I'm open to collaborate, but maybe we should discuss a little roadmap first? Are you just looking at solving bugs or would you like to make bigger changes on the module?

I worked with co-maintainers before who are so eager to quickly solve their own issues that they forget to consolidate the solution, and either introduce new bugs or introduce solutions only tailored to their own cases. I personally check everything thoroughly before I commit, I like to have several eyes on it, do some manual checking, and discuss others use cases. I prefer to spend a little longer time to make something solid than work too quickly :)

My own idea with this module for now is that it should have some more flexible configuration of the result box, and that it should be more configurable for each content type - what are your own thoughts?

My own thoughts is that we should probably make the whole message configurable, than provide the count as an optional token. What do you think?

Thanks for the effort.

I think we need to discuss this a little bit. My plan was to make it possible to configure a view mode for the results, in that case you could configure the display anyhow you want through the UI. However it should then be possible to configure different view mode for each content type.

Any thoughts?

Thank you, but the patch needs to be rerolled

It looks good, but I think the patch need to be rerolled!

Great, thanks for the effort!

Thank you for this effort. I do see the problem. However one challenges with this patch is when the user want to only change the title and click on "save" button before the title field is unfocused. When I tried that the title field becomes empty and I get an error message stating that the title field is required. Please check an earlier bug 🐛 Title changes not submitted via AJAX Post in some cases Fixed when you could actually save the node before the duplicates are checked leading to new title being lost. I think this is where the problem you try to address was introduced, but it also needs to be possible to save the node without unfocusing the title first

Thank you 🙏

I do understand it can be difficult to cater for everyone, but I hope it will be possible to find a way to keep configurable options so it is possible redirecting to a confirmation page!

Great!

matsbla → created an issue.

matsbla → created an issue.

matsbla → created an issue.

I am also not able to reproduce this. Can you give steps to reproduce? And could you clarify what you mean with 'name', e.g. class name, machine name, UI name, etc?

Lasts tests for context module added in 🐛 Settings no longer stored as third party settings Fixed

Great suggestion - if someone add a patch for it will help review

Oh okay.
But is it still not strange that these module never received any patch for update? Shouldn't all projects module that?