Contrib.social

Coding stardards

Open on Drupal.org →
Created on 29 November 2024, about 2 months ago

Problem/Motivation

FILE: ...image_field_permissions/src/ImageFieldPermissionsServiceProvider.php
--------------------------------------------------------------------------------------------------------------------------------------FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------- 12 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
17 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------------------------------------------------------------------PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

FILE: ...image_field_permissions/src/ImageFieldPermissionsPermissionsManager.php
--------------------------------------------------------------------------------------------------------------------------------------FOUND 3 ERRORS AND 1 WARNING AFFECTING 4 LINES
-------------------------------------------------------------------------------------------------------------------------------------- 11 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
16 | ERROR | [x] Expected 1 blank line before function; 0 found
23 | ERROR | [x] Expected 1 blank line after function; 0 found
24 | ERROR | [x] The closing brace for the class must have an empty line before it
--------------------------------------------------------------------------------------------------------------------------------------PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

FILE: ...image_field_permissions/src/ImageFieldPermissionsPermissionsService.php
--------------------------------------------------------------------------------------------------------------------------------------FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 9 LINES
-------------------------------------------------------------------------------------------------------------------------------------- 10 | WARNING | [x] Unused use statement
16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
22 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
23 | ERROR | [x] Data types in @param tags need to be fully namespaced
25 | ERROR | [x] Data types in @param tags need to be fully namespaced
26 | ERROR | [x] Parameter comment indentation must be 3 spaces, found 4 spaces
27 | ERROR | [x] Data types in @param tags need to be fully namespaced
35 | ERROR | [x] Expected 1 blank line before function; 0 found
46 | ERROR | [x] Data types in @var tags need to be fully namespaced
--------------------------------------------------------------------------------------------------------------------------------------PHPCBF CAN FIX THE 8 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------

FILE: ...image_field_permissions/src/Plugin/FieldPermissionType/AdvancedCustomAccess.php
--------------------------------------------------------------------------------------------------------------------------------------FOUND 1 ERROR AND 1 WARNING AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------------------------- 23 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name
28 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------------------------------------------------------------------PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------------------------
Time: 78ms; Memory: 8MB

Steps to reproduce

In the root of the module run phpcs.

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Active

Version

1.0

Component

Code

Created by

🇨🇴Colombia kinyein

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @kinyein
  • Comment about 2 months ago →
    🇨🇴Colombia kinyein
  • Merge request !3Coding standards fix → (Open) created by kinyein
  • Comment about 2 months ago →
    🇨🇴Colombia kinyein

    Hi, I made a merge request to fix the coding standards in this module, I hope it can be reviewed soon :D

  • Comment about 1 month ago →
    a.aaronjake

    a.aaronjake → made their first commit to this issue’s fork.

  • Pipeline finished with Success
    about 1 month ago
    Total: 135s
    #372184
  • Comment about 1 month ago →
    a.aaronjake

    Hi @kinyein,

    It is recommended to use GitLab CI to run automated fixes, I have enabled the pipeline and as can be seen, the phpcs job failed.

    Kindly check

    Thanks,
    Jake

  • Comment about 1 month ago →
    🇮🇳India lavanyatalwar

    Working on it.

  • Pipeline finished with Success
    about 1 month ago
    Total: 143s
    #373496
  • Pipeline finished with Success
    about 1 month ago
    Total: 181s
    #373504
  • Comment about 1 month ago →
    🇮🇳India lavanyatalwar

    Fixed the phpcs pipeline.
    Kindly check :)

  • Comment 22 days ago →
    🇳🇴Norway matsbla

    This is not needed to fix coding standards:

    diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
new file mode 100644
index 0000000000000000000000000000000000000000..1afaac5b9f9359313709757456c77babdb768e4e
--- /dev/null
+++ b/.gitlab-ci.yml
@@ -0,0 +1,29 @@
+################
+# GitLabCI template for Drupal projects.
+#
+# This template is designed to give any Contrib maintainer everything they need to test, without requiring modification.
+# It is also designed to keep up to date with Core Development automatically through the use of include files that can be centrally maintained.
+# As long as you include the project, ref and three files below, any future updates added by the Drupal Association will be used in your
+# pipelines automatically. However, you can modify this template if you have additional needs for your project.
+# The full documentation is on https://project.pages.drupalcode.org/gitlab_templates/
+################
+
+# For information on alternative values for 'ref' see https://project.pages.drupalcode.org/gitlab_templates/info/templates-version/
+# To test a Drupal 7 project, change the first include filename from .main.yml to .main-d7.yml
+include:
+  - project: $_GITLAB_TEMPLATES_REPO
+    ref: $_GITLAB_TEMPLATES_REF
+    file:
+      - "/includes/include.drupalci.main.yml"
+      - "/includes/include.drupalci.variables.yml"
+      - "/includes/include.drupalci.workflows.yml"
+
+################
+# Pipeline configuration variables are defined with default values and descriptions in the file
+# https://git.drupalcode.org/project/gitlab_templates/-/blob/main/includes/include.drupalci.variables.yml
+# Uncomment the lines below if you want to override any of the variables. The following is just an example.
+################
+# variables:
+#   SKIP_ESLINT: '1'
+#   OPT_IN_TEST_NEXT_MAJOR: '1'
+#   _CURL_TEMPLATES_REF: 'main'
\ No newline at end of file
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024