Gin theme compatibility

Open on Drupal.org →

Created on 11 February 2025, about 2 months ago

Problem/Motivation

I'm using Gin theme and the `column-*`'s class CSS rules are rewritten by `.row>*` CSS rule of the Gin theme.

Proposed resolution

Update CSS from:

.column-2 {
    width:50%;
}
.column-3 {
    width:33.333%;
}

to

.row .column-2 {
    width:50%;
}
.row .column-3 {
    width:33.333%;
}

Also, the CSS formatting does not follow Drupal coding standards.

🐛 Bug report

Status

Active

Version

2.0

Component

Code

Created by

🇦🇺Australia alex.skrypnyk Melbourne

Live updates comments and jobs are added and updated live.

Sign in to follow issues

Merge Requests

!10Gin theme compatibility
Open
🇮🇳India abhiyanshu
updated about 2 months ago

Comments & Activities

Issue created by @alex.skrypnyk
Comment about 2 months ago →
🇦🇺Australia alex.skrypnyk Melbourne
Patch attached
Comment about 2 months ago →
🇮🇳India abhiyanshu
Merge request !10updated the css → (Open) created by abhiyanshu
Comment about 2 months ago →
🇮🇳India abhiyanshu
Hey alex,
Applied the patch successfully and created the merge request !10 for the same. Thank you!
Comment about 2 months ago →
🇮🇳India abhiyanshu

Comment 20 days ago →

🇳🇴Norway matsbla

Hi, thanks for the report. Here are some comments:

 .row {
-    width:100%;
-    display: inline-flex;
-    flex-wrap: wrap;
+  width: 100%;
+  display: inline-flex;
+  flex-wrap: wrap;
 }
 
 .layout fieldset {
-    border: 0;
+  border: 0;
 }

Wrong indentation

+.row .column-2 {
+  width: 50%;
 }

the selector .row .column-2 includes an unintended space

Comment 5 days ago →
🇦🇺Australia alex.skrypnyk Melbourne
@matsbla
I cannot see an incorrect indentation in the MR. Back to NR

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024