Allow altering the node link

Thanks for the effort.

I think we need to discuss this a little bit. My plan was to make it possible to configure a view mode for the results, in that case you could configure the display anyhow you want through the UI. However it should then be possible to configure different view mode for each content type.

Any thoughts?

Sounds interesting. Would it still be possible to show results inline in a list though?

I guess it would, as that can be done using css, right? But if we have a patch to implement the feature we could spend a little time testing on it to see if different scenarios could be covered.

I don't think doing this using view modes is a good idea. View modes are good for rendering HTML, teasers or whole pages, but it isn't exactly made for rendering a simple string. I don't really know another place in core where view modes are used for something like this. Also, I don't see how we could make any rendered entity look good in a simple list with a bit of basic CSS provided by the module.

How about we just commit the alter hook? It's ready to be committed and it's the simplest, most flexible solution IMO. If we want to improve further and add something like view modes later we can, but it shouldn't stop us from committing this now. Both solutions can exist together.

A good middle way could be to add a Node label setting where you can change what's displayed using tokens. What do you think?

Thinking about it, that still wouldn't allow people to set different displays per node type. Any chance we could just get this hook merged? I don't see the harm, we could still add another way to control this later. Alter hooks are all over Drupal.

I've started to make an implementation of the view modes, but didn't finish it yet.

I think we could have a hook, but in that case it should not be just to change the label, but to take complete control of the output (label + link)

@matsbla maybe open a new issue/MR for the view mode feature to keep this one focused on the alter hook

I changed the hook_anti_duplicates_node_label_alter hook to hook_anti_duplicates_node_link_alter.

  if ($node->getType() === 'person') {

    $label .= sprintf(' (%s)', $node->get('field_last_name')->value);

This seems like part of hard-coded custom code, perhaps should be removed from the patch?

@matsbla is this one good to go?