Opened the MR and adding a patch for a quick fix.
mitthukumawat → created an issue.
The coding standard issues stand fixed. Checkout to the issue and phpcs looks clean now. Moving to RTBC.
I have tested the changes after phpcs fixes. These looks fine. It has two other issues as below that also have been addressed. Moving to RTBC.
FILE: key_asymmetric/src/Plugin/KeyType/AsymmetricPublicKeyType.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
197 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
FILE: key_asymmetric/src/Plugin/KeyType/AsymmetricPrivateKeyType.php
--------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------------------------
172 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------
mitthukumawat → made their first commit to this issue’s fork.
Awesome, it resolved all phpcs coding standard issues. It can be merged now.
Yes, Drupal 10 version is working fine for me as well. Moving this to RTBC.
Verified this issue locally and found the dependency drupal:text added for easy email module.
Taking these changes removing the html_entities.php file. And found this is not called anywhere in entire codebase so it is good to be merged.
I verified this and the phpstan also getting passed and it is mergeable.
CSpell validation passed in this MR. It could be merged.
I have verified this fix. Taken the pull from this issue branch and it resolved the warning.
This issue also could be closed as its Drupal 10 version is working as expected.
I am testing this module and it is working well in Drupal 10. I think it is good to close these two issues asking for compatibility to Drupal 10.
mitthukumawat → made their first commit to this issue’s fork.
It is a much needed feature. With above changes, url_decode filter is added and functioning well.
I tried this snippet in twig template and it rendered a url as expected : URL decoded is : {{ 'https%3A%2F%2Fwww.drupal.org/project/twig_tweak%2F'|url_decode }}.
It only resolved the \Drupal calls should be avoided in classes, use dependency injection instead errors. We should address all coding standard issues raised by phpcs.
It resolved some Drupal coding standards but still there are lot of coding standard issues exists in code.
The feature stands working after applying above changes. Before these changes, only image fields supported the "Cocoen Before After Media" formatter. But now media fields also supported this formatter.
After applying this formatter, the display of images also functioning as expected.
Moving to RTBC.
Above patch worked fine, still there was one issue in javascript.
The banner_attach setting was not referred to the javascript from hook_page_attachments. I have added and created a MR for merge.
mitthukumawat → made their first commit to this issue’s fork.
Resolved all coding standard errors.
The feature Disable exact match boosting on the full processing level. added with above MR. I can see a checkbox and it is functioning fine.
Found these few coding standard issue when run the phpcs so resolved those as well in same MR.
/modules/contrib $ phpcs --standard=Drupal --extensions=php,module,inc,install search_api_exactmatch_boost/
/modules/contrib/search_api_exactmatch_boost/src/Plugin/search_api/processor/ExactMatchBoost.php
-------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AND 2 WARNINGS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------------------------
72 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
72 | ERROR | [x] Closing brace indented incorrectly; expected 2 spaces, found 3
98 | ERROR | [x] Array closing indentation error, expected 8 spaces but found 10
113 | ERROR | [x] Comma not allowed after last value in single-line array declaration
113 | ERROR | [x] Expected one space after the comma, 0 found
197 | WARNING | [ ] Line exceeds 80 characters; contains 120 characters
198 | WARNING | [ ] Line exceeds 80 characters; contains 105 characters
199 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
210 | ERROR | [x] Inline comments must end in full-stops, exclamation marks, question marks, colons, or closing parentheses
-------------------------------------------------------------------------------------------------------------------------------
This feature is good to get merged.
I have reviewed this issue locally and above changes fixed the typo. Now sting replaced with string. Moving to RTBC.
Service navigation.menu.invalidator removed when pull above changes locally and the navigation also working awesome after that.
Found few coding standard issues, that would be addressed in future as per
Fix the issues reported by phpcs
📌
Fix the issues reported by phpcs
Closed: works as designed
.
I have checked all conding standard errors via phpcs and it was showing these :
/modules/contrib $ phpcs --standard=DrupalPractice --extensions=php,module,inc,install tripadvisor_integration/
FILE: /modules/contrib/tripadvisor_integration/src/Form/TripAdvisorIntegrationAdminForm.php
-----------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 4 WARNINGS AFFECTING 4 LINES
-----------------------------------------------------------------------------------------------------------------------------------------
50 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
54 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
63 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
-----------------------------------------------------------------------------------------------------------------------------------------
/modules/contrib $ phpcs --standard=Drupal --extensions=php,module,inc,install tripadvisor_integration/
FILE: /modules/contrib/tripadvisor_integration/tripadvisor_integration.module
----------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
----------------------------------------------------------------------------------------------------
51 | ERROR | [x] Namespaced classes/interfaces/traits should be referenced with use statements
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------
FILE: /modules/contrib/tripadvisor_integration/src/Form/TripAdvisorIntegrationAdminForm.php
------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------
20 | WARNING | Possible useless method overriding detected
------------------------------------------------------------------------------------------------------------------
FILE: /modules/contrib/tripadvisor_integration/src/Plugin/Field/FieldType/TripAdvisorItem.php
--------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
--------------------------------------------------------------------------------------------------------------------
36 | WARNING | Possible useless method overriding detected
--------------------------------------------------------------------------------------------------------------------
FILE:/modules/contrib/tripadvisor_integration/src/Plugin/Field/FieldFormatter/TripAdvisorFieldFormatter.php
-----------------------------------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
-----------------------------------------------------------------------------------------------------------------------------------
27 | ERROR | Class property $cache_backend should use lowerCamel naming without underscores
34 | ERROR | Class property $date_time should use lowerCamel naming without underscores
41 | ERROR | Class property $module_extension_list should use lowerCamel naming without underscores
-----------------------------------------------------------------------------------------------------------------------------------
Most of the errors from above has been fixed except Possible useless method overriding detected.
mitthukumawat → made their first commit to this issue’s fork.
mitthukumawat → made their first commit to this issue’s fork.
Switched to 3441093-compatibility-fixes-for branch and the compatibility issues fixed for External Entities Beta1. The changes are working in Drupal 10 version. Moving to RTBC.
Tested this change locally and it made this module compatible to Drupal 10. Applied the patch and created MR. Moving to RTBC.
mitthukumawat → made their first commit to this issue’s fork.
I have tested the Lazy Views locally with above changes. The view is loading using ajax.
Also the jQuery dependency has been removed from the js library of this module. Moving to RTBC.
The error has been resolved after taking pull from above MR. Moving to RTBC.
Fixed some of the coding standard issues occurred when running phpcs with Drupal and DrupalPractice.
/modules/contrib $ phpcs --standard=DrupalPractice --extensions=php,module,inc,install agreement/
FILE: modules/contrib/agreement/agreement.module
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
61 | WARNING | Unused variable $id.
------------------------------------------------------------------------
FILE: modules/contrib/agreement/src/Entity/AgreementForm.php
------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------
106 | WARNING | Unused variable $role_name.
------------------------------------------------------------------------------------
/modules/contrib $ phpcs --standard=Drupal --extensions=php,module,inc,install agreement/
FILE: modules/contrib/agreement/tests/src/Functional/AgreementCustomUnprivilegedUserTest.php
------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------------------------------------------------------------------------------
183 | WARNING | [x] '@todo: Log in following password reset link, go somewhere other than' should match the format '@todo Fix problem X here.'
------------------------------------------------------------------------------------------------------------------------------------------------
FILE: modules/contrib/agreement/agreement.install
-----------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-----------------------------------------------------------------------------
64 | ERROR | Doc comment short description must start with a capital letter
-----------------------------------------------------------------------------mitthukumawat → made their first commit to this issue’s fork.
Fixed below coding standard errors:
/modules/contrib $ phpcs --standard=Drupal --extensions=php,module,inc,install launch_checklist/
FILE: /modules/contrib/launch_checklist/inc/section_14_printability.inc
--------------------------------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AND 1 WARNING AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------------------------------------------
8 | WARNING | [x] Unused use statement
29 | ERROR | [x] Short array syntax must be used to define arrays
29 | ERROR | [ ] The array declaration extends to column 211 (the limit is 80). The array content should be split up over multiple lines
--------------------------------------------------------------------------------------------------------------------------------------------mitthukumawat → made their first commit to this issue’s fork.
The logo.svg moved to root directory after pulling above changes. Moved to RTBC.
I run the phpcs coding standard with above changes and it looks fine now. Moving to RTBC.
I have reviewed this issue. The phpcs coding standards stand fixed now. There are few additional warnings also fixed in this.
phpcs --standard=DrupalPractice --extensions=php,module,inc,install gin_login/
FILE: /home/inno/Projects/D10/modules/contrib/gin_login/gin_login.module
------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
------------------------------------------------------------------------
197 | WARNING | Unused variable $darkmode.
------------------------------------------------------------------------
FILE: /home/inno/Projects/D10/modules/contrib/gin_login/src/Form/GinLoginConfigurationForm.php
------------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES
------------------------------------------------------------------------------------------------------------------------------------------
66 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
102 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead
118 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
172 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
228 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
247 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead
------------------------------------------------------------------------------------------------------------------------------------------These all has been fixed.
mitthukumawat → made their first commit to this issue’s fork.
I have review this issue. I see the classes are getting added to the svg icon wrapper.
Below example phrase will add a class to its wrapper.
{{ icon('fa-2x fa-solid fa-shake', 'Icon title', ['extra-class', 'another-class'], {'name-one': 'value-one', 'name-two': 'value-two'}, {'wrapper-classone' : 'wrapper-classvalue'}) }}
Attaching screenshot for reference.
mitthukumawat → made their first commit to this issue’s fork.
@mauryarahul11, thanks for the suggestion. You are correct I think.
We can create a export using views so this may not be required at this stage.
If there are more takers on this feature, we can re-open and add that.
Tested this change in fresh Drupal 10 installation. It is working as expected.
Thanks for working on this issue. The patch looks good and new feature is working fine. I am able to change the feedback link appearance in left or right side.
mitthukumawat → made their first commit to this issue’s fork.
@SirClickalot
I have tried the Article .* has been updated. in Messages to be disabled field. I think it is not working for you because the administrator role has Exclude from message filtering permission by default with installation.
So please try the debug option Ignore the exclude role permission to check with Administrator role users.
The MR pipeline looks good. The readme.md could be merged with 2.x branch.
RTBC +1 from me also. The Drupal and Drupal Practice phpcs are cleared in as above.
@zenimagine I have created a view and tried the way you wanted. It is working as expected.
In your case, as you are using the custom path search/node/@keys, it is a default node search page.
Thanks @jurgenhaas, I have reviewed again and it is working fine.
I have pull the MR in a drupal setup. These are the findings :
- The option Search for file entities exists.
- After enabling it, the search 404 not working. It showing this error :
Error: Call to a member function getStorage() on null in Drupal\search404\Controller\Search404Controller->findFileEntity() (line 605 of /app/modules/contrib/search404/src/Controller/Search404Controller.php).
mitthukumawat → made their first commit to this issue’s fork.
mitthukumawat → created an issue.
This has already been fixed in https://www.drupal.org/project/search404/issues/2917389 → .
No, after applying patch
#2
✨
Bring no (empty) results text into alignment with D8 and/or make customizable
Needs work
, only one hook suggestion showing from core.
This is because it cannot suggest multiple hooks from one build.
Added screenshot of the results after adding below hook suggestion:
'item_list__search_results__' . $plugin->getPluginId(),
'item_list__search_results',
'item_list__search_results__search404',
'item_list__search_results__search404__' . $plugin->getPluginId(),Let me made these changes in this branch and will open a MR.
The MR!22 adds a lot of unrelated changes, I think that's unwanted.
It is for 8.x-1.x branch. It is showing unrelated changes because of this branch is behind many commits. We can either ignore this.
Is there a reason for removing it? That may break sites.
Yes, actually this hook suggestion is for only search 404.
'item_list__search_results__' . $plugin->getPluginId(),
'item_list__search_results',These are default hook available for all core search results pages.
What do you think, should we keep the core hooks as default for search 404 as well, from where developers can customise accordingly?
The merge request !22 is for 8.x-1.x and merge request !23 for 2.x branch.
I have added a new template suggestion for search 404 results. We can find a name suggestion as item-list--search-results--search404.html.twig. And the default template for the search results is item-list--search-results.html.twig.
mitthukumawat → made their first commit to this issue’s fork.
I think it is good now to have new message. Further we can get feedback and can improve once other related issues get merged with it.
@Anybody, I am working closely with Maintainer on this module.
Added a change to use the search keys in array instead a string.
Please review.
mitthukumawat → made their first commit to this issue’s fork.
Let's create the remaining phpunit tests in 📌 Create tests to test this modules functionality Active .
I am reviewing the issue and find one problem. After enabling the Abort search on all paths containing file extensions checkbox, the file extension 404 showing Invalid keywords used..
Thanks @Gravil.
The redirection is fine and the phpunit tests we can fix in
📌
Create tests to test this modules functionality
Active
as many unmerged issues are related to each others and need all fixed changes at one place for functional test cases.
As the search-404 class is present in 404 search results, we can move this to RTBC.
The changes for failed test cases are fine and can be moved to RTBC. Further test cases will be followed up in the ticket 📌 Create tests to test this modules functionality Active .
The 404 redirect is working for ignored extensions after above fixes. It is just saying the page not found if it does not exist and search should not perform for that extension.
We can referer
📌
Create tests to test this modules functionality
Active
for further missing phpunit test cases once all changes get merged at single place.
Moving to RTBC.
The schema error gone away with above MR so we can move this to RTBC.
We can refer
📌
Create tests to test this modules functionality
Active
for missing phpunit tests for entire module.
Thanks @swatichouhan012
The solution with UrlHelper::isValid worked perfectly for me. I have switched to the 3320104-allow-all-valid branch and checked with all possible cases.
Moving to RTBC.
@@DieterHolvoet
This issue fixes for all conditions now. Before last commit, when the option Contains any word from the title checked in search types config, the condition for ignoring current node not added.
After this, I tested all cases and it is working fine.
RTBC +1
mitthukumawat → made their first commit to this issue’s fork.
The logo is appearing fine after taking pull of above changes.
This issue is no longer exists in latest version. It has been fixed in
Fix schema type to config_object and add missing for regex →
Please feel free to re-open if this issue still persist after upgrading to latest version.
Thanks @Rohit Rana
The patch worked perfectly and it fixed the issue. Committed the patch with one other coding standard issue.
mitthukumawat → made their first commit to this issue’s fork.
This issue is a duplicate of which has already been merged with 2.x branch.
@samit.310@gmail.com
Added
schema
are fine, opened a MR against 2.x. It should not have the failed tests once changes merge together with
Return a "real" Symfony 404 response object instead of mimicking it
🐛
Return a "real" Symfony 404 response object instead of mimicking it
Fixed
mitthukumawat → made their first commit to this issue’s fork.