Contrib.social

Search Engine keyword Detection causes TypeError

Open on Drupal.org →
Created on 15 May 2023, almost 2 years ago
Updated 30 October 2023, over 1 year ago

Problem/Motivation

When a user follows a Google link to a recently disabled page, the Search404 keyword detection feature breaks with a TypeError. The user is presented with a 500 error response.

Steps to reproduce

  • Enable the setting search404_use_search_engine: true
  • Simulate a request from a search engine provider with a dead link
# A simple simulated query
curl 'http://my-site.example.com/dead-link' -H 'Referer: https://www.google.com/search?q=search query'
#The typeError returned.
TypeError: array_diff(): Argument #1 ($array) must be of type array, string given in array_diff() (line 463 of modules/contrib/search404/src/Controller/Search404Controller.php).

Proposed resolution

Update \Drupal\search404\Controller\Search404Controller::search404SearchEngineQuery to return an Array instead of a String.

Remaining tasks

User interface changes

API changes

Data model changes

🐛 Bug report
Status

Fixed

Version

2.0

Component

Code

Created by

🇺🇸United States charlieschams

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Comments & Activities

contrib.social Blog FAQ Discussions
Production build 0.71.5 2024