- Issue created by @chaitanyadessai
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
about 1 year ago Waiting for branch to pass - Issue was unassigned.
- Status changed to Needs review
about 1 year ago 6:25am 18 April 2024 - Status changed to Needs work
about 1 year ago 11:48am 18 April 2024 - ๐ฎ๐ณIndia mitthukumawat
It only resolved the
\Drupal calls should be avoided in classes, use dependency injection instead
errors. We should address all coding standard issues raised by phpcs. - ๐ฎ๐ณIndia dev16.addweb
silvi.addweb โ made their first commit to this issueโs fork.
- Open on Drupal.org โCore: 9.5.x + Environment: PHP 7.4 & MySQL 5.7last update
11 months ago Waiting for branch to pass - Status changed to RTBC
11 months ago 12:21pm 30 May 2024 - ๐ฎ๐ณIndia mitthukumawat
Awesome, it resolved all phpcs coding standard issues. It can be merged now.
- Status changed to Needs work
9 months ago 3:41pm 29 July 2024 - ๐บ๐ธUnited States greggles Denver, Colorado, USA
The advice from #4:
We should address all coding standard issues raised by phpcs.
Is not great advice, unfortunately. There's an existing issue at ๐ Coding standard Needs review to already do that. The 2 issues overlap and change things differently which makes it harder to pick what to do.