- Issue created by @ptmkenny
- Merge request !38remove html_entities for compatibility below PHP 5.4 → (Merged) created by ptmkenny
- last update
12 months ago 113 pass - Status changed to Needs review
12 months ago 11:59am 21 April 2024 - Status changed to RTBC
12 months ago 9:55am 22 April 2024 - 🇮🇳India mitthukumawat
Taking these changes removing the
html_entities.php
file. And found this is not called anywhere in entire codebase so it is good to be merged. - First commit to issue fork.
- last update
12 months ago 113 pass -
MegaChriz →
committed 1ce750f1 on 8.x-1.x authored by
ptmkenny →
Issue #3442308 by ptmkenny, mitthukumawat: Removed no longer needed...
-
MegaChriz →
committed 1ce750f1 on 8.x-1.x authored by
ptmkenny →
- Status changed to Fixed
12 months ago 10:26am 22 April 2024 - 🇳🇱Netherlands megachriz
I checked how it was used in the D7 version and there the reference to html_entities.php was in
FeedsExXmlUtility::decodeNamedHtmlEntities()
:/** * Converts named HTML entities to their UTF-8 equivalent. * * @param string $markup * The string. * * @return string * The converted string. */ public static function decodeNamedHtmlEntities($markup) { if (version_compare(PHP_VERSION, '5.4.0', '<')) { $map = require dirname(dirname(dirname(__FILE__))) . '/resources/html_entities.php'; } else { $map = array_flip(get_html_translation_table(HTML_ENTITIES, ENT_NOQUOTES | ENT_HTML5, 'UTF-8')); unset($map['&'], $map['<'], $map['>']); } return strtr($markup, $map); }
But that line is gone in the equivalent of the code (
\Drupal\feeds_ex\Utility\XmlUtility::decodeNamedHtmlEntities()
. So yes, the file can be safely removed.Merged!
Automatically closed - issue fixed for 2 weeks with no activity.