Redirect to file if available

Stll relevant in 2.x

Nice work @jurgenhaas! :)

@jurgenhaas would you mind providing this as MR for easier review? So we can push things forward here.
Any security considerations? I'm thinking about information disclosure, if files are public but typically not found (security by obscurity isn't security, but sites might still be affected without knowing...)

would you mind providing this as MR for easier review?

Happy to do that, but let's decide on this first:

Any security considerations? I'm thinking about information disclosure, if files are public but typically not found

Good question, I'm not sure. As for the intended use case to help users getting to "bookmarked" file links, it isn't in any way disclosing anything that the user didn't already have, i.e. the name of the file.

However, with this feature, anonymous users could utilize the search feature to deliberately search for arbitrary file names, and they would then get to those files, if they were registered as file entities. That's something they would get otherwise. On the other hand, as you already mentioned, the file is publicly available and therefore supposed to be used/found.

@jurgenhaas thanks! :)

Yes I agree, so having this as an option, disabled by default, should be a good choice. Should we add a sentence to the description to describe this minor risk?
I'm also fine with the current implementation, as the user has to opt-in, so this is just about details.

Created an issue fork and opened an MR, please have a look.

Thanks @jurgenhaas LGTM!

I didn't test it myself yet, but code seems fine. Let's wait for community or other maintainer testing it manually before setting it RTBC.

I have pull the MR in a drupal setup. These are the findings :

• The option Search for file entities exists.
• After enabling it, the search 404 not working. It showing this error :
  Error: Call to a member function getStorage() on null in Drupal\search404\Controller\Search404Controller->findFileEntity() (line 605 of /app/modules/contrib/search404/src/Controller/Search404Controller.php).

Thanks @mitthukumawat for finding and reporting this issue. This happened after we switched to dependency injection for services and instead of calling $this->entityTypeManager we need to call the function $this->entityTypeManager() to get to that service.

I've updated the MR, please give it another try.

Thanks @jurgenhaas, I have reviewed again and it is working fine.

Merged to 2.x branch

Automatically closed - issue fixed for 2 weeks with no activity.