- 🇩🇪Germany Anybody Porta Westfalica
I also can't see a good reason to disallow "-" as a character. Is there any? Otherwise all characters allowed in URLs should be allowed.
See https://stackoverflow.com/questions/2058578/best-way-to-check-if-a-url-i...
- csymlstd Dallas, TX
I ran into an issue with a site having a hyphenated search url previously saved, and could not save any additional settings changes. This patch will at least allow hyphens while allowing all valid characters is up for discussion.
- Open on Drupal.org →Core: 9.5.x + Environment: PHP 7 & MySQL 5.5last update
almost 2 years ago Waiting for branch to pass - last update
almost 2 years ago Composer error. Unable to continue. - 🇮🇳India swatichouhan012
Just allowed "-" would be a good solution here ? We can use UrlHelper::isValid https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util... To check the valid URLs for the custom search path.
- Assigned to swatichouhan012
- Status changed to Needs work
almost 2 years ago 9:52am 14 July 2023 - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7 & MySQL 5.5last update
almost 2 years ago Waiting for branch to pass - @swatichouhan012 opened merge request.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 10:12am 14 July 2023 - 🇮🇳India swatichouhan012
Added Validation with UrlHelper::isValid, also changed validation message to match , Please review and suggest if need any changes.
- Status changed to RTBC
over 1 year ago 7:17am 27 October 2023 - 🇮🇳India mitthukumawat
Thanks @swatichouhan012
The solution withUrlHelper::isValid
worked perfectly for me. I have switched to the3320104-allow-all-valid
branch and checked with all possible cases.
Moving to RTBC. - Open on Drupal.org →Core: 9.5.x + Environment: PHP 7 & MySQL 5.5last update
over 1 year ago Waiting for branch to pass -
Anybody →
committed 44b78db8 on 2.x authored by
swatichouhan012 →
Issue #3320104 by swatichouhan012, mitthukumawat, Anybody: Allow all...
-
Anybody →
committed 44b78db8 on 2.x authored by
swatichouhan012 →
- Status changed to Fixed
about 1 year ago 8:25am 7 February 2024 Automatically closed - issue fixed for 2 weeks with no activity.