๐Ÿ‡ฎ๐Ÿ‡ณIndia @swatichouhan012

Account created on 26 September 2017, about 7 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Hello,

I have created a patch to solve the errors related to t() calls .

Please review and apply it .

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Here's a patch for it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Fixed some PHPCS issues.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Here's a patch for it.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

The statements are now sorted. Please review the patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

I have Created a patch to fix this issue

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Patch with the fix it's in the attachment.

Regards.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

The statements are now sorted. Please review the patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

The statements are now sorted. Please review the patch

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Both Patch Failed to Apply. Moving this with MR. Please add any suggestion to MR.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Hii adriancid,

Thanks for showing interest to maintain this Module, I have added you as maintainer , feel free to add Feature to Improve the Module Functionality.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Looking Good, Thanks for the Patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

swatichouhan012 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

HIi _renify_

To change the services with Global Service not good practice , i tried to replicate using a custom call but not got getting the mentioned error, would be great if you an provide more info the process you followed.

Thanks

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Added Validation with UrlHelper::isValid, also changed validation message to match , Please review and suggest if need any changes.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Just allowed "-" would be a good solution here ? We can use UrlHelper::isValid https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Component%21Util... To check the valid URLs for the custom search path.

๐Ÿ‡ฎ๐Ÿ‡ณIndia swatichouhan012

Hii @Grevil

Regarding MR14 We are using same class "search-404" for both Form and Search result. would be better to add different class names "search-404" and "search-404-results" ?

Production build 0.71.5 2024