- Issue created by @swatichouhan012
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 1:33pm 19 July 2023 - ๐ฎ๐ณIndia swatichouhan012
The statements are now sorted. Please review the patch
- Status changed to Needs work
about 2 months ago 2:42am 19 July 2024 Hi @swatichouhan012,
The patch you provided was applied successfully and confirmed fixed sorting of statements, however, sorting is not the only error that was reported by my terminal, those errors needs to be fixed. Please see below:
qtools_transport_profiler git:(1.0.x) curl https://www.drupal.org/files/issues/2023-07-19/3375579-2.patch | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 2248 100 2248 0 0 5762 0 --:--:-- --:--:-- --:--:-- 5931 patching file src/Form/ReportFilterForm.php patching file src/ReportService.php patching file src/TransportServiceWrapper.php โ qtools_transport_profiler git:(1.0.x) โ cd .. โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig qtools_transport_profiler FILE: ...9/web/modules/contrib/qtools_transport_profiler/src/PerformanceService.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 58 | ERROR | [x] Multi-line function declarations must have a trailing comma | | after the last parameter -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: .../modules/contrib/qtools_transport_profiler/src/TransportServiceWrapper.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 60 | ERROR | [x] Multi-line function declarations must have a trailing comma | | after the last parameter -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...contrib/qtools_transport_profiler/src/Controller/ErrorReportController.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 47 | ERROR | [x] Multi-line function declarations must have a trailing comma | | after the last parameter -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- FILE: ...ntrib/qtools_transport_profiler/src/Controller/RequestReportController.php -------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------- 43 | ERROR | [x] Multi-line function declarations must have a trailing comma | | after the last parameter -------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------- Time: 689ms; Memory: 16MB
Kindly check
Thanks,
Jake- ๐ฎ๐ณIndia atul ghate
atul_ghate โ made their first commit to this issueโs fork.
- Status changed to Needs review
about 2 months ago 3:23am 19 July 2024 - Status changed to RTBC
about 2 months ago 11:32am 19 July 2024 - ๐ฎ๐ณIndia VinmayiSwamy
Hi,
I've tested MR !1 in Drupal 10.3.xโจThe patch is applied Cleanly...Test Result:โจ
The phpcs issues were fixed after the updated changes.RTBC+1
Thanks!
Hi @everyone,
Also confirmed MR!1 fixed all reported errors.
qtools_transport_profiler git:(1.0.x) curl https://git.drupalcode.org/project/qtools_transport_profiler/-/merge_requests/1.diff | patch -p1 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 4465 0 4465 0 0 14843 0 --:--:-- --:--:-- --:--:-- 15238 patching file src/Controller/ErrorReportController.php patching file src/Controller/RequestReportController.php patching file src/Form/ReportFilterForm.php patching file src/PerformanceService.php patching file src/ReportService.php patching file src/TransportServiceWrapper.php โ qtools_transport_profiler git:(1.0.x) โ cd .. โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig qtools_transport_profiler zsh: command not found: phpcs โ contrib git:(master) โ phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig qtools_transport_profiler โ contrib git:(master) โ
RTBC +1 also from me.
Thanks,
Jake