File extensions added in "search404_ignore_query" are being ignored.

Thanks, that sounds weird. We should have a test to proof that.

Please review! Tests will be added shortly.

Hm maybe we should move parts of this issue to a seperate issue, as the general settings logic also changed?

Through this issue the "Extensions to ignore" setting has a higher priority, then the "Extensions to abort search" setting, I think this priority only makes sense, and it is a good clean up before 📌 Add option to exclude all non whitelisted file paths (Performance) Needs review is additionally added.

Either way, we should also add an update hook to let the user know about this change.

I agree with #5. The option to introduce in 📌 Add option to exclude all non whitelisted file paths (Performance) Needs review will be the more general alternative to "Extensions to abort search" and as written there, hide that field and do its own general check instead.

Reviewed and commented! LGTM in all other parts, nice work @Grevil! This module definitely needs an overhaul.

Created a separate issue, see 📌 The "Extensions to ignore" setting should have a higher priority than "Extensions to abort search" Fixed .

Setting this a major bug, as the functionality isn't working (at all) as expected. This had already been reported in the past: 🐛 Extensions to abort search do nothing Closed: duplicate
This bug also has bad implications for performance, see 🐛 Exclude fast_404 paths and file extensions by default (Performance) Postponed: needs info AND is a blocker for that. So many good reasons for "Major". :)

Done, please review!

Perfect, next step: Tests, please! :)

Since there are no functional tests implemented for this module yet, I'd suggest we refer to the test issue, and create the tests there, after these fixes are committed to dev (preferably to a new SemVer Version), WITHOUT creating a new release until the tests are implemented there.

Referring to 📌 Create tests to test this modules functionality Active .

The 404 redirect is working for ignored extensions after above fixes. It is just saying the page not found if it does not exist and search should not perform for that extension.
We can referer 📌 Create tests to test this modules functionality Active for further missing phpunit test cases once all changes get merged at single place.
Moving to RTBC.

@Grevil: Needs rebase, can be also done in GitLab.

Done, merging.

Automatically closed - issue fixed for 2 weeks with no activity.