The "Extensions to ignore" setting should have a higher priority than "Extensions to abort search"

Created on 17 May 2023, about 1 year ago
Updated 30 October 2023, 8 months ago

Problem/Motivation

Currently, if the same file extension is mentioned inside "extensions" to ignore and "Extensions to abort search", the search query will get aborted (at least with 🐛 File extensions added in "search404_ignore_query" are being ignored. Fixed applied). Through the structure of the form, it seems like it would be the other way around. Furthermore, codewise, this is a great setup for the implementation of 📌 Add option to exclude all non whitelisted file paths (Performance) Needs review .

Perhaps there's also a more self-explaining name for "Extensions to abort search" which isn't very clear. "Extensions to ignore" is clear, I think, but there isn't a search being aborted, from my perspective?

Steps to reproduce

Proposed resolution

Set "Extensions to ignore" to have a higher priority than "Extensions to abort search"

Remaining tasks

User interface changes

API changes

Data model changes

📌 Task
Status

Fixed

Version

2.0

Component

Code

Created by

🇩🇪Germany Grevil

Live updates comments and jobs are added and updated live.
  • Needs tests

    The change is currently missing an automated test that fails when run with the original code, and succeeds when the bug has been fixed.

Sign in to follow issues

Comments & Activities

Production build 0.69.0 2024