- Issue created by @maithri shetty
- Issue was unassigned.
- Status changed to Needs review
about 1 year ago 2:05pm 11 March 2024 - First commit to issue fork.
- Merge request !31Issue #3427099: Drupal calls should be avoided in classes, use dependency injection instead → (Merged) created by mitthukumawat
- Status changed to RTBC
about 1 year ago 1:29pm 14 March 2024 - 🇮🇳India mitthukumawat
I have reviewed this issue. The phpcs coding standards stand fixed now. There are few additional warnings also fixed in this.
phpcs --standard=DrupalPractice --extensions=php,module,inc,install gin_login/ FILE: /home/inno/Projects/D10/modules/contrib/gin_login/gin_login.module ------------------------------------------------------------------------ FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ------------------------------------------------------------------------ 197 | WARNING | Unused variable $darkmode. ------------------------------------------------------------------------ FILE: /home/inno/Projects/D10/modules/contrib/gin_login/src/Form/GinLoginConfigurationForm.php ------------------------------------------------------------------------------------------------------------------------------------------ FOUND 0 ERRORS AND 6 WARNINGS AFFECTING 6 LINES ------------------------------------------------------------------------------------------------------------------------------------------ 66 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 102 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 118 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 172 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 228 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead 247 | WARNING | \Drupal calls should be avoided in classes, use dependency injection instead ------------------------------------------------------------------------------------------------------------------------------------------
These all has been fixed.
- Status changed to Needs work
about 1 year ago 6:48pm 20 March 2024 - 🇨🇭Switzerland saschaeggi Zurich
There are still phpcs issues, see https://git.drupalcode.org/issue/gin_login-3427099/-/jobs/1065196
-
saschaeggi →
committed fdafe89c on 2.0.x authored by
mitthukumawat →
Issue #3427099: Drupal calls should be avoided in classes, use...
-
saschaeggi →
committed fdafe89c on 2.0.x authored by
mitthukumawat →
- Status changed to Fixed
about 1 year ago 7:38pm 20 March 2024 - 🇨🇭Switzerland saschaeggi Zurich
I've fixed the phpcs errors and merged this. Thanks!
Automatically closed - issue fixed for 2 weeks with no activity.