Fix the issues reported by phpcs

Created on 21 July 2023, 11 months ago

Problem/Motivation

FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/css/components/menu.pcss.css
-------------------------------------------------------------------------------------------------------------------
FOUND 36 ERRORS AFFECTING 26 LINES
-------------------------------------------------------------------------------------------------------------------
  29 | ERROR | [x] Blank lines are not allowed in class definitions
  40 | ERROR | [x] Selectors must be on a single line
  41 | ERROR | [x] Blank lines are not allowed between class names
  42 | ERROR | [ ] Style definitions must end with a semicolon
  75 | ERROR | [x] Selectors must be on a single line
  76 | ERROR | [x] Blank lines are not allowed between class names
  77 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
  77 | ERROR | [ ] Style definitions must end with a semicolon
  78 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
  78 | ERROR | [ ] Style definitions must end with a semicolon
  90 | ERROR | [x] Selectors must be on a single line
  91 | ERROR | [x] Blank lines are not allowed between class names
  92 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
  92 | ERROR | [ ] Style definitions must end with a semicolon
  93 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
  93 | ERROR | [ ] Style definitions must end with a semicolon
 110 | ERROR | [ ] Style definitions must end with a semicolon
 111 | ERROR | [x] Selectors must be on a single line
 112 | ERROR | [x] Blank lines are not allowed between class names
 113 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 113 | ERROR | [ ] Style definitions must end with a semicolon
 114 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 114 | ERROR | [ ] Style definitions must end with a semicolon
 122 | ERROR | [x] Blank lines are not allowed in class definitions
 126 | ERROR | [x] Blank lines are not allowed in class definitions
 135 | ERROR | [x] Selectors must be on a single line
 136 | ERROR | [x] Blank lines are not allowed between class names
 137 | ERROR | [ ] Style definitions must end with a semicolon
 180 | ERROR | [x] Selectors must be on a single line
 181 | ERROR | [x] Blank lines are not allowed between class names
 183 | ERROR | [ ] Style definitions must end with a semicolon
 201 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 201 | ERROR | [ ] Style definitions must end with a semicolon
 201 | ERROR | [x] Each style definition must be on a line by itself
 201 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 201 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 24 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/css/components/breadcrumb.pcss.css
-------------------------------------------------------------------------------------------------------------------------
FOUND 10 ERRORS AFFECTING 6 LINES
-------------------------------------------------------------------------------------------------------------------------
 15 | ERROR | [x] Selectors must be on a single line
 16 | ERROR | [x] Blank lines are not allowed between class names
 17 | ERROR | [ ] Style definitions must end with a semicolon
 25 | ERROR | [x] Selectors must be on a single line
 26 | ERROR | [x] Blank lines are not allowed between class names
 27 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 27 | ERROR | [ ] Style definitions must end with a semicolon
 27 | ERROR | [x] Each style definition must be on a line by itself
 27 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 27 | ERROR | [ ] Style definitions must end with a semicolon
-------------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/css/components/icons.pcss.css
--------------------------------------------------------------------------------------------------------------------
FOUND 17 ERRORS AFFECTING 14 LINES
--------------------------------------------------------------------------------------------------------------------
  27 | ERROR | [x] Selectors must be on a single line
  28 | ERROR | [x] Blank lines are not allowed between class names
  29 | ERROR | [ ] Style definitions must end with a semicolon
  44 | ERROR | [x] Selectors must be on a single line
  45 | ERROR | [x] Blank lines are not allowed between class names
  46 | ERROR | [ ] Style definitions must end with a semicolon
  50 | ERROR | [x] Blank lines are not allowed in class definitions
  54 | ERROR | [x] Blank lines are not allowed in class definitions
  58 | ERROR | [x] Blank lines are not allowed in class definitions
  75 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
  75 | ERROR | [ ] Style definitions must end with a semicolon
  76 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
  76 | ERROR | [ ] Style definitions must end with a semicolon
 102 | ERROR | [x] Selectors must be on a single line
 103 | ERROR | [x] Blank lines are not allowed between class names
 104 | ERROR | [x] Expected 1 space after colon in style definition; 0 found
 104 | ERROR | [ ] Style definitions must end with a semicolon
--------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/css/base/variables.pcss.css
------------------------------------------------------------------------------------------------------------------
FOUND 26 ERRORS AFFECTING 18 LINES
------------------------------------------------------------------------------------------------------------------
  5 | ERROR | [x] CSS colours must be defined in lowercase; expected #26a769 but found #26A769
  6 | ERROR | [x] CSS colours must be defined in lowercase; expected #009cde but found #009CDE
  7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 3
  8 | ERROR | [ ] Style definitions must end with a semicolon
  8 | ERROR | [x] CSS colours must be defined in lowercase; expected #ccdbff but found #CCDBFF
  9 | ERROR | [ ] Style definitions must end with a semicolon
  9 | ERROR | [x] CSS colours must be defined in lowercase; expected #002e9a but found #002E9A
 11 | ERROR | [ ] Style definitions must end with a semicolon
 11 | ERROR | [x] CSS colours must be defined in lowercase; expected #f3f4f9 but found #F3F4F9
 12 | ERROR | [ ] Style definitions must end with a semicolon
 12 | ERROR | [x] CSS colours must be defined in lowercase; expected #dedfe4 but found #DEDFE4
 13 | ERROR | [ ] Style definitions must end with a semicolon
 13 | ERROR | [x] CSS colours must be defined in lowercase; expected #c1c2c7 but found #C1C2C7
 14 | ERROR | [ ] Style definitions must end with a semicolon
 15 | ERROR | [ ] Style definitions must end with a semicolon
 16 | ERROR | [ ] Style definitions must end with a semicolon
 16 | ERROR | [x] CSS colours must be defined in lowercase; expected #75767b but found #75767B
 17 | ERROR | [ ] Style definitions must end with a semicolon
 17 | ERROR | [x] CSS colours must be defined in lowercase; expected #55565b but found #55565B
 18 | ERROR | [ ] Style definitions must end with a semicolon
 18 | ERROR | [x] CSS colours must be defined in lowercase; expected #393a3f but found #393A3F
 19 | ERROR | [ ] Style definitions must end with a semicolon
 21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 22 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 29 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 30 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 15 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/css/base/variables.css
-------------------------------------------------------------------------------------------------------------
FOUND 15 ERRORS AFFECTING 15 LINES
-------------------------------------------------------------------------------------------------------------
 14 | ERROR | [ ] Style definitions must end with a semicolon
 15 | ERROR | [ ] Style definitions must end with a semicolon
 17 | ERROR | [ ] Style definitions must end with a semicolon
 18 | ERROR | [ ] Style definitions must end with a semicolon
 19 | ERROR | [ ] Style definitions must end with a semicolon
 20 | ERROR | [ ] Style definitions must end with a semicolon
 21 | ERROR | [ ] Style definitions must end with a semicolon
 22 | ERROR | [ ] Style definitions must end with a semicolon
 23 | ERROR | [ ] Style definitions must end with a semicolon
 24 | ERROR | [ ] Style definitions must end with a semicolon
 25 | ERROR | [ ] Style definitions must end with a semicolon
 27 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 28 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 35 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
 36 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 0
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 4 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/css/base/base.pcss.css
-------------------------------------------------------------------------------------------------------------
FOUND 8 ERRORS AFFECTING 7 LINES
-------------------------------------------------------------------------------------------------------------
  5 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 10 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 12 | ERROR | [x] Line indented incorrectly; expected 0 spaces, found 1
 23 | ERROR | [x] CSS colours must be defined in lowercase; expected #f5f8ff but found #F5F8FF
 57 | ERROR | [x] Selectors must be on a single line
 58 | ERROR | [x] Blank lines are not allowed between class names
 59 | ERROR | [ ] Style definitions must end with a semicolon
 59 | ERROR | [x] Expected 1 space before opening brace of class definition; 2 found
-------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 7 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/navigation.module
--------------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------------------------------
 1 | ERROR | [x] The PHP open tag must be followed by exactly one blank line
 1 | ERROR | [x] Missing file doc comment
 5 | ERROR | [x] Expected 1 blank line before function; 0 found
--------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/README.md
------------------------------------------------------------------------------------------------
FOUND 1 ERROR AND 9 WARNINGS AFFECTING 9 LINES
------------------------------------------------------------------------------------------------
  2 | WARNING | [ ] Line exceeds 80 characters; contains 104 characters
  8 | WARNING | [ ] Line exceeds 80 characters; contains 106 characters
 11 | WARNING | [ ] Line exceeds 80 characters; contains 140 characters
 16 | WARNING | [ ] Line exceeds 80 characters; contains 137 characters
 17 | WARNING | [ ] Line exceeds 80 characters; contains 457 characters
 18 | WARNING | [ ] Line exceeds 80 characters; contains 118 characters
 19 | WARNING | [ ] Line exceeds 80 characters; contains 179 characters
 20 | WARNING | [ ] Line exceeds 80 characters; contains 141 characters
 21 | WARNING | [ ] Line exceeds 80 characters; contains 108 characters
 21 | ERROR   | [x] Expected 1 newline at end of file; 2 found
------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
------------------------------------------------------------------------------------------------


FILE: /Users/roberttabigue/Projects/drupalorgissues/docroot/modules/contrib/navigation/.github/ISSUE_TEMPLATE/general-issue-template.md
---------------------------------------------------------------------------------------------------------------------------------------
FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE
---------------------------------------------------------------------------------------------------------------------------------------
 18 | WARNING | Line exceeds 80 characters; contains 93 characters
---------------------------------------------------------------------------------------------------------------------------------------

Time: 207ms; Memory: 10MB

Steps to reproduce

Please execute this command on the module:
phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml,twig navigation

πŸ“Œ Task
Status

Closed: works as designed

Version

1.0

Component

Code

Created by

πŸ‡΅πŸ‡­Philippines roberttabigue

Live updates comments and jobs are added and updated live.
  • Coding standards

    It involves compliance with, or the content of coding standards. Requires broad community agreement.

Sign in to follow issues

Comments & Activities

  • Issue created by @roberttabigue
  • Status changed to Closed: works as designed 11 months ago
  • πŸ‡ͺπŸ‡ΈSpain ckrina Barcelona

    @roberttabigue thanks for submitting this issue, but we're using this module to create a prototype and we're not focused on coding standards for yet. We're using this module only to run user tests for now.
    We'll check coding standards in the future because the code base will completely change in the next weeks, so closing because the code works for the needs we have now.

Production build 0.69.0 2024