- Issue created by @John Franklin
- Status changed to Needs review
7 months ago 5:47pm 2 June 2024 - 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU
Works for me.
The change from "NNN bits" to "NNN" is a super minor inconvenience and doesn't justify keeping the current code.
(I'd set RTBC if I tested -- but I didn't.)
- First commit to issue fork.
- Status changed to RTBC
7 months ago 7:22am 3 June 2024 - 🇮🇳India mitthukumawat
I have tested the changes after phpcs fixes. These looks fine. It has two other issues as below that also have been addressed. Moving to RTBC.
FILE: key_asymmetric/src/Plugin/KeyType/AsymmetricPublicKeyType.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 197 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines -------------------------------------------------------------------------------------------------------------------------------------- FILE: key_asymmetric/src/Plugin/KeyType/AsymmetricPrivateKeyType.php -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 172 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines --------------------------------------------------------------------------------------------------------------------------------------
-
John Franklin →
committed 1ab72dda on 1.x
Issue #3452048 by John Franklin, mitthukumawat: PHPCS fixes
-
John Franklin →
committed 1ab72dda on 1.x
- 🇺🇸United States John Franklin
Good catch @mitthukumawat! Thanks for the patch!
- Status changed to Fixed
7 months ago 2:38pm 3 June 2024 Automatically closed - issue fixed for 2 weeks with no activity.