Created on 2 June 2024, 7 months ago
Updated 17 June 2024, 6 months ago

A handful of changes to address issues raised by phpcs.

📌 Task
Status

Fixed

Version

1.1

Component

Code

Created by

🇺🇸United States John Franklin

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @John Franklin
  • Status changed to Needs review 7 months ago
  • 🇺🇸United States John Franklin

    MR created

  • 🇳🇱Netherlands roderik Amsterdam,NL / Budapest,HU

    Works for me.

    The change from "NNN bits" to "NNN" is a super minor inconvenience and doesn't justify keeping the current code.

    (I'd set RTBC if I tested -- but I didn't.)

  • First commit to issue fork.
  • Status changed to RTBC 7 months ago
  • 🇮🇳India mitthukumawat

    I have tested the changes after phpcs fixes. These looks fine. It has two other issues as below that also have been addressed. Moving to RTBC.

    FILE: key_asymmetric/src/Plugin/KeyType/AsymmetricPublicKeyType.php
    --------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------------------------
     197 | ERROR | The array declaration extends to column 99 (the limit is 80). The array content should be split up over multiple lines
    --------------------------------------------------------------------------------------------------------------------------------------
    
    
    FILE: key_asymmetric/src/Plugin/KeyType/AsymmetricPrivateKeyType.php
    --------------------------------------------------------------------------------------------------------------------------------------
    FOUND 1 ERROR AFFECTING 1 LINE
    --------------------------------------------------------------------------------------------------------------------------------------
     172 | ERROR | The array declaration extends to column 89 (the limit is 80). The array content should be split up over multiple lines
    --------------------------------------------------------------------------------------------------------------------------------------
    
  • Pipeline finished with Skipped
    7 months ago
    #190007
  • 🇺🇸United States John Franklin

    Good catch @mitthukumawat! Thanks for the patch!

  • Status changed to Fixed 7 months ago
  • 🇺🇸United States John Franklin

    Fixed.

  • Automatically closed - issue fixed for 2 weeks with no activity.

Production build 0.71.5 2024