Bring no (empty) results text into alignment with D8 and/or make customizable

RTBC for the improvement in #2. Perhaps the other parts should be split-off to get this merged?

I have added a new template suggestion for search 404 results. We can find a name suggestion as item-list--search-results--search404.html.twig. And the default template for the search results is item-list--search-results.html.twig.

The merge request !22 is for 8.x-1.x and merge request !23 for 2.x branch.

@mitthukumawat thanks! Two things:
The MR!22 adds a lot of unrelated changes, I think that's unwanted.
I think the original hook suggestions from core:

+          'item_list__search_results__' . $plugin->getPluginId(),
+          'item_list__search_results',

should be kept to use the core implementations by default.

Is there a reason for removing it? That may break sites.

The MR!22 adds a lot of unrelated changes, I think that's unwanted.

It is for 8.x-1.x branch. It is showing unrelated changes because of this branch is behind many commits. We can either ignore this.

Is there a reason for removing it? That may break sites.

Yes, actually this hook suggestion is for only search 404.

          'item_list__search_results__' . $plugin->getPluginId(),
          'item_list__search_results',

These are default hook available for all core search results pages.
What do you think, should we keep the core hooks as default for search 404 as well, from where developers can customise accordingly?

It is for 8.x-1.x branch. It is showing unrelated changes because of this branch is behind many commits. We can either ignore this.

Yes I know, but in that case you typically don't add unrelated changes, just the changes relevant to this issue.

Re your 2nd question: I think the patch in #2 does it right?

No, after applying patch #2 ✨ Bring no (empty) results text into alignment with D8 and/or make customizable Needs work , only one hook suggestion showing from core.
This is because it cannot suggest multiple hooks from one build.
Added screenshot of the results after adding below hook suggestion:

          'item_list__search_results__' . $plugin->getPluginId(),
          'item_list__search_results',
          'item_list__search_results__search404',
          'item_list__search_results__search404__' . $plugin->getPluginId(),

Sorry @mitthukumawat - I thought the patch was in hook_theme_suggestions()! Didn't see it was written into the render array, which is of course wrong. I never saw that kind of implementation before.

So I got this issue entirely wrong, please ignore my comments before.

Merged to 2.x branch

jijojoseph_zyxware → closed merge request !22

Automatically closed - issue fixed for 2 weeks with no activity.