Contrib.social

Remove unnecessary service navigation.menu.invalidator

Open on Drupal.org →
Created on 16 April 2024, 8 months ago
Updated 1 May 2024, 8 months ago

As suggested by catch in ✨ Add the new Navigation to core as an Experimental module Fixed , navigation.menu.invalidator service is overkill and it is not actually needed because we already have implemented hook_menu_{insert/update/delete} to keep the SystemMenuNavigationBlock deriver up to date.

These hooks might be replaced by cache tags once 📌 Allow plugin derivers to specify cache tags for their definitions Postponed: needs info is fixed.

📌 Task
Status

Fixed

Version

1.0

Component

Code

Created by

🇪🇸Spain plopesc Valladolid

Live updates comments and jobs are added and updated live.
Sign in to follow issues

Merge Requests

Comments & Activities

  • Issue created by @plopesc
  • Merge request !253Issue #3441190: Remove unnecessary service navigation.menu.invalidator → (Merged) created by plopesc
  • Pipeline finished with Failed
    8 months ago
    Total: 255s
    #147635
  • Pipeline finished with Success
    8 months ago
    Total: 254s
    #147641
  • Status changed to Needs review 8 months ago
  • Comment 8 months ago →
    🇪🇸Spain plopesc Valladolid

    MR ready for review

  • Status changed to RTBC 8 months ago
  • Comment 8 months ago →
    🇮🇳India mitthukumawat

    Service navigation.menu.invalidator removed when pull above changes locally and the navigation also working awesome after that.
    Found few coding standard issues, that would be addressed in future as per Fix the issues reported by phpcs 📌 Fix the issues reported by phpcs Closed: works as designed .

  • Pipeline finished with Skipped
    8 months ago
    #149288
  • First commit to issue fork.
  • Pipeline finished with Skipped
    8 months ago
    #149289
  • Comment 8 months ago →
    System Message
  • Status changed to Fixed 8 months ago
  • Comment 8 months ago →
    🇨🇦Canada m4olivei Grimsby, ON

    This is great! Thanks. Merged to 1.x.

  • Comment 8 months ago →
    System Message

    Automatically closed - issue fixed for 2 weeks with no activity.

  • Pipeline finished with Failed
    4 months ago
    Total: 52s
    #271592
  • Pipeline finished with Failed
    4 months ago
    Total: 51s
    #271696
  • Pipeline finished with Skipped
    3 months ago
    #287621
  • Pipeline finished with Success
    about 2 months ago
    #324102
  • Pipeline finished with Success
    about 2 months ago
    Total: 329s
    #324108
  • Pipeline finished with Success
    about 1 month ago
    Total: 275s
    #332371
  • Pipeline finished with Success
    about 1 month ago
    Total: 158s
    #332374
  • Pipeline finished with Failed
    20 days ago
    Total: 49s
    #356547
  • Pipeline finished with Success
    20 days ago
    Total: 462s
    #356575
contrib.social Blog FAQ Discussions
Production build 0.71.5 2024