Add permission to view the block

Created a new MR.

Added a new permission to view information about git in the block.

Note that we didn't use the permission before. So, merging changes will hide the block for all users (except admins).
in that case, we can implement an update hook to add the permission to both Anonymous & Authenticated roles.
Let me know what you think about it.

thanks

Thanks, that makes sense.

Please create an update hook and add the permissions, that is certainly needed :)

Done. Implemented an update hook.

Hi, I installed !MR9 on my local (D9 site) and got this error when trying to place the Info block.

Error: Class "eiriksm\GitInfo\GitInfo" not found in include() (line 14 of /app/web/modules/contrib/git_info/src/GitInfo.php)

Hi there,

you should install dependencies for the module.
or you can install the module via composer.

Hi again, ok I was able to get this working by doing the following extra steps ..

* ran composer require 'drupal/git_info:^2.0' (install latest version with all dependencies)
* delete the git_info module folder (created by previous command)

Then run normal issue commands to clone the git_info module (git clone https://git.drupalcode.org/project/git_info.git) and checkout the MR branch. After that install git_info module (in GUI) and run tests.

Please let me know if you think I could have done this in a better way.

Testing : The Info block places on the page, with no errors as admin. The block is hidden when viewing the page as unauthenticated user.

Hi @schillerm,

your testing is incorrect.

for new sites/projects, you should manage permissions to view the block on the permission page.
for the existing project (with already installed and enabled module), the visibility of the block should not be changed after applying changes from the current issue.

Hi @eiriksm,

any updates?

Thanks everyone ♥️🎉

Automatically closed - issue fixed for 2 weeks with no activity.