- Issue created by @chrisfromredfin
- First commit to issue fork.
- ๐ฎ๐ณIndia saket-001
skt-001 โ made their first commit to this issueโs fork.
- @skt-001 opened merge request.
- Status changed to Needs review
over 1 year ago 6:37am 11 April 2023 - Status changed to Needs work
over 1 year ago 12:44am 10 May 2023 - ๐บ๐ธUnited States chrisfromredfin Portland, Maine
The MR appears to only contain changes to the bundle.css but not the source file - should be changes to both.
- First commit to issue fork.
- last update
over 1 year ago 65 pass - last update
over 1 year ago 65 pass - Status changed to Needs review
over 1 year ago 11:15am 12 May 2023 - ๐ฎ๐ณIndia Kaustab_Roy
Removed the margin top from project__logo img & added on parent div.
- ๐ฌ๐งUnited Kingdom schillerm
Hi, reviewed this MR and all looks good. +1 for RBTC.
- Status changed to RTBC
over 1 year ago 6:59am 17 May 2023 - ๐ฉ๐ฐDenmark ressa Copenhagen
Thanks @Kaustab_Roy. The patch works great, and the bottom 20px of logos are no longer cut off.
1.1 List, before
1.2 List, fixed
2 Project page
Another thing: First, I just tried to download and apply the plain diff patch manually. But it looks like only the two Svelte files
Image.svelte
andProject.svelte
are included in the MR367. So I had to cd into svelte folder and runyarn install
andyarn build
to generate the CSS.Anyway, cloning dev-version and applying Code >> Check out branch commands from the MR worked well.
- Status changed to Fixed
over 1 year ago 2:28pm 17 May 2023 - last update
over 1 year ago 60 pass, 2 fail -
chrisfromredfin โ
committed 7345cde4 on 1.0.x authored by
skt-001 โ
Issue #3348872 by Kaustab_Roy, skt-001, notSOSolo, ressa,...
-
chrisfromredfin โ
committed 7345cde4 on 1.0.x authored by
skt-001 โ
- ๐บ๐ธUnited States chrisfromredfin Portland, Maine
Thanks everyone, so great to see some new names!
Automatically closed - issue fixed for 2 weeks with no activity.