๐Ÿ‡ฎ๐Ÿ‡ณIndia @saket-001

Account created on 31 May 2022, about 2 years ago
#

Recent comments

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

still there is error in MasonryService.php file .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch applied successfully and fixes the all PHPCS error.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch applied successfully fixes all PHPCS error moving status to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

applied the patch but there is still an error sharing the SS.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

successfully applied for D10 also sharing the SS as also mentioned in #4 MR !2 looks fine so changing the status.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch #2 fixes all the PHPCS error so moving status to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR!1 fixes all the PHPCS error moving Status to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

thanks @dineshkumarbollu for the patch. Applied successfully and fixes all PHPCS error.
sharing the SS.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

for D9 changing the info.yml file create an issue while applying the MR

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch applied successfully and fixes all PHPCS error. so moving status to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR!7 applied successfully and fixes all PHPCS error. sharing the SS.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

Applied patch successfully all PHPCS error got fixed sharing the SS.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch #38 is working fine. also mentioned in #39 so moving status to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR!2 applied successfully and it resolve all the PHPCS error but still there is some warning of whitespaces while applying .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

there is no issue persist in any updated version of 7.x and for 7.x #19 fixes the issues. RTBC+1

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

after applying the patch there is no PHPCS error is found sharing the SS. thanks @ rajneeshb for the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

after installation i didn't see any PHPCS error .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

Hi @urvashi_vora patch is good but its not fixes all the standard issues so moving status to Needs Work.
Sharing the SS .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR !1 applied successfully and it fixes all the PHPCS error sharing the SS and moving status to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

Applying the patch #7 not remove all the standrad error till i m moving status to needs work.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch #5 applied successfully compatible with my version sharing the SS.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

Moving to RTBC as patch applied successfully and worked fine .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

changing status to RTBC as patch #6 fixes all the PHPCS errors and also changes according to #5. thanks.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

Applied the patch #5 its work fine remove all PHPCS error and changes are there as mentioned in #3

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

clearly patch not fixes the issue so changing status to needs work.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

@Ashutosh Ahirwal thanks for the patch and also its working fine but there is just some warning for whitespaces .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

Patch #4 is applied successfully and fixes the all phpcs issues i.e also mentioned in #5 so i moving this to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

@ Ashutosh Ahirwal there is some issues in patch while applying the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch applied successfully and after that no PHPCS errors or warning sharing the SS after applied patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch Applied successfully and description got added. sharing the SS .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

applied the patch still there is error.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

uploaded the patch for the issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

skt-001 โ†’ made their first commit to this issueโ€™s fork.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

No error is there but there is some warning after the patch applied for version 9.x

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

Applied MR!15 updating according to .md template

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR !10 fixes the all PHPCS issue and also changes are mention as in #9.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

applying the MR2 create the readme.md file.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch #6 working fine for me. changing status to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

moving to rtbc as share the SS after applying the patch.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch #2 is working fine.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

not working for drupal version 10.1x.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR 6 is working fine with correct numbering i moving status to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

Applying patch #3 it solve the phpcs issue .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

applying patch #2 still the issue is there so i changing status to need work.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

changing status to RTBC

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

applying patch #7 it fixes the all minor phpcs issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

after applying the patch #41 issue still persist so i change the status need work & sharing the SS.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR !1 looks fine and it is converting the same content README.txt into READ.md.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

As mention in issue the patch #75 works fine but no links are there for new entity.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

As mentioned in comment #95 patches work as expected and screeshots available in #94 for 10.1.x . so, i move this issue to RTBC.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR !1 looks fine for me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

After applying the MR !3 hook_help method is there.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

applying the patch #17 works as remainder message.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR !2 looks fine for me.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

patch #2 fixes the phpcs coding standard issue.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

reviewed the MR 5 & its look fine.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

MR 4 is working fine .

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

after the applying the patch #2 there is no phpcs error. it looks good

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

under comment #33 i had applied both failed and pass patches of #34. Adding screenshot for both the patches.

๐Ÿ‡ฎ๐Ÿ‡ณIndia saket-001

i have reviewed the merge request mention in comment no. #4 and it is converting exactly the same content readme.txt into readme.md

Production build 0.69.0 2024