Fix the issues reported by phpcs

FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/leaflet_maptiler.links.menu.yml ------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------------- 12 | ERROR | [x] Expected 1 newline at end of file; 2 found ------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/leaflet_maptiler.routing.yml ---------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------- 19 | ERROR | [x] Expected 1 newline at end of file; 2 found ---------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/config/install/leaflet_maptiler.settings.yml -------------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE -------------------------------------------------------------------------------------------------------------------------------------- 4 | ERROR | [x] Expected 1 newline at end of file; 0 found -------------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY -------------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/README.txt ---------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------- 19 | ERROR | [x] Expected 1 newline at end of file; 0 found ---------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ---------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/modules/leaflet_maptiler_token/README.txt ----------------------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES ----------------------------------------------------------------------------------------------------------------------------------- 4 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters 10 | WARNING | [ ] Line exceeds 80 characters; contains 227 characters 12 | WARNING | [ ] Line exceeds 80 characters; contains 92 characters 13 | WARNING | [ ] Line exceeds 80 characters; contains 93 characters 15 | ERROR | [x] Expected 1 newline at end of file; 0 found ----------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ----------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/modules/leaflet_maptiler_token/src/TokenOperations.php ------------------------------------------------------------------------------------------------------------------------------------------------ FOUND 1 ERROR AND 4 WARNINGS AFFECTING 5 LINES ------------------------------------------------------------------------------------------------------------------------------------------------ 77 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 78 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 84 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 85 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 138 | ERROR | The array declaration extends to column 103 (the limit is 80). The array content should be split up over multiple lines ------------------------------------------------------------------------------------------------------------------------------------------------ FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/src/Form/LeafletMaptilerSettingsForm.php ---------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 1 WARNING AFFECTING 1 LINE ---------------------------------------------------------------------------------------------------------------------------------- 13 | WARNING | The class short comment should describe what the class does and not simply repeat the class name ---------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/src/LibraryOperations.php ------------------------------------------------------------------------------------------------------------------- FOUND 1 ERROR AFFECTING 1 LINE ------------------------------------------------------------------------------------------------------------------- 59 | ERROR | [x] Case breaking statements must be followed by a single blank line ------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY ------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/src/MaptilerLeafletServiceDecorator.php --------------------------------------------------------------------------------------------------------------------------------- FOUND 2 ERRORS AND 1 WARNING AFFECTING 3 LINES --------------------------------------------------------------------------------------------------------------------------------- 16 | WARNING | [ ] The class short comment should describe what the class does and not simply repeat the class name 38 | ERROR | [ ] Doc comment for parameter $leaflet_service does not match actual variable name $language_manager 87 | ERROR | [x] Short array syntax must be used to define arrays --------------------------------------------------------------------------------------------------------------------------------- PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY --------------------------------------------------------------------------------------------------------------------------------- FILE: /Users/sahil.goyal/Documents/MySites/10.1.x/drupal/modules/contrib/leaflet_maptiler/src/LeafletOperations.php ----------------------------------------------------------------------------------------------------------------------------------------- FOUND 0 ERRORS AND 2 WARNINGS AFFECTING 2 LINES ----------------------------------------------------------------------------------------------------------------------------------------- 59 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead 60 | WARNING | t() calls should be avoided in classes, use \Drupal\Core\StringTranslation\StringTranslationTrait and $this->t() instead ----------------------------------------------------------------------------------------------------------------------------------------- Time: 134ms; Memory: 10MB

Comments & Activities

Issue created by @sahil.goyal
Status changed to Needs review almost 2 years ago12:09pm 8 February 2023
Comment almost 2 years ago →
🇮🇳India sahil.goyal
Resolving all the coding standard issues/warning in this patch, Please review.
Status changed to RTBC almost 2 years ago1:28pm 8 February 2023
Comment almost 2 years ago →
🇮🇳India saket-001
after the applying the patch #2 there is no phpcs error. it looks good
Comment almost 2 years ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
Status changed to Needs work 6 months ago5:03pm 18 June 2024
Comment 6 months ago →
🇧🇪Belgium bernardopaulino Brussels
The patch #2 can no longer be applied. Some of the fixes in this patch have already been committed (see https://git.drupalcode.org/project/leaflet_maptiler/-/commit/5a6c62caf94...). We might need to re-run phpcs to check if there are still errors.
First commit to issue fork.
Merge request !4Issue #3340237: fixed the phpcs. → (Open) created by Unnamed author
Status changed to Needs review 6 months ago10:22am 19 June 2024
Comment 6 months ago →
🇮🇳India atul_ghate
Status changed to Needs work 6 months ago10:28am 19 June 2024
Comment 6 months ago →
🇧🇪Belgium bernardopaulino Brussels
@atul_ghate thanks for the new merge request. However, there are conflicts with the latest changes in the module. I am sending this back to rework.
Status changed to Needs review 6 months ago1:02pm 19 June 2024
Comment 6 months ago →
🇮🇳India atul_ghate
Hi @bernardopaulino i have resolved conflict please review.
Status changed to Needs work 6 months ago1:20pm 19 June 2024
Comment 6 months ago →
🇧🇪Belgium bernardopaulino Brussels
Thanks a lot @atul_ghate, the patch seems ok. However, I would like the patch to be ported to the new version 2.x. Also, maybe we could rename the README.txt to README.md in the sub-module leaflet_maptiler_token as we did for the main README of the project (see https://www.drupal.org/project/leaflet_maptiler/issues/3339970 📌 Replace README.txt with README.md Fixed ).
For now I will keep this as Needs work.
Comment 6 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
For the 2.x branch is necessary to create a new issue, since in this issue is not possible to create an issue fork for that branch.
Comment 6 months ago →
🇮🇹Italy apaderno Brescia, 🇮🇹
(This happens because the new branch has been created after this issue was created.)

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!4Fix the issues reported by phpcs
Open

Comments & Activities

Fix the issues reported by phpcs

Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Merge Requests

!4Fix the issues reported by phpcsOpen

Comments & Activities

!4Fix the issues reported by phpcs
Open