🇧🇪Belgium @bernardopaulino

Not sure if this is the right issue to leave this remark but, when I enable the option to expose the form in a block my facets are not rendered. Before this improvement the facets were properly rendered.
Should we open a new issue or can this problem still be reviewed and fixed here?

Here is a patch to fix the issue following the proposed solution.

bernardopaulino → created an issue.

Here is a patch that overrides the methods defineDefaultProperties() and defineTranslatableProperties() to make the property 'error_message' translatable.

bernardopaulino → created an issue.

Here is a patch which implements the same same logic as seen in the menu_link module.

bernardopaulino → created an issue.

I've tested the MR and it looks good to me! I will commit this, thanks!

Thanks a lot @atul_ghate, the patch seems ok. However, I would like the patch to be ported to the new version 2.x. Also, maybe we could rename the README.txt to README.md in the sub-module leaflet_maptiler_token as we did for the main README of the project (see https://www.drupal.org/project/leaflet_maptiler/issues/3339970 📌 Replace README.txt with README.md Fixed ).
For now I will keep this as Needs work.

Thank you for the patch. I commited in the new release 2.0.0

Fixed in release 2.0.0

Created a new patch to update the hook_updateN version to follow drupal 10 standards.

@atul_ghate thanks for the new merge request. However, there are conflicts with the latest changes in the module. I am sending this back to rework.

The patch #2 can no longer be applied. Some of the fixes in this patch have already been committed (see https://git.drupalcode.org/project/leaflet_maptiler/-/commit/5a6c62caf94...). We might need to re-run phpcs to check if there are still errors.

I've implemented a temporary patch which avoids setting the 'required' property as true for the first element in a multi-value field. This is because the parent field already has the 'required' property set and drupal will perform the validation as expected. The current downside of this fix is a generic error message and a red border displaying around all elements, and not just the first one.

For a more robust solution, I propose we improve the doValidateForm() method in the \Drupal\Core\Form\FormValidator class. This way, we can have a more specific and clear validation error message and possibly a cleaner way to handle the required attribute for multi-value fields.

bernardopaulino → created an issue.

Thank you so much @broon for your feedback. I trully appreciate it.

I am uploading a new patch that incorporates your suggestion. This patch introduces a new option titled "Accessibility First" within the filter configurations. Additionally, I've ensured that it uses the same CSS styles as the "Extra Element" option.

I hope this approach aligns better with the requirements.

With my changes I introduced a new issue where the URL query string was not being updated when the Datepicker was cleared. I fixed the datepicker.js and now the facet value is being properly removed from the query string.

I found out that the submitted date is also lost when using the Datepicker widget. Apparently the variable $default in the build function is not used after grabbing the selecting date from the active items. I made a patch that should fix the issue.

Here is a new patch to fix deprecated RequestEvent::isMasterRequest() with RequestEvent::isMasterRequest().

UPDATE to my last comment #9: The issue has been introduced when using the following patch for page_manager -> https://www.drupal.org/project/page_manager/issues/2858877#comment-15042342 ✨ Allow for block visibility rules Needs review . Before I was using the patch https://www.drupal.org/project/page_manager/issues/2858877#comment-14787260 ✨ Allow for block visibility rules Needs review and it worked fine so I will keep that one for now.

Applying the patch #7 I get the error mentioned in comment #2:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: You have requested a non-existent service "page_manager.condition_access_resolver". in Drupal\Component\DependencyInjection\Container->get() (line 157 of /var/www/html/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php).

I am currently running D9.5.10, page_manager 8.x-4.0-rc2 and panels 8.x-4.7.

Thank you Orkut for your feedback.
Since the compatibility with Leaflet 10 is now fixed, I will then change the status of this issue to fixed.

Thank you all for the support :)

New patch that should replace the deprecated class GetResponseEvent with RequestEvent.

bernardopaulino → created an issue.

I had to remove the modules contrib folder and run composer install again. After that everything seems to be working fine.
I will close the issue again.

I am trying to upgrade linkit module from 6.0.0-beta4 to 6.0.0 and I have this error when running drush updb. I was using a patch from the same issue https://www.drupal.org/project/linkit/issues/2712951 ✨ Linkit for Link field Fixed but it was no longer applied in the version 6.0.0 so I removed it.
Apparently, the problem seems to happen when running database updates for the block_class module, more specifically in the hook block_class_update_20001() where I get the following error:
[notice] Update started: block_class_update_20001
[error] Invalid data type in config linkit.schema, found in file modules/contrib/linkit/config/schema/linkit.schema.yml: Duplicate key "field.widget.settings.linkit" detected at line 138 (near "# Schema for the Linkit formatter.").
[error] Update failed: block_class_update_20001
[error] Update aborted by: block_class_update_20001.

I believe this issue still needs to be looked at. The issue seems to be triggered by the block_class, however this needs to be fixed in the linkit module.

Re-roll for drupal 10.1.1

My last comment #39 is false. I tested again and I have duplicated values.

I could not reproduce this issue on my D10.1.1 installation.

Automated D10 compatibility fixes from patch #2 have been committed to release 1.0-alpha4. It also includes the missing composer.json file. I will close this issue for now.

This is a duplicate of https://www.drupal.org/project/wba_menu_link/issues/3299476 📌 Automated Drupal 10 compatibility fixes Fixed which has already fixed in version 1.0-rc4.

Patch in #5 has been committed in version 1.0-rc4 which fixes Drupal 10 compatibility issues.

Orkut,
Concerning your comment #7, I couldn't reproduce the issue. I checked the decorator MaptilerLeafletServiceDecorator defined in the leaflet_maptiler module in the version 8.x-1.0-beta12 and it seems to comply with same arguments as the decorated service LeafletService when using the leaflet version 10.0.16.

Can you please update your leaflet_maptiler and leaflet modules to the latest versions and check if the error persists?

Thank you!

Patch from #2 committed in version 8.x-1.0-beta12.

I've merged the PR provided in #2 so that we are able to download the leaflet 10.x.
I still didn't have time to look at the issue from #7 so for now the status remains as "needs work".

Removed extra enter from the template to comply with coding standards.

Here is a patch that should improve accessibility when using extra element option in the onomasticon text format filter.

bernardopaulino → created an issue.