- Issue created by @elgandoz
- @elgandoz opened merge request.
- 🇹🇷Turkey orkut murat yılmaz Istanbul
Hello all,
I've tried to apply @elgandoz's MR as a patch, but it didn't work at all.
I'm changing the status of the issue as "needs work".
Best,
Orkut - Status changed to Needs work
almost 2 years ago 5:12pm 22 June 2023 - Status changed to RTBC
almost 2 years ago 8:37am 23 June 2023 - 🇹🇷Turkey orkut murat yılmaz Istanbul
Hello again,
I've reinstalled my D10.1.0 environment and then leaflet module too. After that, I manually downloaded the leaflet_maptiler module files and implemented the @elgandoz's code on the module. This time module is installed without an error. Now I'm testing my Maptiler connection, I'll report about it, if I face an error.
Thank you @elgandoz for your contribution. I think that the MR deserves an approval and merge. So that, I'm changing the status as RTBC:)
Best,
Orkut - Status changed to Needs work
almost 2 years ago 4:12pm 2 July 2023 - 🇹🇷Turkey orkut murat yılmaz Istanbul
I've tested with my Maptiler API Key today and then created a content type with a geofield. When I go to manage form display settings of that content type, I choose "leaflet map" as the display widget and then I receive a WSOD with the error code which I paste below:
TypeError: Drupal\leaflet_maptiler\MaptilerLeafletServiceDecorator::__construct(): Argument #9 ($cache) must be of type Drupal\leaflet_maptiler\CacheBackendInterface, Drupal\Core\Cache\DatabaseBackend given, called in /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php on line 259 in Drupal\leaflet_maptiler\MaptilerLeafletServiceDecorator->__construct() (line 55 of /var/www/html/web/modules/contrib/leaflet_maptiler/src/MaptilerLeafletServiceDecorator.php).
Unfortunately, I'm switching the issue's status as "needs work".
Best,
Orkut - 🇧🇪Belgium bernardopaulino Brussels
I've merged the PR provided in #2 so that we are able to download the leaflet 10.x.
I still didn't have time to look at the issue from #7 so for now the status remains as "needs work". - 🇧🇪Belgium bernardopaulino Brussels
Patch from #2 committed in version 8.x-1.0-beta12.
- Issue was unassigned.
- Status changed to Needs review
almost 2 years ago 2:42pm 13 July 2023 - 🇧🇪Belgium bernardopaulino Brussels
Orkut,
Concerning your comment #7, I couldn't reproduce the issue. I checked the decorator MaptilerLeafletServiceDecorator defined in the leaflet_maptiler module in the version 8.x-1.0-beta12 and it seems to comply with same arguments as the decorated service LeafletService when using the leaflet version 10.0.16.Can you please update your leaflet_maptiler and leaflet modules to the latest versions and check if the error persists?
Thank you!
- Status changed to RTBC
almost 2 years ago 6:57am 14 July 2023 - 🇹🇷Turkey orkut murat yılmaz Istanbul
Hello again,
After a clean install, it worked smoothly.
Thanks for everything.
Best,
Orkut - Status changed to Fixed
almost 2 years ago 1:44pm 25 July 2023 - 🇧🇪Belgium bernardopaulino Brussels
Thank you Orkut for your feedback.
Since the compatibility with Leaflet 10 is now fixed, I will then change the status of this issue to fixed.Thank you all for the support :)
- Status changed to Fixed
almost 2 years ago 1:45pm 25 July 2023