Canberra
Account created on 23 August 2010, almost 14 years ago
#

Merge Requests

More

Recent comments

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Hey @ressa, you can check in the Developer Console, Under Network and filtering by Images: high resolution tiles (aka "retina", from macos first high resolution displays) are loaded with the suffix "@2x.[ext]". If you do have a high pixel density display (most current mobile phones/laptops do nowadays) you can also see the map significantly less blurry.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

I swapped title:encoded for title-encoded and added the token info.
The resulting token is [current-page:title-encoded], but I was wondering if it's any better provide it as utility in order to encode any token, eg [any-string-token:encoded].
Any thoughts from the maintainers?

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

This is actually useful within Token and it's not only related with Social Media issue.
I'm using it with TextImage and this patch works as it should.
Only 2 issues:
- the "titleencode" token doesn't appear in the available tokens
- the naming could be improved matching the other patterns, something like "title:encoded"

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

BTW, Layout builder get exported almost flawlessly with the core patch provided in the the issue above. Requires a cache-clear after the tome:install. Tested on Drupal 10.1

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

@bserem I use https://www.drupal.org/project/tome_netlify β†’ for this, which relies on core "Contact" module. Obviously it works only on Netlify, but it doesn't require a php server with a mail system configured, which is defeats the purpose of static file generation IMHO.
Alternatively you could use a 3rd party service like https://formspree.io/.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

I can access the examples of the slots, eg: $pluginDefinition['slots'][$slot_name]['examples'][0], but ATM I don't know how to render twig blocks in dab/src/Controller/DabComponentController.php: $markup = $this->twig->renderInline($twigTemplate, $variables);

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Hey guys, sorry to intrude, I'm not on the working group and I know the module it's for researching UX improvements but I was curious to check the current state.
After using the navigation bar for a short time I found this issue problematic.

I think @bnjmnm is raising a valid point that there could be existing menu links where it's necessary to be able to access the parent link.

I believe those menu items are more than a few and quite prominent: with the current behaviour I cannot directly access the pages to enable a new theme (or see the available ones), enable new modules (as before) and user management list, block placement. The only way is to access a subpage and then using the breadcrumb, requiring multiple clicks in different areas of the screen.
I found particularly difficult accessing the Block Layout page, given the breadcrumb structure. Those are the bread and butter for every site-builder/manager, concerning the core modules only. There will be a lot more of those with many contrib modules using the long established menu pattern (like admin tools for clearing the cache or workbench, just to mention 2 I had installed).

The "overview" option could sort of fix it but at the same time it seems wrong adding yet another set of menu items (Drupal with many modules has notoriously way too many) and adding yet another click for something that is already available, just not clickable. IMHO it's just a workaround for a wrong design.
EG: for the Block Layout link, you would need an "Overview" (for the Block Layout) under another "Overview" (for Structure).
Also, in few cases using Gin Toolbar I had to write code to remove the overview since the end users only had few permissions with few menu items and most of the time the extra link wasn't making any sense and it was just confusing the client (with Gin Toolbar you can actually click both the top level icon or the sub-menu "title", making the overview redundant). I really like to provide the most simple interface for the end user, the less the better.

Lastly, when the toolbar is collapsed, I found it odd that some links open a sub-menu, while others go to a page (like the Content/File/Help). The behaviour has no immediate visual clue and is not predictable at glancing it, not until you hover the cursor. And even then I found myself quickly going to an item and immediately clicking it, only to have the submenu disappear. But maybe I'm biased after having used Gin Toolbar for a while, although there's a lot of fast clickers out there :)

Are you sure not making the top level links clickable is the right path? I understand it has been user tested (maybe in isolation) but at the same time I believe that the behaviour should also match the way admin pages are currently organised.

Sorry about the critic, I'm just very interested in this project and I wanted to provide a feedback about this particular topic.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

That was the fastest fix I haver had on Drupal.org! I wanted to have a look at it but it is already done!
Thanks for sorting it out this quick.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

I push the commit on the right branch.

If you need this module now in D10, add the gitlab repo in the repositories section of your project, before the D8 packages:

  {...},
  "repositories": [
    {
        "type": "git",
        "url": "https://git.drupalcode.org/issue/show_email-3289599.git",
        "no-api": true
    },
    {
      "type": "composer",
      "url": "https://packages.drupal.org/8"
    },
    {...}
  ],

Then require the module with version dev-[branchname]:
composer require 'drupal/show_email:dev-3289599-automated-drupal-10'

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

For those who need this module now in D10, add the gitlab repo in the repositories section of your project, before the D8 packages:

  {...},
  "repositories": [
    {
        "type": "git",
        "url": "https://git.drupalcode.org/issue/social_sharing-3289791.git",
        "no-api": true
    },
    {
      "type": "composer",
      "url": "https://packages.drupal.org/8"
    },
    {...}
  ],

Then require the module with version dev-[branchname]:
composer require 'drupal/social_sharing:dev-3289791-automated-drupal-10'

If you want to add a new/custom platform, copy one from the module ShareService folder (eg. web/modules/contrib/social_sharing/src/Plugin/ShareService/Facebook.php) and place it in your module following the same folder pattern, rename and adjust accordingly (eg. web/modules/custom/my_module/src/Plugin/ShareService/Instagram.php)

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Thanks for the patch, I had the same patch and this works nice form me, using D10.1.6 and tmgmt 8.x-1.15.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

When using this patch I'm getting this error:
Deprecated function: trim(): Passing null to parameter #1 ($string) of type string is deprecated in Drupal\status_messages\Form\StatusMessages->submitForm() (line 60 of /var/www/html/web/modules/contrib/status_messages/src/Form/StatusMessages.php)

The settings form won't save, causing the status messages to disappear very quickly.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

I'm starting a new project in D10.1 where I would really like to have facets with AJAX (Facet 3-dev BEF 6).
I followed the steps roughly indicated here https://www.drupal.org/project/facets/issues/3353991 πŸ› How to make AJAX work with facets 3? (issue with isRenderedInCurrentRequest) Active but I'm now getting an error:
Error: Object of class Drupal\facets\Entity\Facet could not be converted to string in Drupal\views\Plugin\views\filter\FilterPluginBase->prepareFilterSelectOptions() (line 1344 of core/modules/views/src/Plugin/views/filter/FilterPluginBase.php).
Are those steps corrects? I couldn't find any other guide.
I just would like to know at the current state if it's better to use v2 or v3, considering that AJAX would be great.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

The Login screen remains unchanged

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Epic!! I was about to do it as well but Gitpod wouldn't start.
Applied the patch on 1.0.x-dev via composer-patches, the dialog load and no error in the logs.
Looks good to me. Thank you!

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

The above example is almost right but there's a typo. It should be:
plugin_id ? 'block--' ~ plugin_id|replace({"_": "-", ":": "--"})|clean_class,
This should really be fixed in the main theme since all the layout builder blocks do not print any class.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

I'm trying to use the provided patch but using it with cweagans/composer-patches, composer hangs and never finishes the process. This doesn't happen with any of the other patches i've got in the same build. Is this patch working for any of you?

Meanwhile I'm using the workaround provided in #7, thank you!

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Didn't _utsavsharma exlpain it? He addressed the Custom Command Failure: https://www.drupal.org/pift-ci-job/2732769 β†’
the array keys were repeated.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

On GitLab it says "Missing CI config file. "

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

GitLab is playing funny today. And I made a mess:

  1. MR!26 - 3378680-json-malformed: this is the good one
  2. MR!25 - arrow-json-malformed: Initial draft but GitLab doesn't let me close it
  3. branch 3378680-js-error-when: automatically created but it is not appearing in my fork

Please review.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Actually the same problems happens with "Show dots"...

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

The issue is caused by a malformed JSON if the arrow option is left out:

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

The class on the body has been replaced with .seeds_toolbar--light.
This avoids clashing with themes using .light and .dark

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Hey @YahyaAlHamad, thanks for the quick reply. Would you be interested if I try to implement the changes I mentioned in this ticket and in πŸ› body class "light" and "dark" may clash with themes with dark mode Needs review , πŸ“Œ Implement auto dark mode Active and πŸ› CSS may use some refactoring Active ?
I just don't want to waste time if something is already baking.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

The override was pointing to the wrong library

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

This can be quickly fixed by replacing the icon or by implementing this πŸ“Œ Use single colour-agnostic optimised icon set Active

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

As @samuel.mortenson already mentioned this is not going to change for now and he's not planning to commit it. Maybe it could be worth creating an extra input in the configuration form where each admin can put what they want (in another issue.

If anyone wants to change it, they can easy put a hook in their custom .module file:

/**
 * Implements hook_toolbar_alter().
 */
function mymodule_toolbar_alter(&$items) {
  // Changes the title of the 'Task' moderation sidebar tab.
  if (isset($items['moderation_sidebar'])) {
    $items['moderation_sidebar']['tab']['#title'] = t('Actions');
  }
}
πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Hey @jurgenhaas, I removed the commits past your one and amended it, in order to have the 'update' access check, in the original 3319445-edit-link-in branch you created, and force-pushed.
So now the diff from MR!25 should apply on 1.0.0-RC3, while MR!30 goes on 1.0.x-dev in order to get merged.
Please check since I didn't test it.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ created an issue.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

@anruether the Merge request provided fixes this issue, could you please review?

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

#11: the merge was blocked by a conflict and I (unsuccessfully) tried to rebase from upstream, sorry about the mess

#14: this is the new branch with the cherry picked commit by @jurgenhaas, with the merge fix.
I had to change the fix given that I tried with different roles and one of them (implementer) wasn't able to see the breadcrumb despite having the permission "[CT]: Edit its own content".

See here the differences between a moderator and a implementer:


The issue was basically the same as this one https://www.drupal.org/project/drupal/issues/3204423 β†’ , caused by the confusion of the names between "edit" and "update" for the entity access check.
Before: $entity->access('edit')
After: $entity->access('update')

Now it works nicely has expected, please review.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

@EricVL - I confirm solution #24 worked after updating to beta7. Thanks!

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

I had some custom code altering already the toolbar, once removed everything works as expected. Sorry for opening this one.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Patch attached with the correct selector.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

This fix currently throws an error when using the classic toolbar.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

Screenshot after patch.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ made their first commit to this issue’s fork.

πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

I can confirm this is happening again on a vanilla installation while editing content on the front end theme (Olivero).
By uninstalling the module the file field displays again.
Versions:

  1. gin 3.0.0-rc5
  2. gin_lb dev-1.0.x (d0376485)


πŸ‡¦πŸ‡ΊAustralia elgandoz Canberra

elgandoz β†’ made their first commit to this issue’s fork.

Production build 0.69.0 2024