- Issue created by @bernardopaulino
- 🇧🇪Belgium bernardopaulino Brussels
Here is a patch that should improve accessibility when using extra element option in the onomasticon text format filter.
- 🇧🇪Belgium bernardopaulino Brussels
Removed extra enter from the template to comply with coding standards.
- 🇩🇪Germany broon Potsdam
Thank you for your input. I am actually aware that the default way Onomasticon is using HTML elements is not proper and there is even a paragraph on that in the module's description page with a link to the discussion leading to the decision made: http://stackoverflow.com/questions/40531029/how-to-create-a-pure-css-too...
To summarize, it was requested to create a CSS-only solution which is able to include rich text in the term's description (including images).
I am open to patches that add an accessibility option but I will not change the default behaviour unless there is a better option that satisfies all requirements.
- Status changed to Closed: works as designed
almost 2 years ago 7:59pm 13 March 2023 - 🇩🇪Germany broon Potsdam
I am closing this as "works as designed" because of the original purpose of this module. If you do get time to work on your patch, I am happy to review. My suggestion would be to add a third option besides "Extra element" and "Title attribute", ie. "Accessibility first" (or similar).
- Status changed to Needs review
over 1 year ago 11:25am 22 September 2023 - 🇧🇪Belgium bernardopaulino Brussels
Thank you so much @broon for your feedback. I trully appreciate it.
I am uploading a new patch that incorporates your suggestion. This patch introduces a new option titled "Accessibility First" within the filter configurations. Additionally, I've ensured that it uses the same CSS styles as the "Extra Element" option.
I hope this approach aligns better with the requirements.
- Assigned to broon
- 🇩🇪Germany broon Potsdam
Thanks a lot for your effort. From a pure code perspective this looks fine. I'll test it and look for implications this might have (will take a few days).
- Issue was unassigned.
- Status changed to Fixed
about 1 year ago 11:41am 9 October 2023 Automatically closed - issue fixed for 2 weeks with no activity.