Linkit for Link field

I rebased 6.0.x on MR 12, also fixed the "LinkFieldTest", it was failing due link selectors that were based on link wrappers that don't exist on a stark theme.

I'll try and dig into it, but the current MR puts internal:/media/x instead of entity:/media/x so direct file URLs don't work again.

My bad, of course right after I post I see further up that "Standalone media URL" MUST be enabled. It is working.

I ran into a little issue with paragraphs where one of the paragraphs has a linkit-field. When the user types in an invalid uri and then tries to add a new paragraph-item, an exception is preventing the new paragraph to be added.
One part of the problem is that the add-more button in paragraphs has a limit_validation_errors, so no validation is done or error is shown at all. I tried removing this, but that didn't work properly: it would validate the whole form and show error-messages in a way that's confusing for the user. After a bit of digging, I found that the error is an exception thrown when trying to make an Url-object from the invalid uri. So after adding a try/catch, it works fine :)
I based this change on the patch in #293, as we're still using version 5.x of linkit.

Note that this change also requires a patch in core for the link field widget. (Same change basically): 3340154 🐛 Link-widget throws exception when rebuilding a form with an invalid uri Fixed

Per Berdir's good suggestion in #326, I've voided the removal of the .gz test fixture; that can be addressed in #3346274: Remove old test fixture of site install (gzipped file) → .

The merge request is updated an otherwise unchanged compared to the previous commit. The attached patch is a replica of the MR at commit 314cd74, provided so folks don't directly reference the MR diff in Composer.

Thank you @markfullmer the diff now successfully patches using composer. Attaching it here for convenience.

Just confirming that the patch applies cleanly, and the functionality it provides works great. Tested on two different sites with Linkit 6.0.0-beta4 and Drupal 9.5.4.

The latest change, reflected in last MR commit, only adds PHP coding syntax fixes; I omitted fixes for the changed JS file since it already had syntax violations and didn't want to increase the scope of this issue; those changes can be dealt with subsequently. I did a final manual functional review and everything checked out with the new Linkit field widget/formatter and there were no regressions to the existing CKEditor integration.

I've merged this into the 6.0.x branch, though I would like to leave it there for some time in order to allow for resolution of other issues with patches that might need to be updated, and for community reports of any as-yet undiscovered issues with this implementation. This will be included in the next release. See 🌱 LinkIt Release Roadmap and Issue Prioritization Active .

Thanks, everyone, for nearly eight years of work on this!

Created: 25 Apr 2016
Committed: 10 Mar 2023

that's really huge! thanks everyone!

Automatically closed - issue fixed for 2 weeks with no activity.

ref to https://www.drupal.org/project/linkit/issues/2712951#comment-14956491 ✨ Linkit for Link field Fixed
There is an issue when linking to content with ampersands or single quotes in the title
A js html decode function added

Add in missing new files to 2712951_331_1.6.x.patch

Open a new issue @inoodle