🇺🇸United States @schiavone

@trackleft2 The only difference between the updated patch in #34 and the patch in #3 is an update of the line number that sets the default setting to show the contextual link. So should the same apply to both patches? If there's a problem with updating the schema should we create an update?

Updated the patch for version 10.3.10

It's not a VBO issue. The hook_action in file entity is referencing a permission in pathauto that does not exist. Looks to me the function could be safely removed.

schiavone → created an issue.

The patch has been applied and merged into the 8.x-1.5 release. Thank you @Brauny for the patch and @jastraat for code review.

I think we should make this required moving forward since optional opens ups issues with Chrome and possible future issues with other browsers. So I'm going to change the title and review the PR to see if we can get this merged.

Need to be clear about the required Drupal 7 migration tag. If it is not included the migration fails with the error.

Drupal Core version not found for this migration

@adaderno can we reopen this?

This has been merged and included in the 8.x-1.4 release.

schiavone → created an issue.

schiavone → made their first commit to this issue’s fork.

Thanks everyone for working on this. Updates have been merged and included in the 8.x-1.3 release.

Thanks everyone for working on this. The patch has been applied and included in the 8.x-1.3 release.

schiavone → made their first commit to this issue’s fork.

Thanks @keshavv and @SamLerner I'll take a look and get this merged

Closed by https://git.drupalcode.org/project/tealiumiq/-/merge_requests/15

We only need to add utagsyncjs_load and utaganonymous to schemas. Reopening.

Thank you @ildiko.bocsor These changes have been merged and will be included in next release. Also, schemas for domain, content_type, logged_in, content_language, page_name have also been added. Configuration inspector now clear of errors.

schiavone → made their first commit to this issue’s fork.

Merged and will be included in next release (1.2).

Reviewed changes. Looks good.

schiavone → made their first commit to this issue’s fork.

Looks good and merged.

This is being addressed in https://www.drupal.org/project/tealiumiq/issues/3289974 📌 Automated Drupal 10 compatibility fixes Fixed

Thanks for this update. It has been merged and will be included in the 1.4 release.

@zegmant There is a separate issue → to make the module translatable.

This has been resolved by https://www.drupal.org/project/pager_for_content_type/issues/3352593 📌 Fix the issues reported by phpcs Fixed which brings up the module to current coding standards.

schiavone → made their first commit to this issue’s fork.

Conflicts resolved and merged.

Need to resolve merge conflicts.

Thanks @ omkar_yewale this looks good. I went ahead and rebased it.

@omkar_yewale phpcs is still reporting a few issues. Can you correct and update the MR?

ILE: /var/www/html/drupal9/web/modules/contrib/pager_for_content_type/pager_for_content_type.module
----------------------------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
----------------------------------------------------------------------------------------------------
  53 | ERROR | [x] Short array syntax must be used to define arrays
 145 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
 148 | ERROR | [x] TRUE, FALSE and NULL must be uppercase; expected "NULL" but found "null"
----------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------------------------------------


FILE: /var/www/html/drupal9/web/modules/contrib/pager_for_content_type/src/Form/PagerForContentTypeSettingsForm.php
-------------------------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
-------------------------------------------------------------------------------------------------------------------
 128 | ERROR | [x] Short array syntax must be used to define arrays
 138 | ERROR | [x] Short array syntax must be used to define arrays
-------------------------------------------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------------------------------------------

Thanks.

Thanks everyone for working on this. Merged.

schiavone → made their first commit to this issue’s fork.

@camille.davis this looks great. Thanks. Merging.

Ran into the same thing. Run

composer require thinkshout/mailchimp-api-php:^3.0.0-rc4

First then install with

composer require 'drupal/mailchimp:^2.2'

Success!

Any plans to create a Drupal 10 release dev or other?

Let's get this tested and merged! Happy to help.

Thank you @markfullmer the diff now successfully patches using composer. Attaching it here for convenience.