- Issue created by @camilledavis
- @camilledaviscivicactionscom opened merge request.
- Status changed to Needs review
over 1 year ago 9:27pm 6 April 2023 - Assigned to omkar_yewale
- Issue was unassigned.
- Status changed to Needs work
over 1 year ago 7:34am 7 April 2023 - 🇮🇳India omkar_yewale Mumbai
Hello @camille.davis, as per the requirement, the MR is working fine however a couple of changes are needed.
1) Before the pager_for_content_type_get_pager_items function adds new variables./** * Get pager items for a specific content type. * * @param array $pager * The pager array containing next and previous node IDs. * @param string $node_type * The machine name of the content type. * @param string $node_type_label * The label of the content type. * * @return array * The pager items as a render array. */
2) Add this to $config variable when repeating \Drupal::config('pager_for_content_type.settings')
$config = \Drupal::config('pager_for_content_type.settings');
- Status changed to Needs review
over 1 year ago 1:15am 8 April 2023 - 🇮🇳India omkar_yewale Mumbai
Hi @camille.davis The MR looks good now and works as expected, the maintainer can make a decision from here.
- Status changed to RTBC
over 1 year ago 3:16pm 25 April 2023 -
schiavone →
committed 8d511d93 on 8.x-1.x authored by
camille.davis@civicactions.com →
Issue #3352507 by camille.davis@civicactions.com: Allow users to enter a...
-
schiavone →
committed 8d511d93 on 8.x-1.x authored by
camille.davis@civicactions.com →
- 🇺🇸United States schiavone
@camille.davis this looks great. Thanks. Merging.
- Status changed to Fixed
over 1 year ago 4:56pm 25 April 2023 - 🇺🇸United States schiavone
@zegmant There is a separate issue → to make the module translatable.
- 🇺🇦Ukraine zegmant
it's about translated nodes.
but I mean that this arbitrary text like "Previous [content-type]" impossible to translate Automatically closed - issue fixed for 2 weeks with no activity.