🇺🇸United States @karlshea

This has been working in production for quite some time so I'm going to get this in.

karlshea → created an issue.

Thanks, @input!

Adding related issue 🐛 Date field is not displaying correct value on a views with aggregation max/min Needs work , date fields are also totally broken when aggregating.

This has been fixed in another issue

karlshea → created an issue.

Yes

I just tried Facets 3.x with views_filters_summary, configurable_views_filter_block, and bef—and most of it is broken with AJAX. It'll be great the day that might happen, but as of now it's no better a situation than using this patch which at least sometimes functions.

@emberhood from the original issue should get credit for this change.

karlshea → created an issue.

Not all of the patch changes made it in, so it's not possible to get or alter the enabled item. I'll open a new issue.

Added optional caching using the filecache module. It was suggested in Slack that moving either the cache or PrintBuilder to the factory pattern with a default null cache could work instead of altering the container, but I needed to get this live due to fix an overloaded website so would need to come back to that.

karlshea → made their first commit to this issue’s fork.

It is definitely still broken in beta3 for me as well.

Pushed some CS fixes for code added in this MR.

I also think trying to fix coding issues here is an exercise in futility, it'll just lead to more rebase/merge issues down the road.

I think some of the difficulty is from lots of merging instead of rebasing—I pushed up a MR with the 3255924-multiday-rendering-fix-merged-v1.1.patch applied and conflicts fixed, then a variable name fix.

It's working for me but I'm not sure I captured all of the fixes that were in the other two branches, I didn't know if some of those changes existed to fix issues or if they were from merge errors.

karlshea → made their first commit to this issue’s fork.

The example setup config can't be optional otherwise the example won't work.

I don't think a quick fix is going to make the example functional, and I'm not sure if it's worth the effort. Just use the code as a way of checking how to get your own migration to work.

Caching is opt-in, cache_lifetime: n needs to be added to the source configuration.

Adding two related issues about caching, in #2826938: Integrate HTTP fetcher with Guzzle Cache if available → heddn suggests using the guzzle_cache project, but that would rely on cache headers and it looks like the Sheets API is returning Cache-Control: max-age=0

In the MR I changed getSourceData() to more closely match what the parent Json::getSourceData() is doing, but it looks like executing it through the UI is where the issues occur.

When executing with Drush I'm only seeing two HTTP requests with or without these changes.

karlshea → created an issue.

Good idea!

Added DI and checked to make sure the key doesn't already exist in the URL.

karlshea → made their first commit to this issue’s fork.

karlshea → made their first commit to this issue’s fork.

Thank you! Looks like migrate_plus changed the method signature without bumping the minor version like they should have.

karlshea → made their first commit to this issue’s fork.

This is due to 📌 Switch command line escaping to Symfony Process Fixed , both addArgument and escapeArgument were removed in that issue.

Also fixes it for me!

Well, it gets things closer to default Views so this is going in. Open another issue if there's something missing for your use case.

Works for me!

I also need a separate patch on top for the facets range summary to work, I'm not sure if that should go into the MR or not?

This is the patch for DefaultFacetsSummaryManager:

             // @todo Keep non-facet related get params.
-            $url = Url::fromUserInput($facets_summary->getFacetSource()->getPath());
+            $path = \Drupal::service('path.current')->getPath();
+            /** @var \Drupal\path_alias\AliasManager $pathAliasManager */
+            $pathAliasManager = \Drupal::service('path_alias.manager');
+            $path = $pathAliasManager->getAliasByPath($path);
+            try {
+              $url = Url::fromUserInput($path);
+            }
+            catch (InvalidArgumentException $e) {
+              $url = Url::fromUri($path);
+            }

Rebased !162 on 2.0.x. It doesn't apply cleanly to 2.0.9 right now because there's been a change to facets-views-ajax.js since that was tagged, but that's the only change right now.

Yes, that's why I rebased the MRs.

Rebased on 2.3.0/3.3.0, fixed phpcs/phpstan issues.

Also fixed a bunch of stuff from phpcs/phpstan. Will have to live with the deprecated interface warning, using the static methods didn't work when the tests ran (was throwing an error about a missing chained service).

karlshea → created an issue.

karlshea → created an issue.

Does the fix in the MR work for you?

karlshea → made their first commit to this issue’s fork.

Is node one of the available types of content in one of your groups? Tried clearing caches? Otherwise you might have to debug yourself or wait for someone running Group 3.x to chime in, I'm not sure.

You should be able to use [node:group] tokens. I'm still using Group 2.x (MR 157), if you're on 3.x (MR 156) the MR might be wrong, but I haven't been able to test it.

Sure! The project I'm using this on has 17 migrations so I'm not hitting rate limits, but I can take a look at whatever you've got!

Oh it was totally the missing context_mapping! I had to fix that on the actual site I was working on *facepalm*

MR created against 2.0.x with most of #95.

I'm not sure where some of the tests for Drupal 8 should be (if anywhere at all), so that didn't make it in.

There also seems to be an issue in testBookNavigationBlockWithTopLevelPageTitle. I'm not sure what's going on there, the patch works on my local copy but when the test runs it can't find the block by ID.

Seconding needing more page margins. Having the header menu run into the side of the window when it has rounded corners looks weird, and the text on the left of most of the block types feels way too close to the edge of the screen. Similar issues with the images on the right side of the blocks with rounded corners hitting the scrollbar.

@jonmcl yes, that's correct! My computed media field has exactly the same code.

karlshea → created an issue.

My production settings is setting $config['entity_print.print_engine.phpwkhtmltopdf']['settings']['binary_location'] because I needed to install it with pyenv.

Did a cache clear help?

Using same approach as mercury_editor in 🐛 Mercury Editor dialogs won't open after upgrading to Drupal core 10.3 Fixed

It's also broken Bootstrap Modal, looking for event.dialog where instead the fix is to look for $event.dialog.

The MR can't be fixed until it's targeting the right branch, that's why it shows hundreds of commits.

The MR needs to target 11.x, not 11.0.x. I rebased it on 11.x but I can't edit the MR.

KarlShea → made their first commit to this issue’s fork.

Lots of core stuff hitting me recently too!

That makes way more sense lol it's been a long day!

Do you mean $settings['blazies']?->set('unlazy', FALSE);? If I do that I get a "Undefined array key "blazies"" warning.

KarlShea → created an issue.

Updated the description as well to reflect the actual issue

Sort of figured it out, I think it's a race. If I set a breakpoint when that extend happens instance.options is totally empty. But when it's logged it's not empty so it's getting updated somewhere else as this is running.

Actually that isn't working either, I'm still not getting all of the properties of both coming through.

KarlShea → created an issue.

Ahhh right, commit pushed with a static table definition.

Cool. Doesn't apply to 10.3 now. Love these MR patches.

Rebased on 11.x, I added most of #145 except for removing image_path_flush() in Media, that will affect every type not just OEmbed.

KarlShea → made their first commit to this issue’s fork.

Might just be tired but I'm failing to understand what is going on/what the request is for the @todo referencing this issue in MenuAccessTest::testSystemAdminMenuBlockAccessCheck(), could someone take a look?

@quietone, @wells I was also confused by #72 but removed the fallback code and rebased both MRs.

Oh good idea! I tested this with sql_generate_invisible_primary_key enabled and it worked just fine.