- Issue created by @kensae
- π§πͺBelgium kensae
After applying the changes from MR !77 the issue seems to be fixed.
See attached screenshots. - π§πͺBelgium dtfabio Ninove
Hi kensae,
I had two sites where the same problem occurred, for both the MR solved the problem.
Site version Drupal 10.2.8, PHP version 8.1.30.
Greetings,
Fabio
- π¬π§United Kingdom very_random_man
+1 to confirm this MR fixes the problem I was seeing with a recent update to Drupal 10.2.10 and Gin 3.0rc14. Thanks! :-)
- π§πͺBelgium matdemeue
I can confirm that the MR also works on Drupal 10.3.10 in combination with Gin 3.0rc14.
Running PHP version 8.2.26.Thanks! :)
- π¬π§United Kingdom samberry
Adding a patch file for this issue as this is more secure
- leymannx Berlin
RTBC++ and thank you @samberry for the static patch ππ»
- π©πͺGermany hanan alasari kassel
Thank you, the issue seems to be fixed.
- ππΊHungary thamas Hungary
Thanks @samberry for the patch! The solution also works for us. RTBC++ :)
- πΊπΈUnited States kmonty San Francisco, CA
Won't this patch cause a regression with RTL languages?
- π©πͺGermany yannickoo Berlin
@kmonty before
dir
attribute was used to determine whether to putmargin-left
ormargin-right
here. Now the patch is usingmargin-inline-start
which makes it already dynamic since this will be applied to the left or right based on the language direction of the user.Therefore I'm not expecting regressions here.
- πΊπΈUnited States ksenzee Washington state
Many thanks @kensae, my entire team owes you a beverage :D
- Status changed to RTBC
3 months ago 9:26am 30 January 2025 - π§πͺBelgium borisson_ Mechelen, π§πͺ
This works for us as well, I'll give it another RTBC++
- π§πͺBelgium tim-diels Belgium π§πͺ
Having this issue on multiple sites and this patch is working for us. So I'll give it also another RTBC++
- πΊπΈUnited States kmonty San Francisco, CA
Also +1 RTBC. My code concern was addressed. Given this project does not have automated tests, there does not appear to be any additional work that needs to be done.
- First commit to issue fork.
-
isholgueras β
committed bd0dea01 on 4.x authored by
kensae β
Issue #3487202: Gin vertical toolbar submenu's overlap
-
isholgueras β
committed bd0dea01 on 4.x authored by
kensae β
- πͺπΈSpain isholgueras
Thanks for the work. Merged into 4.x and ready for the 4.0.22
Automatically closed - issue fixed for 2 weeks with no activity.