🇧🇪Belgium @dtfabio

Hi everyone,

MR 15 fixed the problem for me on:

Core version 10.3.13
PHP version 8.1.31
MySQL version 8.0.4

Greetings,

Fabio

Hi xmacinfo,

Would it be possible to make a new release of the module with this change?

It is currently not possible to remove ckeditor from composer, due to the problem raised in comment #10 📌 Remove dependency on ckeditor as fakeobjects can also be used with ckeditor5 Active .

Given that with a new release, the patch can also be removed immediately, I think this way it's killing two birds with one stone.

Greetings,

Fabio

Hi jonathan1055,

I can confirm what iajon said in comment #11, I had the same problem on version 2.0.0 and the MR from #13 fixed it.

I then tested without the patch and version 2.0.0 of the module. This gave the same error after the updates on the status page.

If I then switched to the 3.0.4 version of the module, an update hook gets runs and the problem was fixed.

So I think the update is still needed to avoid problems with the 2.x version.

dtfabio → created an issue.

I am going to re-open this ticket as I am also still experiencing this problem on the 2.4.0 version of the module and the fix mentioned causes composer to crash so this solution is not usable.

Composer error:

Message during updb:

It would be nice if someone could offer a concrete upgrade path so that this error could be fixed.

Occurred on Drupal 10.2.8, PHP 8.1

Hi ericgsmith,

Thanks for the work, merge request 37 solved the problem for me.

Site Drupal core version 10.2.8, PHP version 8.1.

Greetings,

Fabio

dtfabio → created an issue.

Hi everyone,

We are using the patch ‘3232343-2-domain_source_performance_fix.patch’ in production currently and so I tried to re-roll the patch from seyfettinkahveci to the 2.0.x version of the module and created an MR for this.

Apparently, something did go wrong which meant that not all the modifications from the 2.0.x were present. I tried to fix this, but noticed that something is still not correct.

I will adjust this and pay better attention to prevent this kind of thing in the future.

Greetings,

Fabio

dtfabio → made their first commit to this issue’s fork.

Hi Anybody,

I am also still experiencing the same problem that the code gives a warning if the arrays passed to NestedArray::mergeDeep() contain a NULL value.

In my case, this happened logged in as webmaster, given the webmaster had no permissions to add attributes to the menu link item.

I have included alexrayu's code in an MR with one more check in case the user has no attribute add permissions, given that at this place a NULL was still passed to the mergeDeep function later in the code.

Behaviour without patch:

After adding the patch:

Would it be possible to review the change, so that a solution to this problem can be included in a future release?

Greetings,

Fabio

dtfabio → made their first commit to this issue’s fork.

Hi yobottehg,

After updating gin to rc-14 on Drupal version 10.2.8, I also had the problem that the preview buttons were shown even if they were disabled, MR 531 from the following ticket solved this problem for me:

Cannot opt out buttons using #gin_action_item = TRUE 🐛 Cannot opt out buttons using #gin_action_item = TRUE Active

Hope this will fix it for you as well.

Greetings,

Fabio

Hi kensae,

I had two sites where the same problem occurred, for both the MR solved the problem.

Site version Drupal 10.2.8, PHP version 8.1.30.

Greetings,

Fabio

dtfabio → created an issue.

dtfabio → created an issue.

dtfabio → created an issue.

Hi Tim,

Sorry for the delay, the commit has been pushed to the branch and the pipline for PHPCS is green again.

https://git.drupalcode.org/issue/views_exposed_sort_block-3358885/-/jobs...

Greetings,

Fabio

Hi Tim,

I have resolved the PHPCS issue locally, will push this change on the branch immediately.

Greetings,

Fabio

Hi Diwakar,

I checked the MR and the code looks good, pipline is also green so thanks for addressing the CSpell issues.

I will merge the change after all pipline issues are resolved in their respective brances.

This is to avoid unnecessary merge conflicts for the people who are implementing the changes.

Greetings,

Fabio

I tested the change on two standard Drupal instances, a D10 and D9 version because the module is supported for these versions.

I tried the change for both the text field, and the telephone number field. Works correctly for both, and for completeness I also tried all combinations of options (e.g. combining operators, reverse order, etc).

Just to try and rule out regression issues, everything still worked for as far that I could tell.

The only part I wasn't sure about is the "Select on focus" checkbox, I don't quite understand what the desired behaviour should be?

D10 instance specifications:

Drupal version = 10.3.1
PHP version = 8.2.20

D9 instance specifications:
Drupal version = 9.5.11
PHP version = 8.1.29

Hi cgoffin,

I will test out your changes from the MR.

Greetings,

Fabio

Hi Silvi,

When I run the pipeline again on this merge request I still get issues https://git.drupalcode.org/issue/activecampaign-3459297/-/jobs/2059320 , would it be possible to resolve these too and make sure the PHPCS pipline is running green.

PHP_CodeSniffer version 3.10.1 (stable) by Squiz and PHPCSStandards
$ composer show | awk '$0 ~ /codesniffer|coder|coding-standard|variable-analysis/ {print $1 " " $2}';
dealerdirect/phpcodesniffer-composer-installer 1.0.0
drupal/coder 8.3.24
sirbrillig/phpcs-variable-analysis 2.11.19
slevomat/coding-standard 8.15.0
squizlabs/php_codesniffer 3.10.1
$ vendor/bin/phpcs --config-show installed_paths
Using config file: /builds/issue/activecampaign-3459297/vendor/squizlabs/php_codesniffer/CodeSniffer.conf
installed_paths: ../../drupal/coder/coder_sniffer,../../sirbrillig/phpcs-variable-analysis,../../slevomat/coding-standard
$ vendor/bin/phpcs -i
The installed coding standards are MySource, PEAR, PSR1, PSR2, PSR12, Squiz, Zend, Drupal, DrupalPractice, VariableAnalysis and SlevomatCodingStandard
$ vendor/bin/phpcs -s $_WEB_ROOT/modules/custom --report-junit=junit.xml --report-full --report-summary --report-source $_PHPCS_EXTRA
FILE: ...459297/src/Plugin/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 55 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 74 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 94 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...9297/src/Plugin/Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
 56 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 75 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 95 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...gn-3459297/src/Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 61 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
 82 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...vecampaign_webform/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 40 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...9297/modules/activecampaign_dashboard/src/Form/ActiveCampaignDashboard.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 51 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
    |       |     (Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 193ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...tivecampaign_dashboard/src/Form/ActiveCampaignDashboard.php  1       0
...orm/src/Plugin/WebformHandler/ActiveCampaignFormHandler.php  1       0
...Plugin/Field/FieldFormatter/ActiveCampaignFormFormatter.php  2       0
.../Field/FieldWidget/ActiveCampaignFormAutocompleteWidget.php  3       0
...in/Field/FieldWidget/ActiveCampaignFormSelectListWidget.php  3       0
--------------------------------------------------------------------------------
A TOTAL OF 10 ERRORS AND 0 WARNINGS WERE FOUND IN 15 FILES
--------------------------------------------------------------------------------
PHPCBF CAN FIX 10 OF THESE SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
PHP CODE SNIFFER VIOLATION SOURCE SUMMARY
-----------------------------------------------------------------------------
    SOURCE                                                              COUNT
-----------------------------------------------------------------------------
[x] Drupal.Functions.MultiLineFunctionDeclaration.MissingTrailingComma  10
-----------------------------------------------------------------------------
A TOTAL OF 10 SNIFF VIOLATIONS WERE FOUND IN 1 SOURCE
-----------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SOURCES AUTOMATICALLY (10 VIOLATIONS IN TOTAL)
-----------------------------------------------------------------------------

dtfabio → created an issue.

dtfabio → created an issue.

dtfabio → created an issue.

dtfabio → created an issue.

dtfabio → created an issue.

I had the same problem with my Drupal 10.2.0 site after I wanted to re-import from a DB snapshot in ddev.

I started from a snapshot just before adding the translations and it kept failing to import the config.

The solution from the ticket linked here by n.dhuygelaere also solved my problem.

Hi Tim,

I tried the code change and the site now asks to turn on file and I no longer get a fatal error.

Greetings,

Fabio

Hi abhiyanshu,

Thanks for doing the work that needed to be done, only I did already mention I was going to take this up.

In the future, it is best that you first check if someone else has not already specified that they are working on this before starting the ticket.

This also ensures no duplication of work, which is certainly important for larger tickets.

It is also best practice to transfer the ticket to "Needs review" after the work has been done, so other developers know it needs to be looked at.

I will test your solution.

Greetings,

Fabio

Hi Tim,

I will check this out.

Greetings,

Fabio

dtfabio → created an issue.

Hi Dieter,

I finished testing the change, I have tested the module on three different Drupal instances.

First on a clean D9 installation core recommended version 9.5.11 PHP versions 8.0 and 8.1

Secondly on a clean D10 installation core recommended version 10.2.4, PHP version 8.1

And lastly on our Calibrate DXP install profile core recommended version 10.2.3, PHP version 8.1

Our install profile works with Imagemagic as the image toolkit and here I noticed that it did not take into account the status of Webp in the toolkit after the Drimage functionality was already enabled once (here I mean config wize, because the field was disabled on the form, but still enabled in config).

So have added another check in the DrimageSettingsForm on line 178 after the check on image toolkit support to see if Core Webp is enabled. So that it automaticly disables when support is removed, just as happens when enabling the image optimise webp module.

If you can review this change and it's ok for you, then I think this ticket may be put on RTBC.

Greetings,

Fabio

Hi Dieter,

I will test the new version, so that this ticket can be put on RTBC.

Greetings,

Fabio

Hi Tim,

I tried to fix the last issues, but saw there were merge conflicts so wanted to merge the dev branch into my branch.

Had apparently accidentally used the 1.2.x branch where changes happened to it, preventing me from creating a working patch. I then tried to fix this, without success.

I finally decided to just make a new branch with the latest changes, only with this I still can't make a working patch. I don't immediately see what the problem is, so I just provided the code and maybe you know the reason?

Greetings,

Fabio

dtfabio → changed the visibility of the branch 3374860-fix-phpstan-errors to active.

dtfabio → changed the visibility of the branch 3374860-fix-phpstan-errors to hidden.

borisson_ → credited dtfabio → .

Hi ChristianAdamski,

I also had the same problem on one of our sites using this module.

Drupal version: 10.1.5
PHP version: 8.1.11
Module version: 3.12.0

I got the error after entering a float with a comma as a separator instead of a full stop.

These values (Latitude : 29,9773, Longitude : 31,1325)

Gave the following error (see image):

Only there was a peculiarity, while creating my content the error did happen, but while editing I got the message (NaN) on the field after entering the values. (So after entering it correctly once, it doesn't seem to occur again.)

So validation did happen, but just not during initeal adding of the content?

The patch fixed the problem for me and the field still works. The only thing I am still somewhat unsure about is the message displayed.

In Belgium, this is a valid number (as we work with commas). So perhaps a conversion to full stop in the code or a mention under the field that a full stop is required would be useful, I think?

Just to be sure, I also tried your simplytest.me way, only with the difference that I used the latest release instead of the dev branch.

This is the test site status page.

Perhaps using the release version and not the dev branch caused the PHP version to be chosen correctly. Because in my instance, the site is PHP 8.1.

I fill in the fields with the test values listed above.

After which I am shown the following error on the page and the logs show the same error as on our production site.

I hope this is enough information to take a closer look at this ticket, so that this solution (possibly with a few more tweaks) can be included in to the module.

Greetings,

Fabio

Hi weseze,

I am currently at Drupal Con Lille and will try to make a first draft. To see if I can get this working.

Greetings,

Fabio

dtfabio → created an issue.

I added the code with the modification to the default config and the update hook in the cookiepro_plus-3387534 branch, would it be possible to take a look at this and then create a merge request.

I will modify the module config and write an update hook to also adjust this on already installed modules.

dtfabio → created an issue.

There is already a ticket for adding the config schema for the views exposed sort block block => 3352139 Provide config schema for block settings 📌 Provide config schema for block settings Needs review .

So I am updating the title and description to talk only about adding the config schema to the area plugin. So that adding it for the block can happen in the other issue.

dtfabio → created an issue.

The problem was that the submit button configuration was not saved, I added the needed code in the block submit function.

I will be working on this.

After testing on an existing site and briefly going through the views, I got the following error. This was because the parent execute function did not always return an empty array, it also returned NULL. To prevent this, I made the return type of the modules execute function nullable.

The website encountered an unexpected error. Please try again later.
TypeError: Drupal\views_block_override\Plugin\views\display\ViewsBlockOverride::execute(): Return value must be of type array, null returned in Drupal\views_block_override\Plugin\views\display\ViewsBlockOverride->execute() (line 392 of modules/contrib/views_block_override/src/Plugin/views/display/ViewsBlockOverride.php).

dtfabio → created an issue.

I have re-roled patch #16 to the current 2.1.x branch (works with the 2.1.3 release).

The modification was using the Drupal renderer service.

Hi mistergroove, I can confirm that I also get the same blue arrows when switching from v 3.3.1 to v 3.3.2 of the module.

I had added all the changes to the interdiff, my apologies here is the correct file.

I am currently working with @borisson on an internal Calibrate contribution day, I have incorporated his suggestion.

dtfabio → created an issue.

The API wrapper will change to the TestMonitor ActiveCampaign API 3 wrapper.

This library is the only one recently worked on by the maintainers and community.

Only there are a few API calls that have not been carried over, these will have to be added via Pull Request before the module can be completely ported.

For now, I will already implement the features that can be ported in the API v3 branch.

You're welcome pollegie,

I'm glad my explanation helped.

I'm adjusting the ticket description a bit so that this can be included as one of the 2.x roadmap tickets as a feature request.

This will also keep you informed once the feature is added to the module.

Greetings,

Fabio

dtfabio → created an issue.

Hi pollegie,

It is not yet possible at the moment to subscribe a user to a specific list, the webformhandler just sends the data through to Active Campaing.

To forward fields other than email, first name and last name, custom yaml mapping can be used.

This yaml mapping does not allow you to pass your own parameters to the api.

I will change the sentence "Edit the form data that will be sent to the ActiveCampaign site when a webform submission is made" to "To send additional fields other than the three basic fields provided, the custom yaml mapping can be used." in the description of the custom yaml field, because that may have caused the confusion.

We are, however, looking internally at providing this functionality in the new version of Active campaign, along with other features to give more flexibiliteit to users of the module.

I hope this answers your question?

Greetings,

Fabio