processHtmlAsString function returns boolean in content support url embed module

Created on 5 September 2023, about 1 year ago

Updated 14 September 2023, about 1 year ago

Problem/Motivation

When using the content support url embed module you will not see a cookie notification if you have not accepted cookies, but a 1.

This is because the processHtmlAsString function returns a boolean and this boolean is then used in the content swap on line 84 replaceNodeContent function in the CsUrlEmbedFilter class.

Steps to reproduce

Add a url embed field to a paragraph.
Enter a link to a youtube video.
Save and reject all cookies.
A 1 is displayed.

Proposed resolution

Open for disscusion.

Remaining tasks

Decide on the approach and implement it.

User interface changes

The applicable message is displayed instead of a 1.

API changes

None

Data model changes

None

🐛 Bug report

Status

Fixed

Version

1.0

Component

Code

Created by

🇧🇪Belgium dtfabio Ninove

Live updates comments and jobs are added and updated live.

Comments & Activities

Issue created by @dtfabio
First commit to issue fork.
Assigned to andreasderijcke
Comment about 1 year ago →
🇧🇪Belgium andreasderijcke Antwerpen / Gent
@andreasderijcke opened merge request.
Comment about 1 year ago →
System Message

andreasderijcke → committed c45335a1 on 1.0.x
Issue #3385300 by andreasderijcke, dtfabio: processHtmlAsString function...
Issue was unassigned.
Status changed to Fixed about 1 year ago12:59pm 14 September 2023
Comment about 1 year ago →
🇧🇪Belgium andreasderijcke Antwerpen / Gent
Comment about 1 year ago →
System Message
Automatically closed - issue fixed for 2 weeks with no activity.

contrib.social Blog FAQ Discussions

Production build 0.71.5 2024